You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by Srinivasa Kadamati <sr...@preset.io> on 2022/06/02 13:42:34 UTC
Re: [VOTE] Release Apache Superset 1.5.1 based on Superset 1.5.1rc1
I'm curious -- why is 1.5.1 missing this PR?
https://github.com/apache/superset/pull/19851
At least 1 organization is running Superset already with this PR applied in
their build!
On Sat, May 28, 2022 at 9:19 AM Ville Brofeldt <vi...@gmail.com>
wrote:
> Hi,
>
> Thanks Michael for putting together this release candidate. I tested the
> main flows, and everything seems to be working as expected.
>
> +1 (binding)
>
> Ville
>
> > On 27. May 2022, at 18.40, Michael S. Molina <mi...@gmail.com>
> wrote:
> >
> > Hello Superset Community,
> >
> > This is a call for the vote to release Apache Superset version 1.5.1.
> >
> > New cherries since 1.5.0:
> > - #19685 fix: login button does not render (@villebro)
> > - #20181 fix(temporary-cache): when user is anonymous (@villebro)
> > - #20091 fix: "Week Staring Monday" time grain for BigQuery
> (@ramunas-omnisend)
> > - #20135 fix: Allow dataset owners to see their datasets (@cccs-tom)
> > - #20123 fix(presto,trino): use correct literal dttm separator
> (@villebro)
> > - #20077 fix(generic-axes): apply contribution before flatten (@villebro)
> > - #19970 fix: Athena timestamp literal format (@thinhnd2104)
> > - #20055 fix(plugin-chart-echarts): support adhoc x-axis (@villebro)
> > - #18873 fix(sqllab/charts): casting from timestamp[us] to timestamp[ns]
> would result in out of bounds timestamp (@yeachan153)
> > - #19917 fix(sqla): replace custom dttm type with literal_column
> (@villebro)
> > - #19854 fix: Alpha should not be able to edit datasets that they don't
> own (@hughhhh)
> >
> > The release candidate:
> https://dist.apache.org/repos/dist/dev/superset/1.5.1rc1/
> >
> > Git tag for the release:
> https://github.com/apache/superset/tree/1.5.1rc1
> >
> > The Change Log for the release:
> https://github.com/apache/superset/blob/1.5.1rc1/CHANGELOG.md
> >
> > The Updating instructions for the release:
> https://github.com/apache/superset/blob/1.5.1rc1/UPDATING.md
> >
> > Public keys are available at: https://www.apache.org/dist/superset/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary
> number of votes is reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Superset Team
> >
>
>
Re: [VOTE] Release Apache Superset 1.5.1 based on Superset 1.5.1rc1
Posted by Srinivasa Kadamati <sr...@preset.io>.
Ah makes sense thanks!
On Thu, Jun 2, 2022 at 1:06 PM Michael S. Molina <mi...@gmail.com>
wrote:
> I just noticed that I referred to 1.5.1 as a "minor" release but I meant a
> “patch” release. Sorry for the confusion 😅
>
> > On Jun 2, 2022, at 11:04 AM, Ville Brofeldt <vi...@gmail.com>
> wrote:
> >
> > Hi,
> >
> > Michael is correct - in general I tend to refrain from cherrying big
> feature PRs to release branches after a release cut. 1.5.0 was already a
> tough release due to almost 6 months since the previous release and 4 RCs,
> so adding more big cherries would have likely resulted in the need for
> further RCs and an even more delayed release.
> >
> > Ville
> >
> >
> >> On 2. Jun 2022, at 16.56, Michael S. Molina <mi...@gmail.com>
> wrote:
> >>
> >> Srini,
> >>
> >> Maybe Ville is the best person to answer this question but if I had to
> guess, 1.5.0 didn’t contain this feature and since 1.5.1 is a minor
> release, it shouldn't include a new feature.
> >>
> >>
> >>> On Jun 2, 2022, at 10:42 AM, Srinivasa Kadamati <sr...@preset.io>
> wrote:
> >>>
> >>> I'm curious -- why is 1.5.1 missing this PR?
> >>>
> >>> https://github.com/apache/superset/pull/19851
> >>>
> >>> At least 1 organization is running Superset already with this PR
> applied in
> >>> their build!
> >>>
> >>> On Sat, May 28, 2022 at 9:19 AM Ville Brofeldt <
> ville.v.brofeldt@gmail.com>
> >>> wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> Thanks Michael for putting together this release candidate. I tested
> the
> >>>> main flows, and everything seems to be working as expected.
> >>>>
> >>>> +1 (binding)
> >>>>
> >>>> Ville
> >>>>
> >>>>> On 27. May 2022, at 18.40, Michael S. Molina <
> michael.s.molina@gmail.com>
> >>>> wrote:
> >>>>>
> >>>>> Hello Superset Community,
> >>>>>
> >>>>> This is a call for the vote to release Apache Superset version 1.5.1.
> >>>>>
> >>>>> New cherries since 1.5.0:
> >>>>> - #19685 fix: login button does not render (@villebro)
> >>>>> - #20181 fix(temporary-cache): when user is anonymous (@villebro)
> >>>>> - #20091 fix: "Week Staring Monday" time grain for BigQuery
> >>>> (@ramunas-omnisend)
> >>>>> - #20135 fix: Allow dataset owners to see their datasets (@cccs-tom)
> >>>>> - #20123 fix(presto,trino): use correct literal dttm separator
> >>>> (@villebro)
> >>>>> - #20077 fix(generic-axes): apply contribution before flatten
> (@villebro)
> >>>>> - #19970 fix: Athena timestamp literal format (@thinhnd2104)
> >>>>> - #20055 fix(plugin-chart-echarts): support adhoc x-axis (@villebro)
> >>>>> - #18873 fix(sqllab/charts): casting from timestamp[us] to
> timestamp[ns]
> >>>> would result in out of bounds timestamp (@yeachan153)
> >>>>> - #19917 fix(sqla): replace custom dttm type with literal_column
> >>>> (@villebro)
> >>>>> - #19854 fix: Alpha should not be able to edit datasets that they
> don't
> >>>> own (@hughhhh)
> >>>>>
> >>>>> The release candidate:
> >>>> https://dist.apache.org/repos/dist/dev/superset/1.5.1rc1/
> >>>>>
> >>>>> Git tag for the release:
> >>>> https://github.com/apache/superset/tree/1.5.1rc1
> >>>>>
> >>>>> The Change Log for the release:
> >>>> https://github.com/apache/superset/blob/1.5.1rc1/CHANGELOG.md
> >>>>>
> >>>>> The Updating instructions for the release:
> >>>> https://github.com/apache/superset/blob/1.5.1rc1/UPDATING.md
> >>>>>
> >>>>> Public keys are available at:
> https://www.apache.org/dist/superset/KEYS
> >>>>>
> >>>>> The vote will be open for at least 72 hours or until the necessary
> >>>> number of votes is reached.
> >>>>>
> >>>>> Please vote accordingly:
> >>>>>
> >>>>> [ ] +1 approve
> >>>>> [ ] +0 no opinion
> >>>>> [ ] -1 disapprove with the reason
> >>>>>
> >>>>> Thanks,
> >>>>> The Apache Superset Team
> >>>>>
> >>>>
> >>>>
> >>
> >
>
>
Re: [VOTE] Release Apache Superset 1.5.1 based on Superset 1.5.1rc1
Posted by "Michael S. Molina" <mi...@gmail.com>.
I just noticed that I referred to 1.5.1 as a "minor" release but I meant a “patch” release. Sorry for the confusion 😅
> On Jun 2, 2022, at 11:04 AM, Ville Brofeldt <vi...@gmail.com> wrote:
>
> Hi,
>
> Michael is correct - in general I tend to refrain from cherrying big feature PRs to release branches after a release cut. 1.5.0 was already a tough release due to almost 6 months since the previous release and 4 RCs, so adding more big cherries would have likely resulted in the need for further RCs and an even more delayed release.
>
> Ville
>
>
>> On 2. Jun 2022, at 16.56, Michael S. Molina <mi...@gmail.com> wrote:
>>
>> Srini,
>>
>> Maybe Ville is the best person to answer this question but if I had to guess, 1.5.0 didn’t contain this feature and since 1.5.1 is a minor release, it shouldn't include a new feature.
>>
>>
>>> On Jun 2, 2022, at 10:42 AM, Srinivasa Kadamati <sr...@preset.io> wrote:
>>>
>>> I'm curious -- why is 1.5.1 missing this PR?
>>>
>>> https://github.com/apache/superset/pull/19851
>>>
>>> At least 1 organization is running Superset already with this PR applied in
>>> their build!
>>>
>>> On Sat, May 28, 2022 at 9:19 AM Ville Brofeldt <vi...@gmail.com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> Thanks Michael for putting together this release candidate. I tested the
>>>> main flows, and everything seems to be working as expected.
>>>>
>>>> +1 (binding)
>>>>
>>>> Ville
>>>>
>>>>> On 27. May 2022, at 18.40, Michael S. Molina <mi...@gmail.com>
>>>> wrote:
>>>>>
>>>>> Hello Superset Community,
>>>>>
>>>>> This is a call for the vote to release Apache Superset version 1.5.1.
>>>>>
>>>>> New cherries since 1.5.0:
>>>>> - #19685 fix: login button does not render (@villebro)
>>>>> - #20181 fix(temporary-cache): when user is anonymous (@villebro)
>>>>> - #20091 fix: "Week Staring Monday" time grain for BigQuery
>>>> (@ramunas-omnisend)
>>>>> - #20135 fix: Allow dataset owners to see their datasets (@cccs-tom)
>>>>> - #20123 fix(presto,trino): use correct literal dttm separator
>>>> (@villebro)
>>>>> - #20077 fix(generic-axes): apply contribution before flatten (@villebro)
>>>>> - #19970 fix: Athena timestamp literal format (@thinhnd2104)
>>>>> - #20055 fix(plugin-chart-echarts): support adhoc x-axis (@villebro)
>>>>> - #18873 fix(sqllab/charts): casting from timestamp[us] to timestamp[ns]
>>>> would result in out of bounds timestamp (@yeachan153)
>>>>> - #19917 fix(sqla): replace custom dttm type with literal_column
>>>> (@villebro)
>>>>> - #19854 fix: Alpha should not be able to edit datasets that they don't
>>>> own (@hughhhh)
>>>>>
>>>>> The release candidate:
>>>> https://dist.apache.org/repos/dist/dev/superset/1.5.1rc1/
>>>>>
>>>>> Git tag for the release:
>>>> https://github.com/apache/superset/tree/1.5.1rc1
>>>>>
>>>>> The Change Log for the release:
>>>> https://github.com/apache/superset/blob/1.5.1rc1/CHANGELOG.md
>>>>>
>>>>> The Updating instructions for the release:
>>>> https://github.com/apache/superset/blob/1.5.1rc1/UPDATING.md
>>>>>
>>>>> Public keys are available at: https://www.apache.org/dist/superset/KEYS
>>>>>
>>>>> The vote will be open for at least 72 hours or until the necessary
>>>> number of votes is reached.
>>>>>
>>>>> Please vote accordingly:
>>>>>
>>>>> [ ] +1 approve
>>>>> [ ] +0 no opinion
>>>>> [ ] -1 disapprove with the reason
>>>>>
>>>>> Thanks,
>>>>> The Apache Superset Team
>>>>>
>>>>
>>>>
>>
>
Re: [VOTE] Release Apache Superset 1.5.1 based on Superset 1.5.1rc1
Posted by Ville Brofeldt <vi...@gmail.com>.
Hi,
Michael is correct - in general I tend to refrain from cherrying big feature PRs to release branches after a release cut. 1.5.0 was already a tough release due to almost 6 months since the previous release and 4 RCs, so adding more big cherries would have likely resulted in the need for further RCs and an even more delayed release.
Ville
> On 2. Jun 2022, at 16.56, Michael S. Molina <mi...@gmail.com> wrote:
>
> Srini,
>
> Maybe Ville is the best person to answer this question but if I had to guess, 1.5.0 didn’t contain this feature and since 1.5.1 is a minor release, it shouldn't include a new feature.
>
>
>> On Jun 2, 2022, at 10:42 AM, Srinivasa Kadamati <sr...@preset.io> wrote:
>>
>> I'm curious -- why is 1.5.1 missing this PR?
>>
>> https://github.com/apache/superset/pull/19851
>>
>> At least 1 organization is running Superset already with this PR applied in
>> their build!
>>
>> On Sat, May 28, 2022 at 9:19 AM Ville Brofeldt <vi...@gmail.com>
>> wrote:
>>
>>> Hi,
>>>
>>> Thanks Michael for putting together this release candidate. I tested the
>>> main flows, and everything seems to be working as expected.
>>>
>>> +1 (binding)
>>>
>>> Ville
>>>
>>>> On 27. May 2022, at 18.40, Michael S. Molina <mi...@gmail.com>
>>> wrote:
>>>>
>>>> Hello Superset Community,
>>>>
>>>> This is a call for the vote to release Apache Superset version 1.5.1.
>>>>
>>>> New cherries since 1.5.0:
>>>> - #19685 fix: login button does not render (@villebro)
>>>> - #20181 fix(temporary-cache): when user is anonymous (@villebro)
>>>> - #20091 fix: "Week Staring Monday" time grain for BigQuery
>>> (@ramunas-omnisend)
>>>> - #20135 fix: Allow dataset owners to see their datasets (@cccs-tom)
>>>> - #20123 fix(presto,trino): use correct literal dttm separator
>>> (@villebro)
>>>> - #20077 fix(generic-axes): apply contribution before flatten (@villebro)
>>>> - #19970 fix: Athena timestamp literal format (@thinhnd2104)
>>>> - #20055 fix(plugin-chart-echarts): support adhoc x-axis (@villebro)
>>>> - #18873 fix(sqllab/charts): casting from timestamp[us] to timestamp[ns]
>>> would result in out of bounds timestamp (@yeachan153)
>>>> - #19917 fix(sqla): replace custom dttm type with literal_column
>>> (@villebro)
>>>> - #19854 fix: Alpha should not be able to edit datasets that they don't
>>> own (@hughhhh)
>>>>
>>>> The release candidate:
>>> https://dist.apache.org/repos/dist/dev/superset/1.5.1rc1/
>>>>
>>>> Git tag for the release:
>>> https://github.com/apache/superset/tree/1.5.1rc1
>>>>
>>>> The Change Log for the release:
>>> https://github.com/apache/superset/blob/1.5.1rc1/CHANGELOG.md
>>>>
>>>> The Updating instructions for the release:
>>> https://github.com/apache/superset/blob/1.5.1rc1/UPDATING.md
>>>>
>>>> Public keys are available at: https://www.apache.org/dist/superset/KEYS
>>>>
>>>> The vote will be open for at least 72 hours or until the necessary
>>> number of votes is reached.
>>>>
>>>> Please vote accordingly:
>>>>
>>>> [ ] +1 approve
>>>> [ ] +0 no opinion
>>>> [ ] -1 disapprove with the reason
>>>>
>>>> Thanks,
>>>> The Apache Superset Team
>>>>
>>>
>>>
>
Re: [VOTE] Release Apache Superset 1.5.1 based on Superset 1.5.1rc1
Posted by "Michael S. Molina" <mi...@gmail.com>.
Srini,
Maybe Ville is the best person to answer this question but if I had to guess, 1.5.0 didn’t contain this feature and since 1.5.1 is a minor release, it shouldn't include a new feature.
> On Jun 2, 2022, at 10:42 AM, Srinivasa Kadamati <sr...@preset.io> wrote:
>
> I'm curious -- why is 1.5.1 missing this PR?
>
> https://github.com/apache/superset/pull/19851
>
> At least 1 organization is running Superset already with this PR applied in
> their build!
>
> On Sat, May 28, 2022 at 9:19 AM Ville Brofeldt <vi...@gmail.com>
> wrote:
>
>> Hi,
>>
>> Thanks Michael for putting together this release candidate. I tested the
>> main flows, and everything seems to be working as expected.
>>
>> +1 (binding)
>>
>> Ville
>>
>>> On 27. May 2022, at 18.40, Michael S. Molina <mi...@gmail.com>
>> wrote:
>>>
>>> Hello Superset Community,
>>>
>>> This is a call for the vote to release Apache Superset version 1.5.1.
>>>
>>> New cherries since 1.5.0:
>>> - #19685 fix: login button does not render (@villebro)
>>> - #20181 fix(temporary-cache): when user is anonymous (@villebro)
>>> - #20091 fix: "Week Staring Monday" time grain for BigQuery
>> (@ramunas-omnisend)
>>> - #20135 fix: Allow dataset owners to see their datasets (@cccs-tom)
>>> - #20123 fix(presto,trino): use correct literal dttm separator
>> (@villebro)
>>> - #20077 fix(generic-axes): apply contribution before flatten (@villebro)
>>> - #19970 fix: Athena timestamp literal format (@thinhnd2104)
>>> - #20055 fix(plugin-chart-echarts): support adhoc x-axis (@villebro)
>>> - #18873 fix(sqllab/charts): casting from timestamp[us] to timestamp[ns]
>> would result in out of bounds timestamp (@yeachan153)
>>> - #19917 fix(sqla): replace custom dttm type with literal_column
>> (@villebro)
>>> - #19854 fix: Alpha should not be able to edit datasets that they don't
>> own (@hughhhh)
>>>
>>> The release candidate:
>> https://dist.apache.org/repos/dist/dev/superset/1.5.1rc1/
>>>
>>> Git tag for the release:
>> https://github.com/apache/superset/tree/1.5.1rc1
>>>
>>> The Change Log for the release:
>> https://github.com/apache/superset/blob/1.5.1rc1/CHANGELOG.md
>>>
>>> The Updating instructions for the release:
>> https://github.com/apache/superset/blob/1.5.1rc1/UPDATING.md
>>>
>>> Public keys are available at: https://www.apache.org/dist/superset/KEYS
>>>
>>> The vote will be open for at least 72 hours or until the necessary
>> number of votes is reached.
>>>
>>> Please vote accordingly:
>>>
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>>
>>> Thanks,
>>> The Apache Superset Team
>>>
>>
>>