You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mm...@apache.org on 2006/09/10 07:08:02 UTC

svn commit: r441907 - /myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java

Author: mmarinschek
Date: Sat Sep  9 22:08:02 2006
New Revision: 441907

URL: http://svn.apache.org/viewvc?view=rev&rev=441907
Log:
comma was rendered for every child - only for UIParam child necessary.

Modified:
    myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java

Modified: myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
URL: http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java?view=diff&rev=441907&r1=441906&r2=441907
==============================================================================
--- myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java (original)
+++ myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java Sat Sep  9 22:08:02 2006
@@ -270,10 +270,6 @@
         StringBuffer params = new StringBuffer();
         params.append("[");
         for (Iterator it = getChildren(component).iterator(); it.hasNext();) {
-            if(params.length()>1)
-            {
-                params.append(",");
-            }
 
             UIComponent child = (UIComponent) it.next();
             if (child instanceof UIParameter) {
@@ -289,6 +285,12 @@
 
                 //UIParameter is no ValueHolder, so no conversion possible - calling .toString on value....
                 String strParamValue = value != null ? org.apache.myfaces.shared.renderkit.html.util.HTMLEncoder.encode(value.toString(), false, false) : "";
+
+
+                if(params.length()>1)
+                {
+                    params.append(",");
+                }
 
                 params.append("['");
                 params.append(name);