You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/02/24 05:32:34 UTC
[GitHub] zeppelin pull request #2063: ZEPPELIN-2148: On creation of Bar graph zeppeli...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2063
ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph
### What is this PR for?
On creation of Bar graph zeppelin UI shows it as mini graph, and is easily reproducible on safari.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148)
### How should this be tested?
Check screen shot.
### Screenshots (if appropriate)
Before:
After:
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2148
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2063.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2063
----
commit 38a1198b5a26d4f43962a5d2c730c34dc76f5d28
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-24T05:25:26Z
ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2063: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2063
@1ambda @Leemoonsoo Help review this. This fixes the problem, but with a dirty hack.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2063: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2063
On retrying the same build, CI is green now https://travis-ci.org/prabhjyotsingh/zeppelin/builds/204865706
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2063: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2063
Thank you for reviewing @r-kamath. I've handled it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2063: ZEPPELIN-2148: On creation of Bar graph zeppeli...
Posted by prabhjyotsingh <gi...@git.apache.org>.
GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/zeppelin/pull/2063
ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph
### What is this PR for?
On creation of Bar graph zeppelin UI shows it as mini graph, and is easily reproducible on safari.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148)
### How should this be tested?
Check screen shot.
### Screenshots (if appropriate)
Before:
After:
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2148
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2063.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2063
----
commit 38a1198b5a26d4f43962a5d2c730c34dc76f5d28
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-24T05:25:26Z
ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph
commit bb66897101c91ded018736a206bd177f9fd4802e
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-24T05:58:45Z
replace setTimeOut with $timeout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2063: ZEPPELIN-2148: On creation of Bar graph zeppeli...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2063
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2063: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2063
There were conflicts, will create a new PR for branch-0.7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2063: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2063
Merging this to master and branch-0.7 if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2063: ZEPPELIN-2148: On creation of Bar graph zeppeli...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2063
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---