You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/09/16 11:44:50 UTC
[GitHub] [logging-log4j2] ppkarwasz opened a new pull request, #1062: Sort release 2.x POM files
ppkarwasz opened a new pull request, #1062:
URL: https://github.com/apache/logging-log4j2/pull/1062
This PR performs two cleanup actions:
* it moves the `<scope>` of dependencies from the `<dependencyManagement>` and adds it wherever the dependencies are used. This has some beneficial effect: e.g. `log4j-api` **had** a transitive dependency of `javax.inject:javax.inject` in the **provided** scope because of the interaction between `maven-core` and our `<dependencyManagement>`. Now the dependency is in the **test** scope.
* it uses `src/tools/sort-pom.xslt` to sort all dependencies and plugins according to: the scope (import > provided > system > compile > runtime > text), the artifact id (except Log4j2 artifacts which come always first) and group id.
**Warning**: do not merge, until all dependency scope changes are accounted for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz merged pull request #1062: Sort release 2.x POM files
Posted by GitBox <gi...@apache.org>.
ppkarwasz merged PR #1062:
URL: https://github.com/apache/logging-log4j2/pull/1062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1062: Sort release 2.x POM files
Posted by GitBox <gi...@apache.org>.
ppkarwasz commented on PR #1062:
URL: https://github.com/apache/logging-log4j2/pull/1062#issuecomment-1250362697
The difference in the dependency list before and after this change is minimal:
* the transitive dependency `javax.inject` was before forced in the `provided` scope. It is now in the same scope as the artifact that depends on it,
* there are some version changes in the transitive dependencies due to the order change: guava (test scope) is bumped to `29.0-jre` in `log4j-core`, whereas asm is bumped from `7.0` to `7.2`,
* `commons-io`, `xz` and `netty-all` are not necessarily in the `test` scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org