You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/12 04:17:35 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25459: [SPARK-28734][DOC] Initial table of content in the left hand side bar for SQL doc

HyukjinKwon commented on a change in pull request #25459:
URL: https://github.com/apache/spark/pull/25459#discussion_r521829348



##########
File path: docs/css/main.css
##########
@@ -196,11 +196,14 @@ a.anchorjs-link:hover { text-decoration: none; }
   width: 210px;
   float: left;
   position: fixed;
+  overflow-y: scroll;
+  top: 0;
+  bottom: 0;
 }
 
 .left-menu {
   padding: 0px;
-  width: 199px;
+  width: 399px;

Review comment:
       Sorry for leaving a comment in an old PR but @dilipbiswal do you remember why you had to do this? It 
   ![Screen Shot 2020-11-12 at 1 16 25 PM](https://user-images.githubusercontent.com/6477701/98894991-5eb78f00-24e9-11eb-9c1d-bc6003591a1b.png)
   
   This makes each title look sort of truncated. I was thinking it should be like:
   
   ![Screen Shot 2020-11-12 at 1 16 46 PM](https://user-images.githubusercontent.com/6477701/98894985-5a8b7180-24e9-11eb-9e44-98c5dc2d71ad.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org