You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "asf-gitbox-commits (via GitHub)" <gi...@apache.org> on 2026/05/15 22:59:44 UTC
[PR] [INFRA] Set up default rulesets for default and release branches [thrift]
asf-gitbox-commits opened a new pull request, #3491:
URL: https://github.com/apache/thrift/pull/3491
This Pull Request enables the repository to conform with the "sane default security settings" of the Apache Software Foundation by configuring a default branch ruleset that protects the default branch and any release branches.
Note that `~DEFAULT_BRANCH` is a GitHub symbolic link to the current default branch (HEAD) of the repository and does not need changing.
If the managing project does not wish to set up these defaults, please close this Pull Request. Alternatively, the project may merge this Pull Request to apply the changes immediately.
If no action is taken, this Pull Request will be automatically merged by the Apache Infrastructure team on **2026-06-14** (30 days from now).
For any further information, please reach us on Slack or at: users@infra.apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on code in PR #3491:
URL: https://github.com/apache/thrift/pull/3491#discussion_r3431251809
##########
.asf.yaml:
##########
@@ -1,8 +1,21 @@
notifications:
- commits: commits@thrift.apache.org
- issues: dev@thrift.apache.org
- pullrequests_status: dev@thrift.apache.org
- pullrequests_comment: notifications@thrift.apache.org
- jira_options: link label worklog
-
-
\ No newline at end of file
+ commits: commits@thrift.apache.org
+ issues: dev@thrift.apache.org
+ pullrequests_status: dev@thrift.apache.org
+ pullrequests_comment: notifications@thrift.apache.org
+ jira_options: link label worklog
+
+github:
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
Review Comment:
Whatever you want. I mean, really. Pull request, check, merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #3491:
URL: https://github.com/apache/thrift/pull/3491#discussion_r3424305412
##########
.asf.yaml:
##########
@@ -1,8 +1,21 @@
notifications:
- commits: commits@thrift.apache.org
- issues: dev@thrift.apache.org
- pullrequests_status: dev@thrift.apache.org
- pullrequests_comment: notifications@thrift.apache.org
- jira_options: link label worklog
-
-
\ No newline at end of file
+ commits: commits@thrift.apache.org
+ issues: dev@thrift.apache.org
+ pullrequests_status: dev@thrift.apache.org
+ pullrequests_comment: notifications@thrift.apache.org
+ jira_options: link label worklog
+
+github:
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
Review Comment:
@Jens-G We're talking about tags only, not branches.
I see you updated the docs to use `release/<version>` instead of the shorter `rel/<version>`. If you're willing for the tags to be longer, why not also include my earlier suggestion to use `thrift-<version>` instead of just `<version>`? So, `release/thrift-<version>`. I think having the release artifact name in addition to the version makes a lot of sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on code in PR #3491:
URL: https://github.com/apache/thrift/pull/3491#discussion_r3255554144
##########
.asf.yaml:
##########
@@ -1,8 +1,21 @@
notifications:
- commits: commits@thrift.apache.org
- issues: dev@thrift.apache.org
- pullrequests_status: dev@thrift.apache.org
- pullrequests_comment: notifications@thrift.apache.org
- jira_options: link label worklog
-
-
\ No newline at end of file
+ commits: commits@thrift.apache.org
+ issues: dev@thrift.apache.org
+ pullrequests_status: dev@thrift.apache.org
+ pullrequests_comment: notifications@thrift.apache.org
+ jira_options: link label worklog
+
+github:
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
Review Comment:
Are we talking about branches or tags?
~Don't forget to adjust the ReleaseManagement document.~ [Done](https://github.com/apache/thrift/commit/fe86fc6e1d53be1c02a8e51e506fcf0572640ef3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on code in PR #3491:
URL: https://github.com/apache/thrift/pull/3491#discussion_r3255554144
##########
.asf.yaml:
##########
@@ -1,8 +1,21 @@
notifications:
- commits: commits@thrift.apache.org
- issues: dev@thrift.apache.org
- pullrequests_status: dev@thrift.apache.org
- pullrequests_comment: notifications@thrift.apache.org
- jira_options: link label worklog
-
-
\ No newline at end of file
+ commits: commits@thrift.apache.org
+ issues: dev@thrift.apache.org
+ pullrequests_status: dev@thrift.apache.org
+ pullrequests_comment: notifications@thrift.apache.org
+ jira_options: link label worklog
+
+github:
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
Review Comment:
Are we talking about branches or tags?
Don't forget to adjust the ReleaseManagement document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift]
Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on code in PR #3491:
URL: https://github.com/apache/thrift/pull/3491#discussion_r3251526483
##########
.asf.yaml:
##########
@@ -1,8 +1,21 @@
notifications:
- commits: commits@thrift.apache.org
- issues: dev@thrift.apache.org
- pullrequests_status: dev@thrift.apache.org
- pullrequests_comment: notifications@thrift.apache.org
- jira_options: link label worklog
-
-
\ No newline at end of file
+ commits: commits@thrift.apache.org
+ issues: dev@thrift.apache.org
+ pullrequests_status: dev@thrift.apache.org
+ pullrequests_comment: notifications@thrift.apache.org
+ jira_options: link label worklog
+
+github:
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
Review Comment:
@Jens-G we don't seem to use `release/` or `rel/`, should we protect release tags `v*` instead? Or rather in addition to, so you can use `release/0.24.0` for release work instead of `0.24.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on code in PR #3491:
URL: https://github.com/apache/thrift/pull/3491#discussion_r3431251809
##########
.asf.yaml:
##########
@@ -1,8 +1,21 @@
notifications:
- commits: commits@thrift.apache.org
- issues: dev@thrift.apache.org
- pullrequests_status: dev@thrift.apache.org
- pullrequests_comment: notifications@thrift.apache.org
- jira_options: link label worklog
-
-
\ No newline at end of file
+ commits: commits@thrift.apache.org
+ issues: dev@thrift.apache.org
+ pullrequests_status: dev@thrift.apache.org
+ pullrequests_comment: notifications@thrift.apache.org
+ jira_options: link label worklog
+
+github:
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
Review Comment:
Whatever you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3491:
URL: https://github.com/apache/thrift/pull/3491#issuecomment-4472660675
Added the `0.*` rule to protect existing release branches. Otherwise I'm fine with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #3491:
URL: https://github.com/apache/thrift/pull/3491#discussion_r3251557346
##########
.asf.yaml:
##########
@@ -1,8 +1,21 @@
notifications:
- commits: commits@thrift.apache.org
- issues: dev@thrift.apache.org
- pullrequests_status: dev@thrift.apache.org
- pullrequests_comment: notifications@thrift.apache.org
- jira_options: link label worklog
-
-
\ No newline at end of file
+ commits: commits@thrift.apache.org
+ issues: dev@thrift.apache.org
+ pullrequests_status: dev@thrift.apache.org
+ pullrequests_comment: notifications@thrift.apache.org
+ jira_options: link label worklog
+
+github:
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
Review Comment:
Because some projects have subprojects (multiple releases, with different names), I think it's a good opportunity to start using better tag names instead of just the raw version numbers, as in `rel/thrift-0.24.0`. If there's any sub-projects, like "thrift-examples", then it could be `rel/thrift-examples-1.0.0`, for example.
Having all the releases under one tag namespace allows other kinds of tags to be used for other purposes in their own namespace that don't look like `rel/` (e.g. release candidates, tests, abandoned branches, etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3491:
URL: https://github.com/apache/thrift/pull/3491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org