You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/10 08:54:45 UTC
[GitHub] [spark] jlpedrosa commented on a change in pull request #24702:
[SPARK-27989] [Kubernetes] [Core] Added retries on the connection to the
driver for k8s
jlpedrosa commented on a change in pull request #24702: [SPARK-27989] [Kubernetes] [Core] Added retries on the connection to the driver for k8s
URL: https://github.com/apache/spark/pull/24702#discussion_r291930392
##########
File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java
##########
@@ -173,9 +173,11 @@ public TransportClient createClient(String remoteHost, int remotePort)
final InetSocketAddress resolvedAddress = new InetSocketAddress(remoteHost, remotePort);
final long hostResolveTimeMs = (System.nanoTime() - preResolveHost) / 1000000;
if (hostResolveTimeMs > 2000) {
- logger.warn("DNS resolution for {} took {} ms", resolvedAddress, hostResolveTimeMs);
+ logger.warn("DNS resolution for {} took {} ms isUnresolved {}",
+ resolvedAddress, hostResolveTimeMs, resolvedAddress.isUnresolved());
Review comment:
Fixed in code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org