You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/28 09:39:00 UTC
[GitHub] [incubator-doris] 924060929 opened a new pull request, #9294: [Enhancement](regression-test) Support suite plugin to add third-part…
924060929 opened a new pull request, #9294:
URL: https://github.com/apache/incubator-doris/pull/9294
# Proposed changes
Issue Number: No issure
## Problem Summary:
Support register suite plugin to add third-party function.
See
1. register in: ${DORIS_HOME}/regression-test/plugins/plugin_example.groovy
2. usage: ${DORIS_HOME}/regression-test/suites/demo/test_plugin.groovy
3. doc: ${DORIS_HOME}/docs/zh-CN/developer-guide/regression-testing.md
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No
4. Has document been added or modified: Yes
5. Does it need to update dependencies: No
6. Are there any changes that cannot be rolled back: Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] 924060929 commented on a diff in pull request #9294: [Enhancement](regression-test) Support suite plugin to add third-part…
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #9294:
URL: https://github.com/apache/incubator-doris/pull/9294#discussion_r861437066
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/RegressionTest.groovy:
##########
@@ -251,6 +253,30 @@ class RegressionTest {
}
}
+ static void loadPlugins(Config config) {
+ if (config.pluginPath.is(null) || config.pluginPath.isEmpty()) {
+ return
+ }
+ def pluginPath = new File(config.pluginPath)
+ if (!pluginPath.exists() && !pluginPath.isDirectory()) {
Review Comment:
oops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9294: [Enhancement](regression-test) Support suite plugin to add third-part…
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9294:
URL: https://github.com/apache/incubator-doris/pull/9294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] 924060929 commented on a diff in pull request #9294: [Enhancement](regression-test) Support suite plugin to add third-part…
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #9294:
URL: https://github.com/apache/incubator-doris/pull/9294#discussion_r861437990
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/RegressionTest.groovy:
##########
@@ -251,6 +253,30 @@ class RegressionTest {
}
}
+ static void loadPlugins(Config config) {
+ if (config.pluginPath.is(null) || config.pluginPath.isEmpty()) {
+ return
+ }
+ def pluginPath = new File(config.pluginPath)
+ if (!pluginPath.exists() && !pluginPath.isDirectory()) {
Review Comment:
> maybe it should be
>
> ```
> !pluginPath.exists() || !pluginPath.isDirectory()
> ```
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9294: [Enhancement](regression-test) Support suite plugin to add third-part…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9294:
URL: https://github.com/apache/incubator-doris/pull/9294#issuecomment-1112882945
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #9294: [Enhancement](regression-test) Support suite plugin to add third-part…
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #9294:
URL: https://github.com/apache/incubator-doris/pull/9294#discussion_r861431841
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/RegressionTest.groovy:
##########
@@ -251,6 +253,30 @@ class RegressionTest {
}
}
+ static void loadPlugins(Config config) {
+ if (config.pluginPath.is(null) || config.pluginPath.isEmpty()) {
+ return
+ }
+ def pluginPath = new File(config.pluginPath)
+ if (!pluginPath.exists() && !pluginPath.isDirectory()) {
Review Comment:
maybe it should be
```
!pluginPath.exists() || !pluginPath.isDirectory()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9294: [Enhancement](regression-test) Support suite plugin to add third-part…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9294:
URL: https://github.com/apache/incubator-doris/pull/9294#issuecomment-1116896931
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org