You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/11/26 06:45:37 UTC
[GitHub] zeppelin pull request #1685: [ZEPPELIN-1714] Build error of scio Intepreter ...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1685
[ZEPPELIN-1714] Build error of scio Intepreter on Centos
### What is this PR for?
This PR fixes build error of scio Intepreter on CentOS.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1714
### How should this be tested?
Run `mvn clean package -DskipTest' on CentOS
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin fix/scio-builderror
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1685.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1685
----
commit 330f38d3450e74eca559abec0ae4e7933c82441d
Author: astroshim <hs...@nflabs.com>
Date: 2016-11-26T06:39:44Z
add scala prefix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1685: [ZEPPELIN-1714] Build error of scio Intepreter on Cent...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1685
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1685: [ZEPPELIN-1714] Build error of scio Intepreter on Cent...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1685
Merge into master if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1685: [ZEPPELIN-1714] Build error of scio Intepreter on Cent...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1685
@astroshim Tested on CentOS 7 again and faced the issue you described.
Also I checked the other files that contains `import scala.tools.nsc.*` (e.g. [FlinkInterpreter.java](https://github.com/apache/zeppelin/blob/master/flink/src/main/java/org/apache/zeppelin/flink/FlinkInterpreter.java), [DepInterpreter.java](https://github.com/apache/zeppelin/blob/master/spark/src/main/java/org/apache/zeppelin/spark/DepInterpreter.java), [IgniteInterpreter.java](https://github.com/apache/zeppelin/blob/master/ignite/src/main/java/org/apache/zeppelin/ignite/IgniteInterpreter.java) and etc etc.. ) are all importing not `tools.nsc..` but `scala.tools.nsc...`.
So anyway LGTM :D \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1685: [ZEPPELIN-1714] Build error of scio Intepreter ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1685: [ZEPPELIN-1714] Build error of scio Intepreter on Cent...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1685
@astroshim Thanks for your contribution.
Tested with master branch in `CentOS release 6.8 (Final)`, but I can successfully build latest master branch.
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [ 13.677 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [ 5.024 s]
[INFO] Zeppelin: Scio ..................................... SUCCESS [01:08 min]
[INFO] Zeppelin: Server ................................... SUCCESS [ 19.772 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:47 min
[INFO] Finished at: 2016-11-26T20:17:22+09:00
[INFO] Final Memory: 137M/3563M
[INFO] ------------------------------------------------------------------------
```
```
[fbdkdud93@worker9 zeppelin]$ lsb_release -d
Description: CentOS release 6.8 (Final)
```
Could you elaborate which version you are using now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1685: [ZEPPELIN-1714] Build error of scio Intepreter on Cent...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1685
@AhyoungRyu Thank you for reviewing. I am using Zeppelin master on CentOS-7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---