[GitHub] [incubator-echarts] WebCodePro719 edited a comment on issue #11566: Add files via upload - New theme JS files

[GitBox <gi...@apache.org>]

WebCodePro719 edited a comment on issue #11566: Add files via upload - New theme JS files
URL: https://github.com/apache/incubator-echarts/pull/11566#issuecomment-551989072
 
 
   @pissang I've updated all the theme JS files so that "k" is renamed as "candlestick" and "force" is renamed as "graph." 
   
   For the hierarchy of itemStyle, are you saying that "normal: {....}" should be removed?
   
   For example, in azul,js, would this code be correct?:
   
   `candlestick: {
   	itemStyle: {
                    color: '#f2385a',
                    color0: '#f5a503',
   	},
   	lineStyle: {
                    width: 1,
                    color: '#f2385a',
                    color0: '#f5a503',
   	},
   	areaStyle: {
                    color: '#eee',
                    color0: '#ddd'
   	}
   },
   
   graph: { 
   	itemStyle: {
                    color: '#f2385a',
   	},
           linkStyle: {
                    color: '#f2385a'
           }
   },
   
   
   map: { 
   	itemStyle: {
                    color: '#f2385a',
   	},
   	areaStyle: {
                    color: '#eee',
                    label: {
                       textStyle: {
                           color: '#c12e34'
                       }
                 }
   	}
   },`
   
   Please let me know if I've update the code correctly in the above example. If so, I'll go through and update all the theme JS files to reflect these code changes.
   
   If you see anything else that needs to be fixed (based on azul.js). please let me know. Thanks!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org