You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Russole (via GitHub)" <gi...@apache.org> on 2025/12/28 03:54:25 UTC
[PR] HDDS-12455. Merge the SimpleMockNodeManager with MockNodeManager [ozone]
Russole opened a new pull request, #9569:
URL: https://github.com/apache/ozone/pull/9569
## What changes were proposed in this pull request?
* Refactored `MockNodeManager` to properly handle decommission and maintenance states, resolving inconsistencies in `nodeMap` and `NodeOperationalState` handling between `MockNodeManager` and `SimpleMockNodeManager`.
* Ensured `nodeMap` as the single source of truth and kept it in sync with `DatanodeDetails` and persisted operational state.
* Aligned `MockNodeManager` behavior with `SimpleMockNodeManager` to ensure consistent node operational state transitions in tests.
* Added unit tests to verify `setNodeOperationalState` updates `NodeStatus` (including expiry) and throws `NodeNotFoundException` for unknown nodes.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12455
## How was this patch tested?
All existing GitHub CI checks passed, and the newly added unit tests passed successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12455. Merge the SimpleMockNodeManager with MockNodeManager [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9569:
URL: https://github.com/apache/ozone/pull/9569#issuecomment-3857068933
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12455. Merge the SimpleMockNodeManager with MockNodeManager [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9569:
URL: https://github.com/apache/ozone/pull/9569#issuecomment-3894075256
Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12455. Merge the SimpleMockNodeManager with MockNodeManager [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #9569: HDDS-12455. Merge the SimpleMockNodeManager with MockNodeManager
URL: https://github.com/apache/ozone/pull/9569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12455. Merge the SimpleMockNodeManager with MockNodeManager [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9569:
URL: https://github.com/apache/ozone/pull/9569#issuecomment-3718435173
> Havent look into the code, but can replace all simple mock node manager with mock node manager? after this refactor.
I also think that the goal of the task is to get rid of `SimpleMockNodeManager`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12455. Merge the SimpleMockNodeManager with MockNodeManager [ozone]
Posted by "Russole (via GitHub)" <gi...@apache.org>.
Russole commented on PR #9569:
URL: https://github.com/apache/ozone/pull/9569#issuecomment-3745269856
Thanks for the clarification — I agree that the goal is to remove SimpleMockNodeManager.
I’ll take another look with this direction in mind. Thanks @peterxcli and @adoroszlai for the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org