[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #56: Add MeterReportService collectBatch method.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #56:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/56#discussion_r748697827



##########
File path: language-agent/MeterCompat.proto
##########
@@ -30,4 +30,8 @@ service MeterReportService {
     // Meter data is reported in a certain period. The agent/SDK should report all collected metrics in this period through one stream.
     rpc collect (stream skywalking.v3.MeterData) returns (skywalking.v3.Commands) {
     }
+
+    // It is recommended to keep the stream alive for performance considerations
+    rpc collectBatch (stream skywalking.v3.MeterDataCollection) returns (skywalking.v3.Commands) {
+    }

Review comment:
       We don't need this. Compat is for old release, clearly, there would not be any old release implemented this new service.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org