[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8771: [IOTDB-5378] Implement Iterating Query for MTree Node Query

[GitBox <gi...@apache.org>]

MarcosZyk commented on code in PR #8771:
URL: https://github.com/apache/iotdb/pull/8771#discussion_r1063424040


##########
server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTreeBelowSGCachedImpl.java:
##########
@@ -1065,4 +1011,39 @@ public void updateMNode(IMNode node) throws MetadataException {
 
   // endregion
 
+  // region Interfaces for schema reader
+  public ISchemaReader<INodeSchemaInfo> getNodeReader(IShowNodesPlan showNodesPlan)

Review Comment:
   Since the MTreeBelowSGCachedImpl and MTreeBelowSGMemoryImpl are used in different SchemaRegionImpl and there's no scenarios that they serve the same invoker, I think we can remove the interface ```IMTreeBelowSG``` in future work.



##########
server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTreeBelowSGMemoryImpl.java:
##########
@@ -916,4 +862,40 @@ protected boolean processFullMatchedMNode(IMNode node, int idx, int level)
   }
 
   // endregion
+
+  // region Interfaces for schema reader
+  public ISchemaReader<INodeSchemaInfo> getNodeReader(IShowNodesPlan showNodesPlan)

Review Comment:
   Since the MTreeBelowSGCachedImpl and MTreeBelowSGMemoryImpl are used in different SchemaRegionImpl and there's no scenarios that they serve the same invoker, I think we can remove the interface IMTreeBelowSG in future work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org