You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Alexis Midon (JIRA)" <ji...@apache.org> on 2009/11/19 22:29:39 UTC
[jira] Created: (ODE-708) Some events might not be retried
Some events might not be retried
--------------------------------
Key: ODE-708
URL: https://issues.apache.org/jira/browse/ODE-708
Project: ODE
Issue Type: Bug
Affects Versions: 1.3.3, 1.3.2
Reporter: Alexis Midon
Fix For: 1.3.4
When a JobProcessor exceptions is thrown in BpelEngineImpl, the method BpelEngineImpl#checkRetry is invoked to determine if the job should be retried or not.
checkRetry intends to return false if the job is in-memory. But the test is error prone:
jobInfo.jobDetail.get("inmem") == null;
This will false if a value is set in the map, even if the value is true.
The test should be:
Boolean bool = (Boolean) _jobDetail.get("inmem");
if (bool == null) return false;
else return bool;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-708) Some events might not be retried
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780293#action_12780293 ]
Alexis Midon commented on ODE-708:
----------------------------------
fixed in 1.X, revision: 882308
> Some events might not be retried
> --------------------------------
>
> Key: ODE-708
> URL: https://issues.apache.org/jira/browse/ODE-708
> Project: ODE
> Issue Type: Bug
> Affects Versions: 1.3.2, 1.3.3
> Reporter: Alexis Midon
> Fix For: 1.3.4
>
>
> When a JobProcessor exceptions is thrown in BpelEngineImpl, the method BpelEngineImpl#checkRetry is invoked to determine if the job should be retried or not.
> checkRetry intends to return false if the job is in-memory. But the test is error prone:
> jobInfo.jobDetail.get("inmem") == null;
> This will false if a value is set in the map, even if the value is true.
> The test should be:
> Boolean bool = (Boolean) _jobDetail.get("inmem");
> if (bool == null) return false;
> else return bool;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ODE-708) Some events might not be retried
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon resolved ODE-708.
------------------------------
Resolution: Fixed
does not apply to trunk
> Some events might not be retried
> --------------------------------
>
> Key: ODE-708
> URL: https://issues.apache.org/jira/browse/ODE-708
> Project: ODE
> Issue Type: Bug
> Affects Versions: 1.3.2, 1.3.3
> Reporter: Alexis Midon
> Fix For: 1.3.4
>
>
> When a JobProcessor exceptions is thrown in BpelEngineImpl, the method BpelEngineImpl#checkRetry is invoked to determine if the job should be retried or not.
> checkRetry intends to return false if the job is in-memory. But the test is error prone:
> jobInfo.jobDetail.get("inmem") == null;
> This will false if a value is set in the map, even if the value is true.
> The test should be:
> Boolean bool = (Boolean) _jobDetail.get("inmem");
> if (bool == null) return false;
> else return bool;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.