You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "alien11689 (via GitHub)" <gi...@apache.org> on 2025/02/01 13:21:07 UTC
[PR] ARIES-2165: Update parent pom and build proxy on Java 11, 17 and 21 [aries]
alien11689 opened a new pull request, #414:
URL: https://github.com/apache/aries/pull/414
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2165: Build proxy on Java 11, 17 and 21 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on PR #414:
URL: https://github.com/apache/aries/pull/414#issuecomment-3820877285
Hi @jbonofre
I have rebased this branch and added support also for java 25
This PR is nearly one year old - if you don't mind, I'll merge it on Sunday
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2165: Build proxy on Java 11, 17 and 21 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 merged PR #414:
URL: https://github.com/apache/aries/pull/414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2165: Build proxy on Java 11, 17 and 21 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on PR #414:
URL: https://github.com/apache/aries/pull/414#issuecomment-3724547451
thank you @jbonofre
I quick rebase should be enough on this PR, there should be not a lot of conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2165: Update parent pom and build proxy on Java 11, 17 and 21 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on code in PR #414:
URL: https://github.com/apache/aries/pull/414#discussion_r1943495410
##########
proxy/proxy-impl/src/test/java/org/apache/aries/blueprint/proxy/ProxySubclassGeneratorTest.java:
##########
@@ -173,6 +174,7 @@ public void testFinalClass() throws Exception
* Test a private constructor
*/
@Test
+ @Ignore
Review Comment:
objenesis seems to be good replacement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2165: Update parent pom and build proxy on Java 11, 17 and 21 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on code in PR #414:
URL: https://github.com/apache/aries/pull/414#discussion_r1940064916
##########
proxy/proxy-impl/src/test/java/org/apache/aries/blueprint/proxy/ProxySubclassGeneratorTest.java:
##########
@@ -173,6 +174,7 @@ public void testFinalClass() throws Exception
* Test a private constructor
*/
@Test
+ @Ignore
Review Comment:
I haven't found good replacement for sun.reflect.* to make private constructor accessible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2165: Build proxy on Java 11, 17 and 21 [aries]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #414:
URL: https://github.com/apache/aries/pull/414#issuecomment-3721877884
@alien11689 I would say that JDK 17 and 21 are good enough. I will resume work on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2165: Build proxy on Java 11, 17 and 21 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on PR #414:
URL: https://github.com/apache/aries/pull/414#issuecomment-3368995575
It's probably hard to measure but I think we have still a lot of Java 8 users. Additionally, the biggest subprojects - blueprint and subsystem - are not buildable with Java > 8.
Indeed keeping support for Java LTS 8 to 21 is quite hard and now there is also 25, so limiting the number of supported version would make the maintenance easier.
What Java version would you recommend @jbonofre ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2165: Build proxy on Java 11, 17 and 21 [aries]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #414:
URL: https://github.com/apache/aries/pull/414#issuecomment-3368969440
I'm testing it fully, it looks good so far.
I just wonder if we strictly have to keep JDK8. Thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org