You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/15 00:41:55 UTC

[GitHub] Jackie-Jiang commented on a change in pull request #3475: Enhance controller periodic task and scheduler

Jackie-Jiang commented on a change in pull request #3475: Enhance controller periodic task and scheduler
URL: https://github.com/apache/incubator-pinot/pull/3475#discussion_r233676061
 
 

 ##########
 File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java
 ##########
 @@ -60,38 +68,29 @@ public void run() {
   }
 
   private void skipLeaderTask() {
-    if (getAmILeader()) {
+    if (_wasLeader) {
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org