[GitHub] [skywalking-python] tom-pytel opened a new pull request #161: spans correctly reference finished parents

[GitBox <gi...@apache.org>]

tom-pytel opened a new pull request #161:
URL: https://github.com/apache/skywalking-python/pull/161


   Spans will now correctly create a new context and reference a parent when that parent context had already finished and the segment was archived. For example, previously, the tornado handler below did not correctly record the `requests.get()` because it executed after the parent task had already finished. Now it does:
   ```py
   class Dead(tornado.web.RequestHandler):
       async def out(self):
           await asyncio.sleep(1)
           requests.get('http://www.google.com/')
   
       async def get(self):
           asyncio.create_task(self.out())
           self.write('Hello from dead link')
   ```
   
   <!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
   <!--
   - [ ] Add a test case for the new plugin
   - [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
   - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
   - [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] kezhenxu94 merged pull request #161: spans correctly reference finished parents

[GitBox <gi...@apache.org>]

kezhenxu94 merged pull request #161:
URL: https://github.com/apache/skywalking-python/pull/161


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org