You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2017/02/13 20:45:11 UTC

Review Request 56612: RANGER-1382:Good coding practice in Ranger recommended by static code analysis

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56612/
-----------------------------------------------------------

Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.


Bugs: Ranger-1382
    https://issues.apache.org/jira/browse/Ranger-1382


Repository: ranger


Description
-------

RANGER-1382:Good coding practice in Ranger recommended by static code analysis


Diffs
-----

  agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileCacheProviderSpool.java 94db401 

Diff: https://reviews.apache.org/r/56612/diff/


Testing
-------

Tested in Local Vm


Thanks,

Ramesh Mani


Re: Review Request 56612: RANGER-1382:Good coding practice in Ranger recommended by static code analysis

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56612/#review165490
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Feb. 13, 2017, 8:45 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56612/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 8:45 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: Ranger-1382
>     https://issues.apache.org/jira/browse/Ranger-1382
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-1382:Good coding practice in Ranger recommended by static code analysis
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileCacheProviderSpool.java 94db401 
> 
> Diff: https://reviews.apache.org/r/56612/diff/
> 
> 
> Testing
> -------
> 
> Tested in Local Vm
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Re: Review Request 56612: RANGER-1382:Good coding practice in Ranger recommended by static code analysis

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56612/#review165492
-----------------------------------------------------------


Ship it!




Ship It!

- Gautam Borad


On Feb. 13, 2017, 8:45 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56612/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 8:45 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: Ranger-1382
>     https://issues.apache.org/jira/browse/Ranger-1382
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-1382:Good coding practice in Ranger recommended by static code analysis
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileCacheProviderSpool.java 94db401 
> 
> Diff: https://reviews.apache.org/r/56612/diff/
> 
> 
> Testing
> -------
> 
> Tested in Local Vm
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>