ReplicaNotAvailableCode

[Joe Stein <jo...@stealth.ly>]

An issue/question just came up with a client library
https://github.com/Shopify/sarama/pull/142#issuecomment-51707301 the wiki
for the wire protocol had error code = 9 as unused I just updated it
for ReplicaNotAvailableCode and put a description
https://cwiki.apache.org/confluence/pages/diffpages.action?pageId=30743483&originalId=44993750
that makes sense from reading the code.  If anyone has a chance to spot
check this would that would be great.  It is not clear in a few other
clients also since we have said this unused but there is a mapping for it
and want to make sure we have it 100% correct moving forward.

I noticed also we are using
https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/ReplicaManager.scala#L182
but I think that is a bug that should be error code = 8
for BrokerNotAvailableCode at least according to what we have documented on
the wiki.

Thanks!

/*******************************************
 Joe Stein
 Founder, Principal Consultant
 Big Data Open Source Security LLC
 http://www.stealth.ly
 Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
********************************************/

Re: ReplicaNotAvailableCode

[Jun Rao <ju...@gmail.com>]

Thanks Joe, for fixing the missing error code. I reworded the description
in the wiki a bit. I think the error code use ReplicaManager is correct.

Jun




On Mon, Aug 11, 2014 at 1:12 PM, Joe Stein <jo...@stealth.ly> wrote:

> An issue/question just came up with a client library
> https://github.com/Shopify/sarama/pull/142#issuecomment-51707301 the wiki
> for the wire protocol had error code = 9 as unused I just updated it
> for ReplicaNotAvailableCode and put a description
>
> https://cwiki.apache.org/confluence/pages/diffpages.action?pageId=30743483&originalId=44993750
> that makes sense from reading the code.  If anyone has a chance to spot
> check this would that would be great.  It is not clear in a few other
> clients also since we have said this unused but there is a mapping for it
> and want to make sure we have it 100% correct moving forward.
>
> I noticed also we are using
>
> https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/ReplicaManager.scala#L182
> but I think that is a bug that should be error code = 8
> for BrokerNotAvailableCode at least according to what we have documented on
> the wiki.
>
> Thanks!
>
> /*******************************************
>  Joe Stein
>  Founder, Principal Consultant
>  Big Data Open Source Security LLC
>  http://www.stealth.ly
>  Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> ********************************************/
>