You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ris-tlp (via GitHub)" <gi...@apache.org> on 2025/10/25 01:28:56 UTC
[PR] Fab provider SQLA1 -> SQLA2: Fix models/dagbundle MyPy error [airflow]
ris-tlp opened a new pull request, #57217:
URL: https://github.com/apache/airflow/pull/57217
Fixes MyPy error shown below in `airflow-core/src/models/dagbundle.py`.
Part of #56735.
<img width="1170" height="144" alt="image" src="https://github.com/user-attachments/assets/b2d6079c-9435-433e-96c7-6f3eab70759a" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fab provider SQLA1 -> SQLA2: Fix models/dagbundle MyPy error [airflow]
Posted by "KoviAnusha (via GitHub)" <gi...@apache.org>.
KoviAnusha commented on code in PR #57217:
URL: https://github.com/apache/airflow/pull/57217#discussion_r2462604906
##########
airflow-core/src/airflow/models/dagbundle.py:
##########
@@ -69,6 +69,9 @@ def _unsign_url(self) -> str | None:
from airflow.configuration import conf
+ if not self.signed_url_template:
+ return None
+
Review Comment:
Adding this early return for None makes the type check happy and keeps _unsign_url() safe from unnecessary calls. Good work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fab provider SQLA1 -> SQLA2: Fix models/dagbundle MyPy error [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #57217:
URL: https://github.com/apache/airflow/pull/57217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org