[kudu-CR] KUDU-3452 Create tablet without enough healthy tservers

["Yuqi Du (Code Review)" <ge...@cloudera.org>]

Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )

Change subject: KUDU-3452 Create tablet without enough healthy tservers
......................................................................


Patch Set 11:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19571/4//COMMIT_MSG@10
PS4, Line 10: ugh tablet ser
> tservers
Done


http://gerrit.cloudera.org:8080/#/c/19571/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/19571/2/src/kudu/tools/kudu-tool-test.cc@9213
PS2, Line 9213: 
> tserver_unresponsive_timeout_ms is a server flag. CLI can not get the value
At this test case, it's deterministic because you have set it at L9184.
(  // Set heart beat timeout 1s.  opts.extra_master_flags.emplace_back("--tserver_unresponsive_timeout_ms=1000"); ),

For reference only.


http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9189
PS11, Line 9189: INSTANTIATE_TEST_SUITE_P
nit: add an empty line


http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9283
PS11, Line 9283:     ASSERT_TRUE(s.IsTimedOut()) << s.ToString();
The status is deterministic, I think it should be not timeout. What do you think?


http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9387
PS11, Line 9387: table
nit: All tables


http://gerrit.cloudera.org:8080/#/c/19571/11/src/kudu/tools/kudu-tool-test.cc@9396
PS11, Line 9396: ASSERT_EQ
I don't understand  the number 4.
I have found 3 kFiveReplicaTableName, kOneReplicaTableName, kNotEnoughReplicasTableName , will be ok.

But this table 'kOverRegistedTSTableName', 2 creating tables, fail reasons:

1: replication_factor > number of (available)tservers.

2: At this moment. there are not enough available tservers(only 2 alive, this table need at least 3), so I think tablets of this table should  be gced, it should not pending to wait tservers recover.

What do you think?



-- 
To view, visit http://gerrit.cloudera.org:8080/19571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6
Gerrit-Change-Number: 19571
Gerrit-PatchSet: 11
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 04 May 2023 10:11:36 +0000
Gerrit-HasComments: Yes