You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by "ffang (via GitHub)" <gi...@apache.org> on 2025/09/16 20:19:38 UTC
[PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
ffang opened a new pull request, #2607:
URL: https://github.com/apache/cxf/pull/2607
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang commented on code in PR #2607:
URL: https://github.com/apache/cxf/pull/2607#discussion_r2353890359
##########
integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/ssl/CxfClientSslProperties.java:
##########
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.spring.boot.autoconfigure.ssl;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+/**
+ * Client-side SSL integration properties for CXF when Spring Boot SslBundles are present.
+ * bundles are applied once when an HTTPConduit is configured.
+ */
+@ConfigurationProperties("cxf.client.ssl")
+public class CxfClientSslProperties {
+ private boolean enabled;
+ //Name of the Spring SSL bundle to use for outbound CXF clients. */
+ private String bundle = "cxf-client";
Review Comment:
Hi @reta ,
Yes, the idea is to have default one for clients, so that in most cases, the List<CxfClientSslBundle> isn't necessary or could be too much configuration, so
```
cxf:
client:
ssl:
enabled: true
bundle: cxf-client
```
is sufficient.
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #2607:
URL: https://github.com/apache/cxf/pull/2607#discussion_r2353863783
##########
integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/ssl/CxfClientSslProperties.java:
##########
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.spring.boot.autoconfigure.ssl;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+/**
+ * Client-side SSL integration properties for CXF when Spring Boot SslBundles are present.
+ * bundles are applied once when an HTTPConduit is configured.
+ */
+@ConfigurationProperties("cxf.client.ssl")
+public class CxfClientSslProperties {
+ private boolean enabled;
+ //Name of the Spring SSL bundle to use for outbound CXF clients. */
+ private String bundle = "cxf-client";
+ // Convenience flag for tests
+ private Boolean disableCnCheck = Boolean.FALSE;
+ private List<CxfClientSslBundle> cxfClientSslBundles = new ArrayList<>();
+
+ public static class CxfClientSslBundle {
+ private String name;
+ private String address;
+ private String bundle;
+ private String protocol;
+ private List<String> cipherSuites;
+ private Boolean disableCnCheck = Boolean.FALSE;
+
+ public String getAddress() {
+ return address;
+ }
+
+ public void setAddress(String address) {
+ this.address = address;
+ }
+
+ public String getBundle() {
+ return bundle;
+ }
+
+ public void setBundle(String bundle) {
+ this.bundle = bundle;
+ }
+
+ public String getProtocol() {
+ return protocol;
+ }
+
+ public void setProtocol(String protocol) {
+ this.protocol = protocol;
+ }
+
+ public List<String> getCipherSuites() {
+ return cipherSuites;
+ }
+
+ public void setCipherSuites(List<String> cipherSuites) {
+ this.cipherSuites = cipherSuites;
+ }
+
+ public Boolean getDisableCnCheck() {
+ return disableCnCheck;
+ }
+
+ public void setDisableCnCheck(Boolean disableCnCheck) {
+ this.disableCnCheck = disableCnCheck;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public void setName(String name) {
+ this.name = name;
+ }
+ }
+
+ public boolean isEnabled() {
+ return enabled;
+ }
+
+ public void setEnabled(boolean enabled) {
+ this.enabled = enabled;
+ }
+
+ public String getBundle() {
+ return bundle;
+ }
+
+ public void setBundle(String bundle) {
+ this.bundle = bundle;
+ }
+
+ public Boolean getDisableCnCheck() {
+ return disableCnCheck;
+ }
+
+ public void setDisableCnCheck(Boolean disableCnCheck) {
+ this.disableCnCheck = disableCnCheck;
+ }
+
+ public List<CxfClientSslBundle> getCxfClientSslBundle() {
Review Comment:
Very minor:
```suggestion
public List<CxfClientSslBundle> getCxfClientSslBundles() {
```
##########
integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/ssl/CxfClientSslProperties.java:
##########
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.spring.boot.autoconfigure.ssl;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+/**
+ * Client-side SSL integration properties for CXF when Spring Boot SslBundles are present.
+ * bundles are applied once when an HTTPConduit is configured.
+ */
+@ConfigurationProperties("cxf.client.ssl")
+public class CxfClientSslProperties {
+ private boolean enabled;
+ //Name of the Spring SSL bundle to use for outbound CXF clients. */
+ private String bundle = "cxf-client";
+ // Convenience flag for tests
+ private Boolean disableCnCheck = Boolean.FALSE;
+ private List<CxfClientSslBundle> cxfClientSslBundles = new ArrayList<>();
+
+ public static class CxfClientSslBundle {
+ private String name;
+ private String address;
+ private String bundle;
+ private String protocol;
+ private List<String> cipherSuites;
+ private Boolean disableCnCheck = Boolean.FALSE;
+
+ public String getAddress() {
+ return address;
+ }
+
+ public void setAddress(String address) {
+ this.address = address;
+ }
+
+ public String getBundle() {
+ return bundle;
+ }
+
+ public void setBundle(String bundle) {
+ this.bundle = bundle;
+ }
+
+ public String getProtocol() {
+ return protocol;
+ }
+
+ public void setProtocol(String protocol) {
+ this.protocol = protocol;
+ }
+
+ public List<String> getCipherSuites() {
+ return cipherSuites;
+ }
+
+ public void setCipherSuites(List<String> cipherSuites) {
+ this.cipherSuites = cipherSuites;
+ }
+
+ public Boolean getDisableCnCheck() {
+ return disableCnCheck;
+ }
+
+ public void setDisableCnCheck(Boolean disableCnCheck) {
+ this.disableCnCheck = disableCnCheck;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public void setName(String name) {
+ this.name = name;
+ }
+ }
+
+ public boolean isEnabled() {
+ return enabled;
+ }
+
+ public void setEnabled(boolean enabled) {
+ this.enabled = enabled;
+ }
+
+ public String getBundle() {
+ return bundle;
+ }
+
+ public void setBundle(String bundle) {
+ this.bundle = bundle;
+ }
+
+ public Boolean getDisableCnCheck() {
+ return disableCnCheck;
+ }
+
+ public void setDisableCnCheck(Boolean disableCnCheck) {
+ this.disableCnCheck = disableCnCheck;
+ }
+
+ public List<CxfClientSslBundle> getCxfClientSslBundle() {
+ return cxfClientSslBundles;
+ }
+
+ public void setCxfClientSslBundle(List<CxfClientSslBundle> clientSslBundles) {
Review Comment:
```suggestion
public void setCxfClientSslBundles(List<CxfClientSslBundle> clientSslBundles) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang commented on PR #2607:
URL: https://github.com/apache/cxf/pull/2607#issuecomment-3303020457
Thanks @reta !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #2607:
URL: https://github.com/apache/cxf/pull/2607#discussion_r2353769642
##########
integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/ssl/CxfClientSslProperties.java:
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.spring.boot.autoconfigure.ssl;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+/**
+ * Client-side SSL integration properties for CXF when Spring Boot SslBundles are present.
+ * bundles are applied once when an HTTPConduit is configured.
+ */
+@ConfigurationProperties("cxf.client.ssl")
+public class CxfClientSslProperties {
Review Comment:
Not particularly better option, but may be we could mirror SSL bundle with list of named `CxfClientSslBundle` instances? Fe:
```
@ConfigurationProperties("cxf.client.ssl")
public class CxfClientSslProperties {
List<CxfClientSslBundle> bundles;
private boolean enabled;
class CxfClientSslBundle {
private String name; <--- same as the name in `HTTPConduitConfigurer`
private Boolean disableCnCheck = Boolean.FALSE;
private String bundle;
private String protocol;
private List<String> cipherSuites;
}
}
```
To me the combination of props + rules does make it confusing somewhat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #2607:
URL: https://github.com/apache/cxf/pull/2607#discussion_r2353900187
##########
integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/ssl/CxfClientSslProperties.java:
##########
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.spring.boot.autoconfigure.ssl;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+/**
+ * Client-side SSL integration properties for CXF when Spring Boot SslBundles are present.
+ * bundles are applied once when an HTTPConduit is configured.
+ */
+@ConfigurationProperties("cxf.client.ssl")
+public class CxfClientSslProperties {
+ private boolean enabled;
+ //Name of the Spring SSL bundle to use for outbound CXF clients. */
+ private String bundle = "cxf-client";
Review Comment:
In your opinion, do you think it is better to call it `defaultBundle` (disambiguate with `CxfClientSslBundle::bundle`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang merged PR #2607:
URL: https://github.com/apache/cxf/pull/2607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #2607:
URL: https://github.com/apache/cxf/pull/2607#discussion_r2353866004
##########
integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/ssl/CxfClientSslProperties.java:
##########
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.spring.boot.autoconfigure.ssl;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+/**
+ * Client-side SSL integration properties for CXF when Spring Boot SslBundles are present.
+ * bundles are applied once when an HTTPConduit is configured.
+ */
+@ConfigurationProperties("cxf.client.ssl")
+public class CxfClientSslProperties {
+ private boolean enabled;
+ //Name of the Spring SSL bundle to use for outbound CXF clients. */
+ private String bundle = "cxf-client";
Review Comment:
Do we need this property or `CxfClientSslBundle::bundle` is sufficient? or the idea is to have a default one for clients?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on PR #2607:
URL: https://github.com/apache/cxf/pull/2607#issuecomment-3300822017
LGTM, thanks a lot @ffang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #2607:
URL: https://github.com/apache/cxf/pull/2607#discussion_r2353959423
##########
integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/ssl/CxfClientSslProperties.java:
##########
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.spring.boot.autoconfigure.ssl;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+/**
+ * Client-side SSL integration properties for CXF when Spring Boot SslBundles are present.
+ * bundles are applied once when an HTTPConduit is configured.
+ */
+@ConfigurationProperties("cxf.client.ssl")
+public class CxfClientSslProperties {
+ private boolean enabled;
+ //Name of the Spring SSL bundle to use for outbound CXF clients. */
+ private String defaultBundle = "cxf-client";
+ // Convenience flag for tests
+ private Boolean disableCnCheck = Boolean.FALSE;
+ private List<CxfClientSslBundle> cxfClientSslBundles = new ArrayList<>();
+
+ public static class CxfClientSslBundle {
+ private String name;
+ private String address;
+ private String bundle;
+ private String protocol;
+ private List<String> cipherSuites;
+ private Boolean disableCnCheck = Boolean.FALSE;
+
+ public String getAddress() {
+ return address;
+ }
+
+ public void setAddress(String address) {
+ this.address = address;
+ }
+
+ public String getBundle() {
Review Comment:
Also getters / setters probably:
```suggestion
public String getDefaultBundle() {
```
##########
integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/ssl/CxfClientSslProperties.java:
##########
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.spring.boot.autoconfigure.ssl;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+/**
+ * Client-side SSL integration properties for CXF when Spring Boot SslBundles are present.
+ * bundles are applied once when an HTTPConduit is configured.
+ */
+@ConfigurationProperties("cxf.client.ssl")
+public class CxfClientSslProperties {
+ private boolean enabled;
+ //Name of the Spring SSL bundle to use for outbound CXF clients. */
+ private String defaultBundle = "cxf-client";
+ // Convenience flag for tests
+ private Boolean disableCnCheck = Boolean.FALSE;
+ private List<CxfClientSslBundle> cxfClientSslBundles = new ArrayList<>();
+
+ public static class CxfClientSslBundle {
+ private String name;
+ private String address;
+ private String bundle;
+ private String protocol;
+ private List<String> cipherSuites;
+ private Boolean disableCnCheck = Boolean.FALSE;
+
+ public String getAddress() {
+ return address;
+ }
+
+ public void setAddress(String address) {
+ this.address = address;
+ }
+
+ public String getBundle() {
+ return bundle;
+ }
+
+ public void setBundle(String bundle) {
Review Comment:
```suggestion
public void setDefaultBundle(String bundle) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CXF-9159]CXF client to support spring boot SSL bundles [cxf]
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang commented on code in PR #2607:
URL: https://github.com/apache/cxf/pull/2607#discussion_r2353957922
##########
integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/ssl/CxfClientSslProperties.java:
##########
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.spring.boot.autoconfigure.ssl;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.springframework.boot.context.properties.ConfigurationProperties;
+
+/**
+ * Client-side SSL integration properties for CXF when Spring Boot SslBundles are present.
+ * bundles are applied once when an HTTPConduit is configured.
+ */
+@ConfigurationProperties("cxf.client.ssl")
+public class CxfClientSslProperties {
+ private boolean enabled;
+ //Name of the Spring SSL bundle to use for outbound CXF clients. */
+ private String bundle = "cxf-client";
Review Comment:
Yes, revised accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org