You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2019/03/21 00:59:16 UTC
Review Request 70260: RANGER-2367:Hive show grants when Ranger is
authorizer should show permission details from Ranger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70260/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2367
https://issues.apache.org/jira/browse/RANGER-2367
Repository: ranger
Description
-------
RANGER-2367:Hive show grants when Ranger is authorizer should show permission details from Ranger
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java c00f072
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceACLs.java adee37e
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 0f3bee5
hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java af60479
ranger-examples/conditions-enrichers/src/main/java/org/apache/ranger/plugin/contextenricher/RangerSampleProjectProvider.java df6da7c
Diff: https://reviews.apache.org/r/70260/diff/1/
Testing
-------
Testing done in Local VM.
Thanks,
Ramesh Mani
Re: Review Request 70260: RANGER-2367:Hive show grants when Ranger is
authorizer should show permission details from Ranger
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70260/#review214065
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On March 21, 2019, 12:59 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70260/
> -----------------------------------------------------------
>
> (Updated March 21, 2019, 12:59 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2367
> https://issues.apache.org/jira/browse/RANGER-2367
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2367:Hive show grants when Ranger is authorizer should show permission details from Ranger
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java c00f072
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceACLs.java adee37e
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 0f3bee5
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java af60479
> ranger-examples/conditions-enrichers/src/main/java/org/apache/ranger/plugin/contextenricher/RangerSampleProjectProvider.java df6da7c
>
>
> Diff: https://reviews.apache.org/r/70260/diff/1/
>
>
> Testing
> -------
>
> Testing done in Local VM.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 70260: RANGER-2367:Hive show grants when Ranger is
authorizer should show permission details from Ranger
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70260/#review214020
-----------------------------------------------------------
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
Line 1478 (original), 1485 (patched)
<https://reviews.apache.org/r/70260/#comment300186>
Formatting...
- Abhay Kulkarni
On March 21, 2019, 12:59 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70260/
> -----------------------------------------------------------
>
> (Updated March 21, 2019, 12:59 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2367
> https://issues.apache.org/jira/browse/RANGER-2367
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2367:Hive show grants when Ranger is authorizer should show permission details from Ranger
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java c00f072
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceACLs.java adee37e
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 0f3bee5
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java af60479
> ranger-examples/conditions-enrichers/src/main/java/org/apache/ranger/plugin/contextenricher/RangerSampleProjectProvider.java df6da7c
>
>
> Diff: https://reviews.apache.org/r/70260/diff/1/
>
>
> Testing
> -------
>
> Testing done in Local VM.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 70260: RANGER-2367:Hive show grants when Ranger is
authorizer should show permission details from Ranger
Posted by Ramesh Mani <rm...@hortonworks.com>.
> On March 27, 2019, 2:19 a.m., Qiang Zhang wrote:
> > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
> > Lines 1641 (patched)
> > <https://reviews.apache.org/r/70260/diff/1/?file=2133091#file2133091line1695>
> >
> > Lines 1641-1652 are better to extract method
I shall fix this in subsequent patch
- Ramesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70260/#review214070
-----------------------------------------------------------
On March 21, 2019, 12:59 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70260/
> -----------------------------------------------------------
>
> (Updated March 21, 2019, 12:59 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2367
> https://issues.apache.org/jira/browse/RANGER-2367
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2367:Hive show grants when Ranger is authorizer should show permission details from Ranger
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java c00f072
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceACLs.java adee37e
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 0f3bee5
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java af60479
> ranger-examples/conditions-enrichers/src/main/java/org/apache/ranger/plugin/contextenricher/RangerSampleProjectProvider.java df6da7c
>
>
> Diff: https://reviews.apache.org/r/70260/diff/1/
>
>
> Testing
> -------
>
> Testing done in Local VM.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 70260: RANGER-2367:Hive show grants when Ranger is
authorizer should show permission details from Ranger
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70260/#review214070
-----------------------------------------------------------
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
Lines 1641 (patched)
<https://reviews.apache.org/r/70260/#comment300243>
Lines 1641-1652 are better to extract method
- Qiang Zhang
On 三月 21, 2019, 12:59 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70260/
> -----------------------------------------------------------
>
> (Updated 三月 21, 2019, 12:59 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2367
> https://issues.apache.org/jira/browse/RANGER-2367
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2367:Hive show grants when Ranger is authorizer should show permission details from Ranger
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java c00f072
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceACLs.java adee37e
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 0f3bee5
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java af60479
> ranger-examples/conditions-enrichers/src/main/java/org/apache/ranger/plugin/contextenricher/RangerSampleProjectProvider.java df6da7c
>
>
> Diff: https://reviews.apache.org/r/70260/diff/1/
>
>
> Testing
> -------
>
> Testing done in Local VM.
>
>
> Thanks,
>
> Ramesh Mani
>
>