You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2025/12/08 12:23:10 UTC
[PR] SLING-13025 Evaluate "resource" as fallback to "sling.auth.redirect" [sling-org-apache-sling-auth-core]
kwin opened a new pull request, #22:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/22
In most cases the "resource" is anyhow set (to correctly deal with failed authentications to determine the login path) and is used as redirect target for successful authentications as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13025 Evaluate "resource" as fallback to "sling.auth.redirect" [sling-org-apache-sling-auth-core]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #22:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13025 Evaluate "resource" as fallback to "sling.auth.redirect" [sling-org-apache-sling-auth-core]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #22:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/22#discussion_r2598454317
##########
src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java:
##########
@@ -1462,6 +1462,7 @@ private void redirectAfterLogout(final HttpServletRequest request, final HttpSer
// find the redirect target from the resource attribute or parameter
// falling back to the request context path (or /) if not set or invalid
+ // TODO: apply mapping, but no resource resolver at hand, use service resource resolver?
Review Comment:
Is this something we should tackle in this context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13025 Evaluate "resource" as fallback to "sling.auth.redirect" [sling-org-apache-sling-auth-core]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #22:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/22#issuecomment-3626731255
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-core&pullRequest=22) **Quality Gate failed**
Failed conditions
 [33.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=22&metric=new_coverage&view=list) (required ≥ 80%)
 [10.9% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=22&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-core&pullRequest=22)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13025 Evaluate "resource" as fallback to "sling.auth.redirect" [sling-org-apache-sling-auth-core]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #22:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/22#issuecomment-3642252429
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-core&pullRequest=22) **Quality Gate failed**
Failed conditions
 [33.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=22&metric=new_coverage&view=list) (required ≥ 80%)
 [10.9% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=22&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-core&pullRequest=22)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13025 Evaluate "resource" as fallback to "sling.auth.redirect" [sling-org-apache-sling-auth-core]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #22:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/22#issuecomment-3626675088
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-core&pullRequest=22) **Quality Gate failed**
Failed conditions
 [35.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=22&metric=new_coverage&view=list) (required ≥ 80%)
 [11.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=22&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-auth-core&pullRequest=22)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org