You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Etienne Chauchot (Jira)" <ji...@apache.org> on 2022/10/12 10:53:00 UTC

[jira] [Commented] (FLINK-29605) Create a bounded version of SourceTestSuiteBase#testSourceMetrics

    [ https://issues.apache.org/jira/browse/FLINK-29605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616353#comment-17616353 ] 

Etienne Chauchot commented on FLINK-29605:
------------------------------------------

What I propose is to allow the implemeter to pass the boundedness in its ITCase to run the corresponding version of this test.

> Create a bounded version of SourceTestSuiteBase#testSourceMetrics
> -----------------------------------------------------------------
>
>                 Key: FLINK-29605
>                 URL: https://issues.apache.org/jira/browse/FLINK-29605
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Etienne Chauchot
>            Priority: Major
>
> _SourceTestSuiteBase#testSourceMetrics_ is targeted to unbounded sources. Metrics tests still make sense with bounded sources.  For the bounded case, _SourceTestSuiteBase#testSourceMetrics,_ [killing the job|https://github.com/apache/flink/blob/4934bd69052f2a69e8021d337373f4480c802359/flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java#L469]  is not needed and in some cases (fast job) the kill is executed when the job is already in the finished state leading to a confusing exception. This is why for the bounded case the killJob should be removed. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)