You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/28 21:03:32 UTC
[GitHub] [hbase] bharathv opened a new pull request #1102: HBASE-23752: Fix
remaining test failures from nightly runs
bharathv opened a new pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102
TestFromClientSideWithCoprocessor: Initialization bug causing parameterized
runs to fail.
TestCustomSaslAuthenticationProvider: Test config had to be fixed because
it was written pre-master registry implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1102: HBASE-23752: Fix
remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#issuecomment-580967858
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 10s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 59s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | compile | 1m 16s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | checkstyle | 1m 35s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | shadedjars | 6m 22s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 49s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +0 :ok: | spotbugs | 5m 48s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 5m 45s | HBASE-18095/client-locate-meta-no-zookeeper passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 30s | the patch passed |
| +1 :green_heart: | compile | 1m 25s | the patch passed |
| +1 :green_heart: | javac | 1m 25s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 22s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 6m 6s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 22m 54s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 44s | the patch passed |
| +1 :green_heart: | findbugs | 5m 31s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 190m 14s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
| | | 271m 48s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1102 |
| JIRA Issue | HBASE-23752 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 414657ea15a7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1102/out/precommit/personality/provided.sh |
| git revision | HBASE-18095/client-locate-meta-no-zookeeper / 60cb4f35ae |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/5/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/5/testReport/ |
| Max. process+thread count | 4696 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/5/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r373525226
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -527,12 +568,22 @@ public void testNegativeAuthentication() throws Exception {
user1.addToken(createPasswordToken("user1", "definitely not the password", clusterId));
user1.doAs(new PrivilegedExceptionAction<Void>() {
@Override public Void run() throws Exception {
+ // Depending on the registry in use, the following code can throw exceptions at different
+ // places. Master registry fails at the createConnection() step because the RPC to the
+ // master fails with sasl auth. With ZK registry, connection creation succeeds (since there
+ // is no RPC to HBase services involved) but the subsequent get() fails. The root cause
+ // should still be a SaslException in both the cases.
try (Connection conn = ConnectionFactory.createConnection(clientConf);
Table t = conn.getTable(tableName)) {
t.get(new Get(Bytes.toBytes("r1")));
fail("Should not successfully authenticate with HBase");
- return null;
+ } catch (MasterRegistryFetchException mfe) {
+ Throwable cause = mfe.getCause();
+ assertTrue(cause.getMessage(), cause.getMessage().contains("SaslException"));
+ } catch (RetriesExhaustedException re) {
+ assertTrue(re.getMessage(), re.getMessage().contains("SaslException"));
}
+ return null;
Review comment:
There's a `throws Exception` on `run()` so we need a `fail()` "close" to the `return null`. Right now, an exception other than MasterRegistryFetchException and RetriesExhaustedException would not cause a unit test failure.
You can just move the `fail` from inside the try, next to this `return null` and change the message to be something like `Expected an authentication failure`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r373618989
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -527,12 +568,22 @@ public void testNegativeAuthentication() throws Exception {
user1.addToken(createPasswordToken("user1", "definitely not the password", clusterId));
user1.doAs(new PrivilegedExceptionAction<Void>() {
@Override public Void run() throws Exception {
+ // Depending on the registry in use, the following code can throw exceptions at different
+ // places. Master registry fails at the createConnection() step because the RPC to the
+ // master fails with sasl auth. With ZK registry, connection creation succeeds (since there
+ // is no RPC to HBase services involved) but the subsequent get() fails. The root cause
+ // should still be a SaslException in both the cases.
try (Connection conn = ConnectionFactory.createConnection(clientConf);
Table t = conn.getTable(tableName)) {
t.get(new Get(Bytes.toBytes("r1")));
fail("Should not successfully authenticate with HBase");
- return null;
+ } catch (MasterRegistryFetchException mfe) {
+ Throwable cause = mfe.getCause();
+ assertTrue(cause.getMessage(), cause.getMessage().contains("SaslException"));
+ } catch (RetriesExhaustedException re) {
+ assertTrue(re.getMessage(), re.getMessage().contains("SaslException"));
}
+ return null;
Review comment:
You're right that the thrown, uncaught exception will ultimately cause the test to fail, but you're removing the nice exception stating the reason the test failed :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r372515033
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -431,9 +431,13 @@ public static void setupCluster() throws Exception {
UTIL.getDataTestDir("keytab").toUri().getPath());
final MiniKdc kdc = UTIL.setupMiniKdc(KEYTAB_FILE);
- // Switch back to NIO for now.
+ // Switch to blocking RPC impl.
CONF.set(RpcClientFactory.CUSTOM_RPC_CLIENT_IMPL_CONF_KEY, BlockingRpcClient.class.getName());
CONF.set(RpcServerFactory.CUSTOM_RPC_SERVER_IMPL_CONF_KEY, SimpleRpcServer.class.getName());
+ // Set the connection registry to ZKConnectionRegistry since hedging is not supported on
+ // blocking rpc clients.
Review comment:
1. Why is this test forced onto the blocking rpc client? Can/Should it be parameterized over both implementations?
1. can we not use the `MasterRegistry` with hedged rpcs disabled? It appears this configuration is supported by the `MasterRegistry` constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r373658126
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -527,12 +568,22 @@ public void testNegativeAuthentication() throws Exception {
user1.addToken(createPasswordToken("user1", "definitely not the password", clusterId));
user1.doAs(new PrivilegedExceptionAction<Void>() {
@Override public Void run() throws Exception {
+ // Depending on the registry in use, the following code can throw exceptions at different
+ // places. Master registry fails at the createConnection() step because the RPC to the
+ // master fails with sasl auth. With ZK registry, connection creation succeeds (since there
+ // is no RPC to HBase services involved) but the subsequent get() fails. The root cause
+ // should still be a SaslException in both the cases.
try (Connection conn = ConnectionFactory.createConnection(clientConf);
Table t = conn.getTable(tableName)) {
t.get(new Get(Bytes.toBytes("r1")));
fail("Should not successfully authenticate with HBase");
- return null;
+ } catch (MasterRegistryFetchException mfe) {
+ Throwable cause = mfe.getCause();
+ assertTrue(cause.getMessage(), cause.getMessage().contains("SaslException"));
+ } catch (RetriesExhaustedException re) {
+ assertTrue(re.getMessage(), re.getMessage().contains("SaslException"));
}
+ return null;
Review comment:
Okay, added back a nice exception. The issue with moving fail() towards the end is that we need sprinkle the "return null" statements in the catch blocks. This is more readable IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r374249918
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -443,9 +464,23 @@ public static void setupCluster() throws Exception {
InMemoryServerProvider.class.getName());
CONF.set(SaslClientAuthenticationProviders.SELECTOR_KEY,
InMemoryProviderSelector.class.getName());
+ createBaseCluster(UTIL, KEYTAB_FILE, kdc);
+ }
- CLUSTER = createCluster(UTIL, KEYTAB_FILE, kdc);
+ @Before
+ public void setUpBeforeTest() throws Exception {
+ CONF.unset(HConstants.CLIENT_CONNECTION_REGISTRY_IMPL_CONF_KEY);
+ CONF.set(RpcClientFactory.CUSTOM_RPC_CLIENT_IMPL_CONF_KEY, rpcClientImpl);
+ CONF.set(RpcServerFactory.CUSTOM_RPC_SERVER_IMPL_CONF_KEY, rpcServerImpl);
+ if (rpcClientImpl.equals(BlockingRpcClient.class.getName())) {
+ // Set the connection registry to ZKConnectionRegistry since hedging is not supported on
+ // blocking rpc clients.
+ CONF.set(HConstants.CLIENT_CONNECTION_REGISTRY_IMPL_CONF_KEY,
+ HConstants.ZK_CONNECTION_REGISTRY_CLASS);
+ }
+ CLUSTER = new LocalHBaseCluster(CONF, 1);
Review comment:
Sucks that we have to spin the new cluster for every test method. It is not possible to do this cluster configuration and initialization in the constructor instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1102: HBASE-23752: Fix
remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#issuecomment-580656726
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 28s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | compile | 0m 56s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | checkstyle | 1m 10s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | shadedjars | 4m 42s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +0 :ok: | spotbugs | 4m 13s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 10s | HBASE-18095/client-locate-meta-no-zookeeper passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 57s | the patch passed |
| +1 :green_heart: | compile | 0m 57s | the patch passed |
| +1 :green_heart: | javac | 0m 57s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 5s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 42s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 54s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed |
| +1 :green_heart: | findbugs | 4m 10s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 173m 33s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. |
| | | 230m 34s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.quotas.TestClusterScopeQuotaThrottle |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1102 |
| JIRA Issue | HBASE-23752 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 99ca5f58dde6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1102/out/precommit/personality/provided.sh |
| git revision | HBASE-18095/client-locate-meta-no-zookeeper / 60cb4f35ae |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/4/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/4/testReport/ |
| Max. process+thread count | 5661 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/4/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on issue #1102: HBASE-23752: Fix
remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
bharathv commented on issue #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#issuecomment-579882636
> After these changes, are there still more flakes that could use the same treatment? (Looking at the precommit unit results.)
@apurtell I think the remaining flakes are general flakes and not bugs. After doing some investigation I think the general cause of flakiness is this : https://issues.apache.org/jira/browse/HBASE-23764 . Making that switch locally makes the tests much faster for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r374257313
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -443,9 +464,23 @@ public static void setupCluster() throws Exception {
InMemoryServerProvider.class.getName());
CONF.set(SaslClientAuthenticationProviders.SELECTOR_KEY,
InMemoryProviderSelector.class.getName());
+ createBaseCluster(UTIL, KEYTAB_FILE, kdc);
+ }
- CLUSTER = createCluster(UTIL, KEYTAB_FILE, kdc);
+ @Before
+ public void setUpBeforeTest() throws Exception {
+ CONF.unset(HConstants.CLIENT_CONNECTION_REGISTRY_IMPL_CONF_KEY);
+ CONF.set(RpcClientFactory.CUSTOM_RPC_CLIENT_IMPL_CONF_KEY, rpcClientImpl);
+ CONF.set(RpcServerFactory.CUSTOM_RPC_SERVER_IMPL_CONF_KEY, rpcServerImpl);
+ if (rpcClientImpl.equals(BlockingRpcClient.class.getName())) {
+ // Set the connection registry to ZKConnectionRegistry since hedging is not supported on
+ // blocking rpc clients.
+ CONF.set(HConstants.CLIENT_CONNECTION_REGISTRY_IMPL_CONF_KEY,
+ HConstants.ZK_CONNECTION_REGISTRY_CLASS);
+ }
+ CLUSTER = new LocalHBaseCluster(CONF, 1);
Review comment:
Okay, makes sense. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r374255049
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -443,9 +464,23 @@ public static void setupCluster() throws Exception {
InMemoryServerProvider.class.getName());
CONF.set(SaslClientAuthenticationProviders.SELECTOR_KEY,
InMemoryProviderSelector.class.getName());
+ createBaseCluster(UTIL, KEYTAB_FILE, kdc);
+ }
- CLUSTER = createCluster(UTIL, KEYTAB_FILE, kdc);
+ @Before
+ public void setUpBeforeTest() throws Exception {
+ CONF.unset(HConstants.CLIENT_CONNECTION_REGISTRY_IMPL_CONF_KEY);
+ CONF.set(RpcClientFactory.CUSTOM_RPC_CLIENT_IMPL_CONF_KEY, rpcClientImpl);
+ CONF.set(RpcServerFactory.CUSTOM_RPC_SERVER_IMPL_CONF_KEY, rpcServerImpl);
+ if (rpcClientImpl.equals(BlockingRpcClient.class.getName())) {
+ // Set the connection registry to ZKConnectionRegistry since hedging is not supported on
+ // blocking rpc clients.
+ CONF.set(HConstants.CLIENT_CONNECTION_REGISTRY_IMPL_CONF_KEY,
+ HConstants.ZK_CONNECTION_REGISTRY_CLASS);
+ }
+ CLUSTER = new LocalHBaseCluster(CONF, 1);
Review comment:
Ya, unfortunately its the same problem, JUnit calls the ctor for every parameterized test invocation. So we'd need to have some logic like
if (same instance of params) don't restart
We did that in TestFromClientSide but the code becomes ugly. Lucikly, there are fewer tests, so this works out ok here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r373065101
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -431,9 +431,13 @@ public static void setupCluster() throws Exception {
UTIL.getDataTestDir("keytab").toUri().getPath());
final MiniKdc kdc = UTIL.setupMiniKdc(KEYTAB_FILE);
- // Switch back to NIO for now.
+ // Switch to blocking RPC impl.
CONF.set(RpcClientFactory.CUSTOM_RPC_CLIENT_IMPL_CONF_KEY, BlockingRpcClient.class.getName());
CONF.set(RpcServerFactory.CUSTOM_RPC_SERVER_IMPL_CONF_KEY, SimpleRpcServer.class.getName());
+ // Set the connection registry to ZKConnectionRegistry since hedging is not supported on
+ // blocking rpc clients.
Review comment:
> Why is this test forced onto the blocking rpc client? Can/Should it be parameterized over both implementations?
Oversight on my part! Like Nick says -- we should use both via parameterization. There's another test which does this .... TestSecureIPC!
Do you want to add that parameterization as a part of this PR? Or I can open up an issue and fix this test (as the negligent author ;)). LMK!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r373665356
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -527,12 +568,22 @@ public void testNegativeAuthentication() throws Exception {
user1.addToken(createPasswordToken("user1", "definitely not the password", clusterId));
user1.doAs(new PrivilegedExceptionAction<Void>() {
@Override public Void run() throws Exception {
+ // Depending on the registry in use, the following code can throw exceptions at different
+ // places. Master registry fails at the createConnection() step because the RPC to the
+ // master fails with sasl auth. With ZK registry, connection creation succeeds (since there
+ // is no RPC to HBase services involved) but the subsequent get() fails. The root cause
+ // should still be a SaslException in both the cases.
try (Connection conn = ConnectionFactory.createConnection(clientConf);
Table t = conn.getTable(tableName)) {
t.get(new Get(Bytes.toBytes("r1")));
fail("Should not successfully authenticate with HBase");
- return null;
+ } catch (MasterRegistryFetchException mfe) {
+ Throwable cause = mfe.getCause();
+ assertTrue(cause.getMessage(), cause.getMessage().contains("SaslException"));
+ } catch (RetriesExhaustedException re) {
+ assertTrue(re.getMessage(), re.getMessage().contains("SaslException"));
}
+ return null;
Review comment:
Yup, what you did is fine. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1102: HBASE-23752: Fix
remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#issuecomment-579677841
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 19s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 2s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | compile | 1m 0s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | checkstyle | 1m 14s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | shadedjars | 5m 11s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +0 :ok: | spotbugs | 4m 54s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 51s | HBASE-18095/client-locate-meta-no-zookeeper passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 38s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 13s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 11s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 40s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
| +1 :green_heart: | findbugs | 4m 53s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 177m 8s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. |
| | | 241m 23s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1102 |
| JIRA Issue | HBASE-23752 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux deb4d1bc8ec6 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1102/out/precommit/personality/provided.sh |
| git revision | HBASE-18095/client-locate-meta-no-zookeeper / a5b63d97b6 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/3/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/3/testReport/ |
| Max. process+thread count | 4897 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1102: HBASE-23752: Fix
remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#issuecomment-579600378
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 15s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 4s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | compile | 0m 59s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | checkstyle | 1m 14s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | shadedjars | 5m 13s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +0 :ok: | spotbugs | 4m 51s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 49s | HBASE-18095/client-locate-meta-no-zookeeper passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 43s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 12s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 7s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 54s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
| +1 :green_heart: | findbugs | 5m 3s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 171m 24s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. |
| | | 236m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1102 |
| JIRA Issue | HBASE-23752 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2fb08e78648f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1102/out/precommit/personality/provided.sh |
| git revision | HBASE-18095/client-locate-meta-no-zookeeper / acf2a45cb0 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/2/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/2/testReport/ |
| Max. process+thread count | 4849 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r372530454
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -431,9 +431,13 @@ public static void setupCluster() throws Exception {
UTIL.getDataTestDir("keytab").toUri().getPath());
final MiniKdc kdc = UTIL.setupMiniKdc(KEYTAB_FILE);
- // Switch back to NIO for now.
+ // Switch to blocking RPC impl.
CONF.set(RpcClientFactory.CUSTOM_RPC_CLIENT_IMPL_CONF_KEY, BlockingRpcClient.class.getName());
CONF.set(RpcServerFactory.CUSTOM_RPC_SERVER_IMPL_CONF_KEY, SimpleRpcServer.class.getName());
+ // Set the connection registry to ZKConnectionRegistry since hedging is not supported on
+ // blocking rpc clients.
Review comment:
> Why is this test forced onto the blocking rpc client? Can/Should it be parameterized over both implementations?
Not totally sure why it should only be a blocking rpc client (and a SimpleRpcServer impl). @joshelser Any idea? I see that you are the author of this test.
> can we not use the MasterRegistry with hedged rpcs disabled? It appears this configuration is supported by the MasterRegistry constructor.
We can. But my comment above has nothing to do with whether hedging is enabled/disabled. HedgingRpcChannel is a non-blocking channel implementation. Using a non-blocking-channel wrapped over a blocking-rpc-connection defeats the purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r373321931
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -431,9 +431,13 @@ public static void setupCluster() throws Exception {
UTIL.getDataTestDir("keytab").toUri().getPath());
final MiniKdc kdc = UTIL.setupMiniKdc(KEYTAB_FILE);
- // Switch back to NIO for now.
+ // Switch to blocking RPC impl.
CONF.set(RpcClientFactory.CUSTOM_RPC_CLIENT_IMPL_CONF_KEY, BlockingRpcClient.class.getName());
CONF.set(RpcServerFactory.CUSTOM_RPC_SERVER_IMPL_CONF_KEY, SimpleRpcServer.class.getName());
+ // Set the connection registry to ZKConnectionRegistry since hedging is not supported on
+ // blocking rpc clients.
Review comment:
No worries, I parameterized it. Thanks for the quick response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #1102: HBASE-23752: Fix
remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
ndimiduk merged pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1102:
HBASE-23752: Fix remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r373581995
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
##########
@@ -527,12 +568,22 @@ public void testNegativeAuthentication() throws Exception {
user1.addToken(createPasswordToken("user1", "definitely not the password", clusterId));
user1.doAs(new PrivilegedExceptionAction<Void>() {
@Override public Void run() throws Exception {
+ // Depending on the registry in use, the following code can throw exceptions at different
+ // places. Master registry fails at the createConnection() step because the RPC to the
+ // master fails with sasl auth. With ZK registry, connection creation succeeds (since there
+ // is no RPC to HBase services involved) but the subsequent get() fails. The root cause
+ // should still be a SaslException in both the cases.
try (Connection conn = ConnectionFactory.createConnection(clientConf);
Table t = conn.getTable(tableName)) {
t.get(new Get(Bytes.toBytes("r1")));
fail("Should not successfully authenticate with HBase");
- return null;
+ } catch (MasterRegistryFetchException mfe) {
+ Throwable cause = mfe.getCause();
+ assertTrue(cause.getMessage(), cause.getMessage().contains("SaslException"));
+ } catch (RetriesExhaustedException re) {
+ assertTrue(re.getMessage(), re.getMessage().contains("SaslException"));
}
+ return null;
Review comment:
> Right now, an exception other than MasterRegistryFetchException and RetriesExhaustedException would not cause a unit test failure.
Not sure I follow you, the exception should be propagated back to the test (since it is not caught) and it should fail, no? I tried the following it works (meaning the IAE is thrown by the unit test runner). Did I miss something?
```
user1.doAs(new PrivilegedExceptionAction<Void>() {
@Override public Void run() throws Exception {
// Depending on the registry in use, the following code can throw exceptions at different
// places. Master registry fails at the createConnection() step because the RPC to the
// master fails with sasl auth. With ZK registry, connection creation succeeds (since there
// is no RPC to HBase services involved) but the subsequent get() fails. The root cause
// should still be a SaslException in both the cases.
try (Connection conn = ConnectionFactory.createConnection(clientConf);
Table t = conn.getTable(tableName)) {
if (true) {
throw new IllegalArgumentException("test");
}
t.get(new Get(Bytes.toBytes("r1")));
java.lang.IllegalArgumentException: test
at org.apache.hadoop.hbase.security.provider.TestCustomSaslAuthenticationProvider$3.run(TestCustomSaslAuthenticationProvider.java:579)
at org.apache.hadoop.hbase.security.provider.TestCustomSaslAuthenticationProvider$3.run(TestCustomSaslAuthenticationProvider.java:569)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1102: HBASE-23752: Fix
remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#issuecomment-579552336
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
||| _ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 51s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | compile | 1m 16s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | checkstyle | 1m 31s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +1 :green_heart: | shadedjars | 6m 33s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 48s | HBASE-18095/client-locate-meta-no-zookeeper passed |
| +0 :ok: | spotbugs | 5m 36s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 5m 33s | HBASE-18095/client-locate-meta-no-zookeeper passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 24s | the patch passed |
| +1 :green_heart: | compile | 1m 22s | the patch passed |
| +1 :green_heart: | javac | 1m 22s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 26s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 6m 46s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 25m 12s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
| +1 :green_heart: | findbugs | 5m 24s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 176m 40s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. |
| | | 261m 16s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1102 |
| JIRA Issue | HBASE-23752 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 126028041dfa 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1102/out/precommit/personality/provided.sh |
| git revision | HBASE-18095/client-locate-meta-no-zookeeper / 21be409963 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/1/testReport/ |
| Max. process+thread count | 4937 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1102/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell commented on issue #1102: HBASE-23752: Fix
remaining test failures from nightly runs
Posted by GitBox <gi...@apache.org>.
apurtell commented on issue #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#issuecomment-579879485
After these changes, are there still more flakes that could use the same treatment? (Looking at the precommit unit results.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services