You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Jing Zhao (JIRA)" <ji...@apache.org> on 2014/01/14 08:03:52 UTC

[jira] [Commented] (HDFS-5752) Add a new DFSAdminCommand for rolling upgrade

    [ https://issues.apache.org/jira/browse/HDFS-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870460#comment-13870460 ] 

Jing Zhao commented on HDFS-5752:
---------------------------------

The patch looks good to me. Some minors:
# We may want to add more javadoc for ClientProtocol#rollingUpgrade
# Since ClientProtocol#rollingUpgrade returns long, shall we also let DistributedFileSystem#rollingUpgrade and DFSClient#rollingUpgrade return long?

+1 after addressing the comments.

> Add a new DFSAdminCommand for rolling upgrade
> ---------------------------------------------
>
>                 Key: HDFS-5752
>                 URL: https://issues.apache.org/jira/browse/HDFS-5752
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h5752_20140112.patch, h5752_20140114.patch
>
>
> We need to add a new DFSAdmin to start, finalize and query rolling upgrade.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)