You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/12/07 03:13:15 UTC

Review Request 64399: Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64399/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Repository: mesos


Description
-------

Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.


Diffs
-----

  include/mesos/resource_provider/resource_provider.hpp 45cda4251af6c437841609fbf611108b2955422e 
  include/mesos/resource_provider/resource_provider.proto 2ce71f4c3e97e89c226966c347c2817e2bab9c1b 
  include/mesos/v1/resource_provider/resource_provider.hpp 3fc45c94df2678b2c3a778eb3b7acbbd0d0446b7 
  include/mesos/v1/resource_provider/resource_provider.proto 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb 
  src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe 
  src/resource_provider/validation.cpp 984d5934953c1f0a16a400fb2a2cc2cc5eb2ed89 
  src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01 


Diff: https://reviews.apache.org/r/64399/diff/1/


Testing
-------

make check


Thanks,

Greg Mann


Re: Review Request 64399: Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64399/
-----------------------------------------------------------

(Updated Dec. 8, 2017, 7:10 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Repository: mesos


Description
-------

Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.


Diffs (updated)
-----

  include/mesos/resource_provider/resource_provider.hpp 45cda4251af6c437841609fbf611108b2955422e 
  include/mesos/resource_provider/resource_provider.proto d2b9c7902ab9ba81f240ae599ea8d9b28a413f9a 
  include/mesos/v1/resource_provider/resource_provider.hpp 3fc45c94df2678b2c3a778eb3b7acbbd0d0446b7 
  include/mesos/v1/resource_provider/resource_provider.proto 0c23e915f32dabfca0c6a420e303514117e6a6eb 
  src/resource_provider/manager.cpp e75d5289c51c326a31f22ea7db1941fe9310774c 
  src/resource_provider/storage/provider.cpp a0294219f342eb9b934993394718d64ac8033223 
  src/resource_provider/validation.cpp 984d5934953c1f0a16a400fb2a2cc2cc5eb2ed89 
  src/tests/mesos.hpp 76fbd902042abe95ab4f7431b30989990e48817c 
  src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01 


Diff: https://reviews.apache.org/r/64399/diff/3/

Changes: https://reviews.apache.org/r/64399/diff/2-3/


Testing
-------

make check


Thanks,

Greg Mann


Re: Review Request 64399: Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64399/
-----------------------------------------------------------

(Updated Dec. 7, 2017, 10:21 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Changes
-------

Rebase, and updated new occurrences of the call.


Repository: mesos


Description
-------

Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.


Diffs (updated)
-----

  include/mesos/resource_provider/resource_provider.hpp 45cda4251af6c437841609fbf611108b2955422e 
  include/mesos/resource_provider/resource_provider.proto d2b9c7902ab9ba81f240ae599ea8d9b28a413f9a 
  include/mesos/v1/resource_provider/resource_provider.hpp 3fc45c94df2678b2c3a778eb3b7acbbd0d0446b7 
  include/mesos/v1/resource_provider/resource_provider.proto 0c23e915f32dabfca0c6a420e303514117e6a6eb 
  src/resource_provider/manager.cpp 2aee46e22958cc3a3ac87ceb5a77cb8f94c73054 
  src/resource_provider/storage/provider.cpp a2794acda7187f78ed4246158da71cc26a7892c8 
  src/resource_provider/validation.cpp 984d5934953c1f0a16a400fb2a2cc2cc5eb2ed89 
  src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01 


Diff: https://reviews.apache.org/r/64399/diff/2/

Changes: https://reviews.apache.org/r/64399/diff/1-2/


Testing
-------

make check


Thanks,

Greg Mann


Re: Review Request 64399: Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64399/#review193089
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 7, 2017, 3:13 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64399/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2017, 3:13 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed a resource provider call to UPDATE_PUBLISH_RESOURCES_STATUS.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.hpp 45cda4251af6c437841609fbf611108b2955422e 
>   include/mesos/resource_provider/resource_provider.proto 2ce71f4c3e97e89c226966c347c2817e2bab9c1b 
>   include/mesos/v1/resource_provider/resource_provider.hpp 3fc45c94df2678b2c3a778eb3b7acbbd0d0446b7 
>   include/mesos/v1/resource_provider/resource_provider.proto 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb 
>   src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe 
>   src/resource_provider/validation.cpp 984d5934953c1f0a16a400fb2a2cc2cc5eb2ed89 
>   src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01 
> 
> 
> Diff: https://reviews.apache.org/r/64399/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>