You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/04/19 19:25:27 UTC

[GitHub] [druid] techdocsmith commented on a diff in pull request #12071: docs: remove maxRowsPerSegment where appropriate

techdocsmith commented on code in PR #12071:
URL: https://github.com/apache/druid/pull/12071#discussion_r853412464


##########
docs/design/coordinator.md:
##########
@@ -114,7 +114,7 @@ need compaction or not.
 A set of segments need compaction if all conditions below are satisfied.
 
 1) Total size of segments in the time chunk is smaller than or equal to the configured `inputSegmentSizeBytes`.
-2) Segments have never been compacted yet or compaction spec has been updated since the last compaction, especially `maxRowsPerSegment`, `maxTotalRows`, and `indexSpec`.
+2) Segments have never been compacted yet or compaction spec has been updated since the last compaction, especially `maxTotalRows`, and `indexSpec`.

Review Comment:
   ```suggestion
   2) Segments have never been compacted yet or compaction spec has been updated since the last compaction:  `maxTotalRows` or`indexSpec`.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org