You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/08/30 20:59:48 UTC
[GitHub] [solr-operator] thelabdude commented on a change in pull request #312: Configuration options to support an additional client TLS cert in addition to the server certificate
thelabdude commented on a change in pull request #312:
URL: https://github.com/apache/solr-operator/pull/312#discussion_r698804396
##########
File path: controllers/controller_utils_test.go
##########
@@ -184,46 +182,6 @@ func expectDeployment(t *testing.T, g *gomega.GomegaWithT, requests chan reconci
return deploy
}
-func verifyUserSuppliedTLSConfig(t *testing.T, tls *solr.SolrTLSOptions, expectedKeystorePasswordSecretName string, expectedKeystorePasswordSecretKey string, expectedTlsSecretName string, needsPkcs12InitContainer bool) {
Review comment:
Moved these TLS specific test helper functions to `solrcloud_controller_tls_test` as they are only used by TLS tests and now seem out of place in this file
##########
File path: controllers/controller_utils_test.go
##########
@@ -279,170 +237,6 @@ func expectInitContainer(t *testing.T, podTemplate *corev1.PodTemplateSpec, expN
return expInitContainer
}
-// Ensures all the TLS env vars, volume mounts and initContainers are setup for the PodTemplateSpec
Review comment:
Moved these TLS specific test helper functions to `solrcloud_controller_tls_test` as they are only used by TLS tests and now seem out of place in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org