You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/05 15:08:48 UTC
[GitHub] [incubator-doris] morrySnow opened a new pull request, #9392: [feature] Nereids code base
morrySnow opened a new pull request, #9392:
URL: https://github.com/apache/incubator-doris/pull/9392
# Proposed changes
Issue Number: #6483
## Problem Summary:
Nereids(new optimizer) code base
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (Yes)
5. Are there any changes that cannot be rolled back: (No)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #9392: [feature] Nereids code base
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #9392:
URL: https://github.com/apache/incubator-doris/pull/9392#discussion_r866471301
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/VectorizedUtil.java:
##########
@@ -37,7 +37,10 @@ public static boolean isVectorized() {
if (stmtExecutor == null) {
return connectContext.getSessionVariable().enableVectorizedEngine();
}
- Analyzer analyzer = stmtExecutor.getAnalyzer();
+ Analyzer analyzer = null;
Review Comment:
revert it~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9392: [feature] Nereids code base
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9392:
URL: https://github.com/apache/incubator-doris/pull/9392#issuecomment-1119215441
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9392: [feature] Nereids code base
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9392:
URL: https://github.com/apache/incubator-doris/pull/9392#issuecomment-1119215453
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #9392: [feature] Nereids code base
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on PR #9392:
URL: https://github.com/apache/incubator-doris/pull/9392#issuecomment-1119230090
Notice the antlr license in dist/NOTICE-dist.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9392: [feature] Nereids code base
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #9392:
URL: https://github.com/apache/incubator-doris/pull/9392#discussion_r866464080
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/VectorizedUtil.java:
##########
@@ -37,7 +37,10 @@ public static boolean isVectorized() {
if (stmtExecutor == null) {
return connectContext.getSessionVariable().enableVectorizedEngine();
}
- Analyzer analyzer = stmtExecutor.getAnalyzer();
+ Analyzer analyzer = null;
Review Comment:
Your pr should not bring this change, is it caused by no rebase master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 merged pull request #9392: [feature] Nereids code base
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged PR #9392:
URL: https://github.com/apache/incubator-doris/pull/9392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on pull request #9392: [feature] Nereids code base
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #9392:
URL: https://github.com/apache/incubator-doris/pull/9392#issuecomment-1119237861
> Notice the antlr license in dist/NOTICE-dist.txt
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org