You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/02/27 00:18:45 UTC

[GitHub] [beam] bumblebee-coming commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners.

bumblebee-coming commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners.
URL: https://github.com/apache/beam/pull/10951#discussion_r384845501
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/combiners_test.py
 ##########
 @@ -470,6 +470,9 @@ def test_combining_with_accumulation_mode_and_fanout(self):
       ts.add_elements([i])
     ts.advance_watermark_to_infinity()
 
+    def is_early_firing(element, num_partitions):
+      return 0 if element < 15 else 1
 
 Review comment:
   PaneInfo is not supported yet in Python.
   https://issues.apache.org/jira/browse/BEAM-3759

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services