You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2017/08/11 17:39:10 UTC

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7658

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................

IMPALA-5477: Fix minidump-2-core tool in breakpad

The recent PPC port broke the minidump-2-core tool in the toolchain.
This change removes a seemingly erroneous #ifdef to fix the tool on
non-PPC systems.

To test this, I built a toolchain locally and made sure that cores
created from minidumps with the tool can be opened by GDB.

I didn't test the change on PPC.

Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
---
M source/breakpad/breakpad-1b704857f1e78a864e6942e613457e55f1aecb60-patches/0002-Build-breakpad-ffe3e47-on-ppc64le.patch
1 file changed, 0 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/58/7658/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7658/2/buildall.sh
File buildall.sh:

Line 273: BREAKPAD_VERSION=1b704857f1e78a864e6942e613457e55f1aecb60-p3 $SOURCE_DIR/source/breakpad/build.sh
Can you move the old version into BUILD_HISTORICAL for consistency with elsewhere? 

It's not super-important but good to be consistent.


-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................


Patch Set 2:

> Yes, please do create a separate patch. We have done the same thing
 > in Thrift where we've reverted an existing patch, but bumped the
 > patch number on each count.

Done.

-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged.

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................


IMPALA-5477: Fix minidump-2-core tool in breakpad

The recent PPC port broke the minidump-2-core tool in the toolchain.
This change undoes a seemingly erroneous #ifdef to fix the tool on
non-PPC systems.

To test this, I built a toolchain locally and made sure that cores
created from minidumps with the tool can be opened by GDB.

I didn't test the change on PPC.

Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
---
M buildall.sh
A source/breakpad/breakpad-1b704857f1e78a864e6942e613457e55f1aecb60-patches/0003-fix-md2core.patch
2 files changed, 20 insertions(+), 1 deletion(-)

Approvals:
  Lars Volker: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................


Patch Set 3: Code-Review+2

Rebased, carrying Tim's +2.

-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................


Patch Set 1:

Yes, please do create a separate patch. We have done the same thing in Thrift where we've reverted an existing patch, but bumped the patch number on each count.

-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#2).

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................

IMPALA-5477: Fix minidump-2-core tool in breakpad

The recent PPC port broke the minidump-2-core tool in the toolchain.
This change undoes a seemingly erroneous #ifdef to fix the tool on
non-PPC systems.

To test this, I built a toolchain locally and made sure that cores
created from minidumps with the tool can be opened by GDB.

I didn't test the change on PPC.

Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
---
M buildall.sh
A source/breakpad/breakpad-1b704857f1e78a864e6942e613457e55f1aecb60-patches/0003-fix-md2core.patch
2 files changed, 20 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/58/7658/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................


Patch Set 1:

> Do you think should add this as a separate patch, rather than
 > updating an existing one? That way there's no confusion about which
 > version we have installed.

I don't feel strongly about either. Currently not a lot of people use the tool and with the next update of the upstream version it'll be resolved for everyone. If you think it's worth the effort, I can prepare a subsequent patch and we can squash them on the next upstream version bump.

-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................


Patch Set 1:

Do you think should add this as a separate patch, rather than updating an existing one? That way there's no confusion about which version we have installed.

-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No