[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3872: [Bug] Fix bug that BE crash when doing Insert Operation

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #3872:
URL: https://github.com/apache/incubator-doris/pull/3872#discussion_r441249725



##########
File path: be/src/runtime/plan_fragment_executor.cpp
##########
@@ -323,7 +323,12 @@ Status PlanFragmentExecutor::open_internal() {
     {
         SCOPED_TIMER(profile()->total_time_counter());
         collect_query_statistics();
-        Status status = _sink->close(runtime_state(), _status);
+        Status status;
+        {
+            boost::lock_guard<boost::mutex> l(_status_lock);

Review comment:
       If you have time. I think we would better use `std::lock_guard` and `std:: mutex ` instead of `boost::lock_guard` and `boost::mutex`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org