You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2014/05/08 02:50:17 UTC

Review Request 21185: stacks api returning invalid href's after endpoint renaming

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21185/
-----------------------------------------------------------

Review request for Ambari and Sid Wagle.


Bugs: AMBARI-5708
    https://issues.apache.org/jira/browse/AMBARI-5708


Repository: ambari


Description
-------

The stacks api is returning the endpoint names stackServices, serviceComponents and operatingSystems in href's even though they were changed for the /stacks endpoint.
{
  "href" : "http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.1/stackServices/ZOOKEEPER",
  "StackServices" : {
    "service_name" : "ZOOKEEPER",
    "stack_name" : "HDP",
    "stack_version" : "2.1"
  }
}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinition.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinitionTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/21185/diff/


Testing
-------

Functional Testing:
- created cluster and tested UI functionality
- tested both /stacks and /stacks2 api responses

Unit Tests:
- Added new unit test
- All unit tests pass

Results :

Tests run: 1598, Failures: 0, Errors: 0, Skipped: 9
...
Total run:548
Total errors:0
Total failures:0
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:18.617s
[INFO] Finished at: Wed May 07 20:32:16 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

John Speidel

Re: Review Request 21185: stacks api returning invalid href's after endpoint renaming

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21185/#review42449
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On May 8, 2014, 12:50 a.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21185/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 12:50 a.m.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Bugs: AMBARI-5708
>     https://issues.apache.org/jira/browse/AMBARI-5708
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The stacks api is returning the endpoint names stackServices, serviceComponents and operatingSystems in href's even though they were changed for the /stacks endpoint.
> {
>   "href" : "http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.1/stackServices/ZOOKEEPER",
>   "StackServices" : {
>     "service_name" : "ZOOKEEPER",
>     "stack_name" : "HDP",
>     "stack_version" : "2.1"
>   }
> }
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinition.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinitionTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21185/diff/
> 
> 
> Testing
> -------
> 
> Functional Testing:
> - created cluster and tested UI functionality
> - tested both /stacks and /stacks2 api responses
> 
> Unit Tests:
> - Added new unit test
> - All unit tests pass
> 
> Results :
> 
> Tests run: 1598, Failures: 0, Errors: 0, Skipped: 9
> ...
> Total run:548
> Total errors:0
> Total failures:0
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:18.617s
> [INFO] Finished at: Wed May 07 20:32:16 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> John Speidel
> 
>

Re: Review Request 21185: stacks api returning invalid href's after endpoint renaming

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21185/
-----------------------------------------------------------

(Updated May 8, 2014, 1:17 a.m.)


Review request for Ambari and Sid Wagle.


Bugs: AMBARI-5708
    https://issues.apache.org/jira/browse/AMBARI-5708


Repository: ambari


Description
-------

The stacks api is returning the endpoint names stackServices, serviceComponents and operatingSystems in href's even though they were changed for the /stacks endpoint.
{
  "href" : "http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.1/stackServices/ZOOKEEPER",
  "StackServices" : {
    "service_name" : "ZOOKEEPER",
    "stack_name" : "HDP",
    "stack_version" : "2.1"
  }
}


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/OperatingSystemResourceDefinition.java b9c85ec 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackConfigurationResourceDefinition.java 222ff42 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackDependencyResourceDefinition.java 19ac584 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceComponentResourceDefinition.java 00620e9 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceResourceDefinition.java 0c8f4f9 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 97f1908 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinitionTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/21185/diff/


Testing
-------

Functional Testing:
- created cluster and tested UI functionality
- tested both /stacks and /stacks2 api responses

Unit Tests:
- Added new unit test
- All unit tests pass

Results :

Tests run: 1598, Failures: 0, Errors: 0, Skipped: 9
...
Total run:548
Total errors:0
Total failures:0
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:18.617s
[INFO] Finished at: Wed May 07 20:32:16 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

John Speidel