You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "shuwenwei (via GitHub)" <gi...@apache.org> on 2023/08/21 11:08:40 UTC
[GitHub] [iotdb] shuwenwei opened a new pull request, #10919: Fix point priority reader array index out of bound exception
shuwenwei opened a new pull request, #10919:
URL: https://github.com/apache/iotdb/pull/10919
## Description
Add hasNextTimeValuePair() check before call nextTimeValuePair() when creating a new instance of PointElement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #10919: Fix point priority reader array index out of bound exception
Posted by "xingtanzjr (via GitHub)" <gi...@apache.org>.
xingtanzjr commented on code in PR #10919:
URL: https://github.com/apache/iotdb/pull/10919#discussion_r1302451749
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/fast/SeriesCompactionExecutor.java:
##########
@@ -276,7 +277,9 @@ private void compactWithNonOverlapPage(PageElement pageElement)
} else {
// unsealed page is not large enough or page.endTime > file.endTime, then deserialze it
summary.pageNoneOverlapButDeserialize += 1;
Review Comment:
Should this summary be considered inside the following `if` ?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/fast/SeriesCompactionExecutor.java:
##########
@@ -244,8 +244,9 @@ private void compactPages()
|| firstPageElement.needForceDecoding) {
// has overlap or modified pages, then deserialize it
summary.pageOverlapOrModified += 1;
Review Comment:
Should this summary be considered inside the following `if` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr merged pull request #10919: Fix point priority reader array index out of bound exception
Posted by "xingtanzjr (via GitHub)" <gi...@apache.org>.
xingtanzjr merged PR #10919:
URL: https://github.com/apache/iotdb/pull/10919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #10919: Fix point priority reader array index out of bound exception
Posted by "xingtanzjr (via GitHub)" <gi...@apache.org>.
xingtanzjr commented on code in PR #10919:
URL: https://github.com/apache/iotdb/pull/10919#discussion_r1302451749
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/fast/SeriesCompactionExecutor.java:
##########
@@ -276,7 +277,9 @@ private void compactWithNonOverlapPage(PageElement pageElement)
} else {
// unsealed page is not large enough or page.endTime > file.endTime, then deserialze it
summary.pageNoneOverlapButDeserialize += 1;
Review Comment:
Should this summary be considered inside the following `if` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org