You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "englefly (via GitHub)" <gi...@apache.org> on 2025/12/24 07:02:39 UTC
[PR] eager agg from tpc_preview3 1224 [doris]
englefly opened a new pull request, #59326:
URL: https://github.com/apache/doris/pull/59326
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](eager aggregation) push down aggregation through join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59326:
URL: https://github.com/apache/doris/pull/59326#issuecomment-3748278086
<details>
<summary>ClickBench: <b>Total hot run time: 26.59 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 871dd0072d950a27bbefc73d458ef4b8de7ba124, data reload: false
query1 0.05 0.05 0.05
query2 0.09 0.04 0.04
query3 0.26 0.09 0.08
query4 1.60 0.11 0.11
query5 0.28 0.25 0.25
query6 1.15 0.67 0.66
query7 0.03 0.02 0.03
query8 0.06 0.04 0.04
query9 0.56 0.50 0.48
query10 0.55 0.56 0.55
query11 0.15 0.10 0.10
query12 0.15 0.11 0.11
query13 0.61 0.59 0.58
query14 0.96 0.94 0.94
query15 0.78 0.77 0.79
query16 0.39 0.39 0.39
query17 1.07 1.04 1.05
query18 0.22 0.22 0.21
query19 1.84 1.83 1.75
query20 0.04 0.01 0.01
query21 15.45 0.29 0.14
query22 4.84 0.05 0.05
query23 15.72 0.29 0.10
query24 1.76 0.58 0.18
query25 0.07 0.06 0.06
query26 0.13 0.14 0.13
query27 0.10 0.04 0.07
query28 3.86 1.06 0.88
query29 12.55 3.99 3.17
query30 0.28 0.13 0.12
query31 2.88 0.65 0.39
query32 3.24 0.54 0.45
query33 3.06 2.98 3.00
query34 16.03 5.07 4.41
query35 4.41 4.47 4.49
query36 0.64 0.49 0.49
query37 0.11 0.06 0.06
query38 0.07 0.04 0.04
query39 0.05 0.03 0.03
query40 0.18 0.14 0.14
query41 0.09 0.03 0.02
query42 0.04 0.03 0.03
query43 0.04 0.03 0.04
Total cold run time: 96.44 s
Total hot run time: 26.59 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](eager aggregation) push down aggregation through join [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #59326:
URL: https://github.com/apache/doris/pull/59326#issuecomment-3748074328
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](eager aggregation) push down aggregation through join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59326:
URL: https://github.com/apache/doris/pull/59326#issuecomment-3748264638
<details>
<summary>TPC-DS: <b>Total hot run time: 140533 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 871dd0072d950a27bbefc73d458ef4b8de7ba124, data reload: false
query5 4428 594 470 470
query6 329 235 212 212
query7 4220 460 260 260
query8 318 232 227 227
query9 8666 2839 2851 2839
query10 514 356 332 332
query11 6915 5076 4862 4862
query12 173 117 116 116
query13 1281 475 365 365
query14 5570 2911 2708 2708
query14_1 2629 2597 2596 2596
query15 202 187 171 171
query16 985 471 451 451
query17 856 638 551 551
query18 2412 423 315 315
query19 221 222 196 196
query20 118 113 111 111
query21 216 148 130 130
query22 3871 4019 3809 3809
query23 14496 14302 14168 14168
query23_1 14199 14150 14088 14088
query24 7138 1517 1157 1157
query24_1 1151 1160 1132 1132
query25 520 439 390 390
query26 1239 262 144 144
query27 2793 422 257 257
query28 4656 2136 2134 2134
query29 814 556 403 403
query30 304 236 207 207
query31 1305 1216 1161 1161
query32 77 75 73 73
query33 527 345 284 284
query34 881 890 525 525
query35 719 767 674 674
query36 887 949 826 826
query37 136 106 91 91
query38 1475 1466 1436 1436
query39 777 735 736 735
query39_1 695 705 700 700
query40 220 135 116 116
query41 64 62 62 62
query42 272 261 261 261
query43 227 240 214 214
query44 1324 741 731 731
query45 188 181 176 176
query46 816 935 567 567
query47 1360 1457 1336 1336
query48 297 310 223 223
query49 597 424 350 350
query50 639 278 203 203
query51 3803 3902 3777 3777
query52 273 288 272 272
query53 278 317 262 262
query54 283 260 253 253
query55 88 81 76 76
query56 314 311 294 294
query57 1035 1027 963 963
query58 288 263 267 263
query59 1303 1460 1326 1326
query60 343 336 331 331
query61 182 206 181 181
query62 387 361 347 347
query63 290 265 264 264
query64 5297 1384 1086 1086
query65 3802 3705 3638 3638
query66 1475 435 339 339
query67 15338 15081 15140 15081
query68 3345 1013 716 716
query69 501 373 345 345
query70 1014 962 885 885
query71 342 315 297 297
query72 5989 2592 3525 2592
query73 790 721 300 300
query74 8803 8734 8527 8527
query75 2797 2813 2441 2441
query76 3256 1090 647 647
query77 535 368 296 296
query78 9887 9819 9093 9093
query79 1953 819 573 573
query80 1578 596 483 483
query81 550 274 233 233
query82 446 134 114 114
query83 355 253 242 242
query84 299 113 96 96
query85 906 518 457 457
query86 474 274 287 274
query87 1687 1713 1626 1626
query88 3006 2147 2114 2114
query89 405 344 326 326
query90 1820 165 153 153
query91 162 164 135 135
query92 76 79 69 69
query93 1375 907 535 535
query94 648 319 300 300
query95 595 388 311 311
query96 567 493 199 199
query97 2355 2358 2323 2323
query98 233 205 198 198
query99 567 575 529 529
Total cold run time: 231318 ms
Total hot run time: 140533 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](eager aggregation) push down aggregation through join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59326:
URL: https://github.com/apache/doris/pull/59326#issuecomment-3742989409
<details>
<summary>TPC-DS: <b>Total hot run time: 141568 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9857be4ba67626a59ae5b3e5fed19dce32c0b476, data reload: false
query5 4439 608 490 490
query6 325 241 212 212
query7 4210 448 246 246
query8 325 247 227 227
query9 8740 2847 2839 2839
query10 526 375 355 355
query11 6988 5202 4945 4945
query12 175 121 115 115
query13 1249 473 399 399
query14 5501 2989 2753 2753
query14_1 2699 2671 2634 2634
query15 193 197 182 182
query16 994 484 484 484
query17 907 717 590 590
query18 2447 469 322 322
query19 215 222 200 200
query20 133 121 121 121
query21 208 134 118 118
query22 3744 3969 3738 3738
query23 14589 14372 14054 14054
query23_1 14220 14169 14008 14008
query24 7162 1528 1150 1150
query24_1 1166 1143 1176 1143
query25 535 452 402 402
query26 1250 273 154 154
query27 2765 434 260 260
query28 4652 2141 2143 2141
query29 806 521 423 423
query30 309 238 212 212
query31 1349 1248 1160 1160
query32 90 78 79 78
query33 556 358 316 316
query34 913 877 551 551
query35 762 784 675 675
query36 897 901 846 846
query37 140 110 90 90
query38 1483 1475 1448 1448
query39 792 778 730 730
query39_1 711 713 701 701
query40 222 142 125 125
query41 74 72 66 66
query42 277 273 266 266
query43 251 248 222 222
query44 1310 750 758 750
query45 190 192 191 191
query46 860 949 575 575
query47 1392 1466 1277 1277
query48 294 316 230 230
query49 632 442 364 364
query50 616 275 210 210
query51 3803 3824 3774 3774
query52 280 282 276 276
query53 293 329 275 275
query54 309 301 287 287
query55 93 91 81 81
query56 337 330 333 330
query57 1014 1019 870 870
query58 285 275 269 269
query59 1302 1423 1258 1258
query60 353 352 347 347
query61 194 188 199 188
query62 380 371 315 315
query63 307 274 269 269
query64 5234 1393 1060 1060
query65 3824 3774 3747 3747
query66 1465 434 330 330
query67 15270 15116 14756 14756
query68 7918 957 702 702
query69 516 358 344 344
query70 1038 953 976 953
query71 357 312 297 297
query72 6091 3388 3485 3388
query73 757 721 307 307
query74 8831 8780 8529 8529
query75 2829 2781 2483 2483
query76 3349 1064 639 639
query77 530 372 316 316
query78 9705 9789 9144 9144
query79 1347 890 575 575
query80 611 558 501 501
query81 528 277 241 241
query82 216 142 109 109
query83 280 268 243 243
query84 307 118 92 92
query85 887 522 472 472
query86 399 310 321 310
query87 1661 1717 1620 1620
query88 2987 2151 2117 2117
query89 384 355 330 330
query90 2240 182 165 165
query91 174 169 144 144
query92 86 75 68 68
query93 1594 886 527 527
query94 598 322 314 314
query95 598 339 320 320
query96 550 480 205 205
query97 2354 2375 2284 2284
query98 217 200 205 200
query99 602 571 527 527
Total cold run time: 234792 ms
Total hot run time: 141568 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](eager aggregation) push down aggregation through join [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59326:
URL: https://github.com/apache/doris/pull/59326#issuecomment-3748360619
# FE UT Coverage Report
Increment line coverage ` 54.62% (254/465)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59326_871dd0072d950a27bbefc73d458ef4b8de7ba124/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59326_871dd0072d950a27bbefc73d458ef4b8de7ba124/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](eager aggregation) push down aggregation through join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59326:
URL: https://github.com/apache/doris/pull/59326#issuecomment-3748234525
<details>
<summary>TPC-H: <b>Total hot run time: 36706 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 871dd0072d950a27bbefc73d458ef4b8de7ba124, data reload: false
------ Round 1 ----------------------------------
q1 17663 4173 4025 4025
q2 2045 345 231 231
q3 10373 1269 695 695
q4 10206 791 307 307
q5 7523 2031 1829 1829
q6 188 165 134 134
q7 930 754 659 659
q8 9265 1381 1221 1221
q9 4929 4662 4647 4647
q10 6421 2142 1769 1769
q11 546 323 289 289
q12 5384 5443 5453 5443
q13 17858 3577 3068 3068
q14 433 425 418 418
q15 600 520 508 508
q16 678 686 647 647
q17 647 802 497 497
q18 6608 6486 6295 6295
q19 1098 970 577 577
q20 371 350 239 239
q21 2987 2377 2245 2245
q22 1047 1005 963 963
Total cold run time: 107800 ms
Total hot run time: 36706 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4117 4046 4059 4046
q2 323 401 330 330
q3 4005 4558 4116 4116
q4 1310 1893 1586 1586
q5 4758 4458 4448 4448
q6 216 171 124 124
q7 1962 1914 1856 1856
q8 2600 2333 2415 2333
q9 7275 7288 7276 7276
q10 4252 4501 4125 4125
q11 1072 960 997 960
q12 5918 5877 5660 5660
q13 6337 3794 3079 3079
q14 406 412 390 390
q15 529 491 489 489
q16 608 655 615 615
q17 2734 1587 1231 1231
q18 7411 7264 7035 7035
q19 823 752 767 752
q20 1868 1928 1816 1816
q21 4599 4268 4052 4052
q22 1098 1055 948 948
Total cold run time: 64221 ms
Total hot run time: 57267 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](eager aggregation) push down aggregation through join [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly closed pull request #59326: [feat](eager aggregation) push down aggregation through join
URL: https://github.com/apache/doris/pull/59326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](eager aggregation) push down aggregation through join [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #59326:
URL: https://github.com/apache/doris/pull/59326#issuecomment-3742765057
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](eager aggregation) push down aggregation through join [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59326:
URL: https://github.com/apache/doris/pull/59326#issuecomment-3743222917
# FE UT Coverage Report
Increment line coverage ` 54.62% (254/465)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59326_9857be4ba67626a59ae5b3e5fed19dce32c0b476/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59326_9857be4ba67626a59ae5b3e5fed19dce32c0b476/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](eager aggregation) push down aggregation through join [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59326:
URL: https://github.com/apache/doris/pull/59326#issuecomment-3742921862
<details>
<summary>TPC-H: <b>Total hot run time: 36848 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9857be4ba67626a59ae5b3e5fed19dce32c0b476, data reload: false
------ Round 1 ----------------------------------
q1 17660 4197 4031 4031
q2 2086 354 239 239
q3 10412 1296 693 693
q4 10218 888 333 333
q5 7534 2079 1839 1839
q6 188 171 137 137
q7 934 766 665 665
q8 9269 1423 1235 1235
q9 4886 4586 4581 4581
q10 6393 2150 1836 1836
q11 550 317 306 306
q12 5527 5646 5519 5519
q13 17853 3551 3089 3089
q14 450 438 409 409
q15 605 514 517 514
q16 683 697 625 625
q17 661 769 503 503
q18 6925 6502 6265 6265
q19 1237 968 591 591
q20 378 363 253 253
q21 2993 2403 2209 2209
q22 1061 991 976 976
Total cold run time: 108503 ms
Total hot run time: 36848 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4102 4019 4040 4019
q2 322 385 332 332
q3 4101 4603 4267 4267
q4 1341 2190 1693 1693
q5 4549 4405 4452 4405
q6 219 176 134 134
q7 1937 2072 1827 1827
q8 2506 2500 2353 2353
q9 7273 7065 7301 7065
q10 4086 4483 4117 4117
q11 1047 988 955 955
q12 5823 5986 5544 5544
q13 6334 3872 3410 3410
q14 440 423 465 423
q15 555 491 506 491
q16 663 723 650 650
q17 1182 1279 1302 1279
q18 7989 7499 7104 7104
q19 820 784 784 784
q20 1866 1975 1800 1800
q21 4526 4229 4229 4229
q22 1058 1063 948 948
Total cold run time: 62739 ms
Total hot run time: 57829 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] eager agg from tpc_preview3 1224 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59326:
URL: https://github.com/apache/doris/pull/59326#issuecomment-3688885551
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org