You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/13 23:31:58 UTC

[jira] [Commented] (CB-11628) Cordova Screen Orientation Plugin

    [ https://issues.apache.org/jira/browse/CB-11628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746601#comment-15746601 ] 

ASF GitHub Bot commented on CB-11628:
-------------------------------------

Github user purplecabbage commented on the issue:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/4
  
    This pull request is missing about 10 tests.
    There is also some weird history happening, ex. `www/screenorientation.android.js → tests/tests.js`


> Cordova Screen Orientation Plugin
> ---------------------------------
>
>                 Key: CB-11628
>                 URL: https://issues.apache.org/jira/browse/CB-11628
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Screen Orientation
>         Environment: Android,iOS, Windows
>            Reporter: Vishal Mishra
>            Assignee: Vishal Mishra
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Make sure the orientation plugin matches the spec.
> We should also include tests.
> repo:  https://github.com/apache/cordova-plugin-screen-orientation
> spec: https://www.w3.org/TR/screen-orientation/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org