You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "ttttttz (Code Review)" <ge...@cloudera.org> on 2025/06/25 06:59:15 UTC
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
ttttttz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21760
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
C fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
35 files changed, 7,587 insertions(+), 243 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/35
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 35
Gerrit-Owner: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 42:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21760/38/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21760/38/be/src/catalog/catalog-server.cc@1208
PS38, Line 1208: // current_event.AddMember("cat_name", progress_info.current_event.catName);
> Why commenting out this?
NotificationEvent in Apache Hive 2.X does not have the catName field.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 42
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 28 Jun 2025 03:14:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 45:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19698/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 45
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 05 Jul 2025 17:24:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 58:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19713/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 58
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 15:01:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#55).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
C testdata/bin/patch_hive2.sh
R testdata/bin/patch_hive3.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
R testdata/cluster/hive3/README
R testdata/cluster/hive3/patch0-HIVE-21586.diff
R testdata/cluster/hive3/patch1-HIVE-21569.diff
R testdata/cluster/hive3/patch2-HIVE-20038.diff
R testdata/cluster/hive3/patch3-HIVE-20067.diff
R testdata/cluster/hive3/patch4-HIVE-27336.diff
M tests/common/environ.py
37 files changed, 7,471 insertions(+), 157 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/55
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 55
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#81).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,879 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/81
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 81
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 84:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12211/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 84
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 06:32:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 87:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12232/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 87
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 24 Jul 2025 06:44:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#69).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,886 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/69
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 69
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#94).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 7,903 insertions(+), 136 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/94
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 94
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 38:
(92 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS38, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS38, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS38, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS38, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS38, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS38, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS38, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS38, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS38, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS38, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS38, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS38, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS38, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS38, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS38, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS38, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS38, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS38, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS38, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS38, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS38, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS38, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS38, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS38, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS38, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS38, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS38, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS38, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS38, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS38, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS38, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS38, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS38, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS38, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS38, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS38, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS38, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS38, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS38, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS38, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS38, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS38, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS38, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS38, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS38, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS38, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS38, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS38, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS38, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS38, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS38, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS38, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS38, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS38, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS38, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS38, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS38, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS38, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS38, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS38, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS38, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS38, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS38, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS38, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS38, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS38, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS38, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS38, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS38, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS38, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS38, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS38, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS38, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS38, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS38, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS38, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS38, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS38, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS38, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS38, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS38, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS38, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS38, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS38, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS38, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS38, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS38, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS38, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS38, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS38, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java:
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java@1
PS38, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/21760/38/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1
PS38, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
line too long (102 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 38
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:51:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 119:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21224/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 119
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 09:55:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Riza Suminto, Zihao Ye, Pranav Lodha, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#120).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. There are some duplicate classes under
compat-apache-hive2 directory, e.g. fe/src/compat-apache-hive-2/java/
org/apache/impala/catalog/events/MetastoreEvents.java duplicates
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
The class in compat-apache-hive2 is a simplified version that works
with Apache Hive 2.x. So we don't need to extract lots of Hive-dependent
codes in MetastoreEvents.java into the metastore shim. Due to this,
the build process simply remove the original source code when building
on Apache Hive 2. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
TODO:
- IMPALA-14581: Support testing related to Apache Hive 2 in the minicluster.
Testing:
- Compile using the -package option to obtain the package. After
deployment, perform all types of query tests, including SELECT, INSERT,
CREATE TABLE, ALTER TABLE, COMPUTE STATUS, etc. In addition, comprehensive
testing has been conducted on the metadata auto-synchronization functionality.
The tests confirm that all event types are supported except for AlterDatabaseEvent,
AllocWriteIdEvent, AbortTxnEvent, PseudoAbortTxnEvent, and CommitCompactionEvent.
It is worth noting that these unsupported events are not generated in Apache Hive 2,
so their lack of processing support does not impact the functionality.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/impala-package/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
36 files changed, 8,164 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/120
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 120
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 94:
(1 comment)
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12494/
This failure is resolved in IMPALA-14416:
https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/6754/
The other failure is tracked in IMPALA-9049 and also resolved by IMPALA-14416:
https://jenkins.impala.io/job/ubuntu-20.04-dockerised-tests/4035/
The compilation error need to be fixed:
19:00:59 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project impala-frontend: Compilation failure
19:00:59 [ERROR] /home/ubuntu/Impala/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java:[1112,22] method reloadTableIfExists in class org.apache.impala.catalog.CatalogServiceCatalog cannot be applied to given types;
19:00:59 [ERROR] required: java.lang.String,java.lang.String,java.lang.String,long,boolean,java.util.List<java.lang.Long>
19:00:59 [ERROR] found: java.lang.String,java.lang.String,java.lang.String,long,boolean
19:00:59 [ERROR] reason: actual and formal argument lists differ in length
http://gerrit.cloudera.org:8080/#/c/21760/94/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21760/94/bin/impala-config.sh@406
PS94, Line 406: exit 1
The terminal will exit if we hit this when using "source bin/impala-config.sh". Let's use "return 1" instead.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 94
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 14:19:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 101:
> Patch Set 101:
>
> Build Failed
>
> https://jenkins.impala.io/job/gerrit-code-review-checks/20729/ : Initial code review checks failed. See linked job for details on the failure.
The build failure is tracked in IMPALA-14498.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 101
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 02:04:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 116:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21078/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 116
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 08:29:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 122:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12874/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 122
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 06 Jan 2026 10:57:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#97).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 8,076 insertions(+), 122 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/97
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 97
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#59).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
30 files changed, 7,533 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/59
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 59
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 59:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19714/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 59
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 15:26:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#49).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
33 files changed, 7,386 insertions(+), 145 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/49
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 49
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 49:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@29
PS49, Line 29: public class ValidReaderWriteIdList implements ValidWriteIdList {
> If these codes are never used and just used for compilation, we can make th
These codes were ported from Apache Hive 2. It might be better not to make any changes to it.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 49
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 09:40:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 60:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19717/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 60
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 17:12:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#58).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
30 files changed, 7,533 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/58
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 58
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 41: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12092/
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 41
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 27 Jun 2025 09:13:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 85:
> Patch Set 84: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12211/
I see the build error in https://jenkins.impala.io/job/all-build-options-ub2004/2906 is
The following builds failed:
:Options -skiptests -noclean USE_APACHE_HIVE_2=true:Options -notests -noclean -package USE_APACHE_HIVE_2=true:Options: mvn versions:set -DnewVersion=4.0.0-20250721
One error is
10:09:12 [ERROR] Failed to read artifact descriptor for org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde
10:09:12 [ERROR] Caused by: The following artifacts could not be resolved: org.pentaho:pentaho-aggdesigner-algorithm:pom:5.1.5-jhyde (absent): Could not transfer artifact org.pentaho:pentaho-aggdesigner-algorithm:pom:5.1.5-jhyde from/to impala.cdp.repo (https://native-toolchain-us-west-2.s3.us-west-2.amazonaws.com/build/cdp_components/58457853/maven): status code: 403, reason phrase: Forbidden (403)
Is it a dependency included by Hive 2? We might need to exclude it.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 85
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 00:06:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 99:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20588/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 99
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 28 Sep 2025 09:16:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 96:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20585/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 96
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 28 Sep 2025 06:35:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 69:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19841/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 69
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 17:13:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#74).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,903 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/74
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 74
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 93:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12293/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 93
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 09 Aug 2025 14:31:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#109).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 8,088 insertions(+), 124 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/109
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 109
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 94:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12494/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 94
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 14:54:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 121: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 121
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 05 Jan 2026 12:54:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 77:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19855/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 77
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 13 Jul 2025 16:04:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 63:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19722/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 63
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 18:23:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#43).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
33 files changed, 7,483 insertions(+), 145 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/43
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 43
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#44).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
33 files changed, 7,377 insertions(+), 145 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/44
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 44
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 54:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19709/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 54
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 14:23:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 56:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19711/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 56
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 14:30:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Riza Suminto, Zihao Ye, Pranav Lodha, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#121).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. There are some duplicate classes under
compat-apache-hive2 directory, e.g. fe/src/compat-apache-hive-2/java/
org/apache/impala/catalog/events/MetastoreEvents.java duplicates
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
The class in compat-apache-hive2 is a simplified version that works
with Apache Hive 2.x. So we don't need to extract lots of Hive-dependent
codes in MetastoreEvents.java into the metastore shim. Due to this,
the build process simply remove the original source code when building
on Apache Hive 2. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
TODO:
- IMPALA-14581: Support testing related to Apache Hive 2 in the minicluster.
Testing:
- Compile using the -package option to obtain the package. After
deployment, perform all types of query tests, including SELECT, INSERT,
CREATE TABLE, ALTER TABLE, COMPUTE STATUS, etc. In addition, comprehensive
testing has been conducted on the metadata auto-synchronization functionality.
The tests confirm that all event types are supported except for AlterDatabaseEvent,
AllocWriteIdEvent, AbortTxnEvent, PseudoAbortTxnEvent, and CommitCompactionEvent.
It is worth noting that these unsupported events are not generated in Apache Hive 2,
so their lack of processing support does not impact the functionality.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/impala-package/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
36 files changed, 8,179 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/121
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 121
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. There are some duplicate classes under
compat-apache-hive2 directory, e.g. fe/src/compat-apache-hive-2/java/
org/apache/impala/catalog/events/MetastoreEvents.java duplicates
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
The class in compat-apache-hive2 is a simplified version that works
with Apache Hive 2.x. So we don't need to extract lots of Hive-dependent
codes in MetastoreEvents.java into the metastore shim. Due to this,
the build process simply remove the original source code when building
on Apache Hive 2. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
TODO:
- IMPALA-14581: Support testing related to Apache Hive 2 in the minicluster.
Testing:
- Compile using the -package option to obtain the package. After
deployment, perform all types of query tests, including SELECT, INSERT,
CREATE TABLE, ALTER TABLE, COMPUTE STATUS, etc. In addition, comprehensive
testing has been conducted on the metadata auto-synchronization functionality.
The tests confirm that all event types are supported except for AlterDatabaseEvent,
AllocWriteIdEvent, AbortTxnEvent, PseudoAbortTxnEvent, and CommitCompactionEvent.
It is worth noting that these unsupported events are not generated in Apache Hive 2,
so their lack of processing support does not impact the functionality.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Reviewed-on: http://gerrit.cloudera.org:8080/21760
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/impala-package/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
36 files changed, 8,179 insertions(+), 138 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 123
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 111:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12683/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 111
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 17 Nov 2025 07:51:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#71).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,887 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/71
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 71
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 72:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19844/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 72
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 17:51:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 49:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@29
PS49, Line 29: public class ValidReaderWriteIdList implements ValidWriteIdList {
If these codes are never used and just used for compilation, we can make these fake classes that have no fields and all methods return nulls.
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
File fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java:
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java@798
PS49, Line 798: return "";
Instead of returning an empty string and add lots of codes for the missing catName, can we try patching hive_metastore.thrift to add the optional catName field? We have some patches for Apache Hive 3 under testdata/cluster/hive, used by testdata/bin/patch_hive.sh. We can add one for Apache Hive 2 in the same way.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 49
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 09:34:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 51:
(10 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@160
PS51, Line 160: org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@165
PS51, Line 165: org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@170
PS51, Line 170: org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@177
PS51, Line 177: org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS51, Line 766: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@774
PS51, Line 774: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@782
PS51, Line 782: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS51, Line 800: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@808
PS51, Line 808: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@816
PS51, Line 816: } else {
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 51
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 12:34:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 50:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19704/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 50
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 12:46:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 81:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19924/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 81
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 20 Jul 2025 05:28:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 83:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19925/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 83
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 20 Jul 2025 09:02:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 115: Code-Review+1
This looks safe enough to me, and not too intrusive.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 115
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 16:18:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 116:
> Patch Set 112:
>
> > Hi, Quanlong! I have made the revisions according to your suggestions.
>
> Thanks! Please also update the commit message based on comments.
done
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 116
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 03:08:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#76).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,887 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/76
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 76
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 79:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19857/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 79
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 13 Jul 2025 16:52:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 71:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19843/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 71
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 17:37:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 74:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19852/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 74
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 13 Jul 2025 07:44:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 80:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19922/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 80
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 20 Jul 2025 04:35:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#83).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,879 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/83
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 83
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 41:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12092/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 41
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 27 Jun 2025 03:13:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 42:
(92 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS42, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS42, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS42, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS42, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS42, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS42, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS42, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS42, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS42, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS42, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS42, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS42, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS42, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS42, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS42, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS42, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS42, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS42, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS42, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS42, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS42, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS42, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS42, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS42, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS42, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS42, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS42, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS42, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS42, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS42, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS42, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS42, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS42, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS42, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS42, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS42, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS42, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS42, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS42, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS42, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS42, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS42, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS42, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS42, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS42, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS42, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS42, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS42, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS42, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS42, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS42, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS42, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS42, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS42, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS42, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS42, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS42, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS42, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS42, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS42, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS42, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS42, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS42, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS42, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS42, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS42, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS42, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS42, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS42, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS42, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS42, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS42, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS42, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS42, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS42, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS42, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS42, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS42, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS42, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS42, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS42, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS42, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS42, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS42, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS42, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS42, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS42, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS42, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS42, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS42, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java:
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java@1
PS42, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1
PS42, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
line too long (102 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 42
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 27 Jun 2025 10:48:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 43:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19691/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 43
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 05 Jul 2025 16:16:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#56).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
C testdata/bin/patch_hive2.sh
R testdata/bin/patch_hive3.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
R testdata/cluster/hive3/README
R testdata/cluster/hive3/patch0-HIVE-21586.diff
R testdata/cluster/hive3/patch1-HIVE-21569.diff
R testdata/cluster/hive3/patch2-HIVE-20038.diff
R testdata/cluster/hive3/patch3-HIVE-20067.diff
R testdata/cluster/hive3/patch4-HIVE-27336.diff
M tests/common/environ.py
37 files changed, 7,471 insertions(+), 157 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/56
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 56
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#90).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,877 insertions(+), 136 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/90
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 90
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#89).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,878 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/89
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 89
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#96).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 7,891 insertions(+), 122 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/96
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 96
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Pranav Lodha, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#115).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. There are some duplicate classes under
compat-apache-hive2 directory, e.g. fe/src/compat-apache-hive-2/java/
org/apache/impala/catalog/events/MetastoreEvents.java duplicates
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
The class in compat-apache-hive2 is a simplified version that works
with Apache Hive 2.x. So we don't need to extract lots of Hive-dependent
codes in MetastoreEvents.java into the metastore shim. Due to this,
the build process simply remove the original source code when building
on Apache Hive 2. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
TODO:
- IMPALA-14581: Support testing related to Apache Hive 2 in the minicluster.
Testing:
- Compile using the -package option to obtain the package. After
deployment, perform all types of query tests, including SELECT, INSERT,
CREATE TABLE, ALTER TABLE, COMPUTE STATUS, etc. In addition, comprehensive
testing has been conducted on the metadata auto-synchronization functionality.
The tests confirm that all event types are supported except for AlterDatabaseEvent,
AllocWriteIdEvent, AbortTxnEvent, PseudoAbortTxnEvent, and CommitCompactionEvent.
It is worth noting that these unsupported events are not generated in Apache Hive 2,
so their lack of processing support does not impact the functionality.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 8,080 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/115
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 115
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 112:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21019/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 112
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 24 Nov 2025 16:20:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Pranav Lodha, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#113).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. There are some duplicate classes under
compat-apache-hive2 directory, e.g. fe/src/compat-apache-hive-2/java/
org/apache/impala/catalog/events/MetastoreEvents.java duplicates
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
The class in compat-apache-hive2 is a simplified version that works
with Apache Hive 2.x. So we don't need to extract lots of Hive-dependent
codes in MetastoreEvents.java into the metastore shim. Due to this,
the build process simply remove the original source code when building
on Apache Hive 2. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
TODO: Support testing related to Apache Hive 2 in the minicluster.
Testing:
After deployment, perform basic query tests and test the automatic
metadata synchronization functionality.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 8,080 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/113
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 113
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 119: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 119
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 02 Jan 2026 16:48:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 94:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20322/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 94
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 31 Aug 2025 16:55:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#78).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,873 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/78
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 78
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 55:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19710/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 55
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 14:29:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 48:
(93 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/48/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21760/48/be/src/catalog/catalog-server.cc@1209
PS48, Line 1209: status = catalog()->GetNotificationEventCatName(progress_info.current_event, &cat_name);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/be/src/catalog/catalog.h
File be/src/catalog/catalog.h:
http://gerrit.cloudera.org:8080/#/c/21760/48/be/src/catalog/catalog.h@170
PS48, Line 170: const Apache::Hadoop::Hive::NotificationEvent& notification_event, string* cat_name);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS48, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS48, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS48, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS48, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS48, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS48, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS48, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS48, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS48, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS48, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS48, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS48, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS48, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS48, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS48, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS48, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS48, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS48, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS48, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS48, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS48, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS48, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS48, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS48, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS48, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS48, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS48, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS48, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS48, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS48, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS48, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS48, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS48, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS48, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS48, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS48, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS48, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS48, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS48, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS48, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS48, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS48, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS48, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS48, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS48, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS48, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS48, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS48, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS48, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS48, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS48, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS48, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS48, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS48, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS48, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS48, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS48, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS48, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS48, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS48, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS48, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS48, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS48, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS48, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS48, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS48, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS48, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS48, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS48, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS48, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS48, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS48, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS48, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS48, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS48, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS48, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS48, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS48, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS48, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS48, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS48, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS48, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS48, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS48, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS48, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS48, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS48, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS48, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS48, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS48, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:
http://gerrit.cloudera.org:8080/#/c/21760/48/fe/src/main/java/org/apache/impala/service/JniCatalog.java@646
PS48, Line 646: public String getNotificationEventCatName(byte[] params) throws TException, ImpalaException {
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 48
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 06:34:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 47:
(93 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/47/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21760/47/be/src/catalog/catalog-server.cc@1209
PS47, Line 1209: status = catalog()->GetNotificationEventCatName(progress_info.current_event, &cat_name);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/be/src/catalog/catalog.h
File be/src/catalog/catalog.h:
http://gerrit.cloudera.org:8080/#/c/21760/47/be/src/catalog/catalog.h@170
PS47, Line 170: const Apache::Hadoop::Hive::NotificationEvent& notification_event, string* cat_name);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS47, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS47, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS47, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS47, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS47, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS47, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS47, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS47, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS47, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS47, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS47, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS47, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS47, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS47, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS47, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS47, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS47, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS47, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS47, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS47, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS47, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS47, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS47, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS47, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS47, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS47, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS47, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS47, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS47, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS47, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS47, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS47, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS47, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS47, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS47, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS47, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS47, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS47, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS47, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS47, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS47, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS47, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS47, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS47, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS47, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS47, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS47, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS47, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS47, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS47, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS47, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS47, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS47, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS47, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS47, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS47, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS47, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS47, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS47, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS47, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS47, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS47, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS47, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS47, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS47, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS47, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS47, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS47, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS47, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS47, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS47, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS47, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS47, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS47, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS47, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS47, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS47, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS47, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS47, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS47, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS47, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS47, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS47, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS47, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS47, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS47, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS47, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS47, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS47, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS47, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:
http://gerrit.cloudera.org:8080/#/c/21760/47/fe/src/main/java/org/apache/impala/service/JniCatalog.java@646
PS47, Line 646: public String getNotificationEventCatName(byte[] params) throws TException, ImpalaException {
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 47
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 06:19:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 84: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12211/
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 84
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 21 Jul 2025 10:09:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#100).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
35 files changed, 8,091 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/100
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 100
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 95:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20584/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 95
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 28 Sep 2025 03:37:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 101:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20729/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 101
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 17:52:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 94: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12494/
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 94
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 19:58:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 91: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12286/
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 91
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 15:51:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 89:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20072/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 89
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 09:28:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#66).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
31 files changed, 7,846 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/66
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 66
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#39).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
C fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
33 files changed, 7,596 insertions(+), 245 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/39
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 39
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 38:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19596/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 38
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 08:09:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#41).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
C fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
34 files changed, 7,607 insertions(+), 229 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/41
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 41
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 46:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19699/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 46
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 05 Jul 2025 18:35:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Pranav Lodha, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#118).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. There are some duplicate classes under
compat-apache-hive2 directory, e.g. fe/src/compat-apache-hive-2/java/
org/apache/impala/catalog/events/MetastoreEvents.java duplicates
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
The class in compat-apache-hive2 is a simplified version that works
with Apache Hive 2.x. So we don't need to extract lots of Hive-dependent
codes in MetastoreEvents.java into the metastore shim. Due to this,
the build process simply remove the original source code when building
on Apache Hive 2. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
TODO:
- IMPALA-14581: Support testing related to Apache Hive 2 in the minicluster.
Testing:
- Compile using the -package option to obtain the package. After
deployment, perform all types of query tests, including SELECT, INSERT,
CREATE TABLE, ALTER TABLE, COMPUTE STATUS, etc. In addition, comprehensive
testing has been conducted on the metadata auto-synchronization functionality.
The tests confirm that all event types are supported except for AlterDatabaseEvent,
AllocWriteIdEvent, AbortTxnEvent, PseudoAbortTxnEvent, and CommitCompactionEvent.
It is worth noting that these unsupported events are not generated in Apache Hive 2,
so their lack of processing support does not impact the functionality.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 8,087 insertions(+), 134 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/118
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 118
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Pranav Lodha, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#112).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 8,080 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/112
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 112
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 109:
> Patch Set 107:
>
> (1 comment)
Good! It can work.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 109
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 13:07:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 37:
(110 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS37, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS37, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS37, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS37, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS37, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS37, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS37, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS37, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS37, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS37, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS37, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS37, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS37, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS37, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS37, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS37, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS37, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS37, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS37, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS37, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS37, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS37, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS37, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS37, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS37, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS37, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS37, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS37, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS37, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS37, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS37, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS37, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS37, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS37, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS37, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS37, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS37, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS37, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS37, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS37, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS37, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS37, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS37, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS37, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS37, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS37, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS37, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS37, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS37, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS37, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS37, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS37, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS37, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS37, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS37, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS37, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS37, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS37, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS37, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS37, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS37, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS37, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS37, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS37, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS37, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS37, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS37, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS37, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS37, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS37, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS37, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS37, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS37, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS37, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS37, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS37, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS37, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS37, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS37, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS37, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS37, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS37, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS37, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS37, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS37, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS37, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS37, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS37, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS37, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS37, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
File fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java@788
PS37, Line 788: public static void setNotificationEventCatName(NotificationEvent event, String catName) {
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java@801
PS37, Line 801: public static void setInsertEventRequestDataReplace(InsertEventRequestData insertEventRequestData,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@332
PS37, Line 332: && catName.equalsIgnoreCase(MetastoreShim.getNotificationEventCatName(notificationEvent))
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@355
PS37, Line 355: && catName.equalsIgnoreCase(MetastoreShim.getNotificationEventCatName(notificationEvent))
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1650
PS37, Line 1650: throw new CatalogException("Impala adapted to Apache Hive 2.x does not support synchronizing " +
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2098
PS37, Line 2098: NotificationFilter filter = e -> MetastoreShim.isDefaultCatalog(MetastoreShim.getNotificationEventCatName(e))
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java@1
PS37, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1
PS37, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
File fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@861
PS37, Line 861: public static void setNotificationEventCatName(NotificationEvent event, String catName) {
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@869
PS37, Line 869: public static void setInsertEventRequestDataReplace(InsertEventRequestData insertEventRequestData,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/catalog/Table.java@931
PS37, Line 931: return MetastoreShim.getTableOwnerType(msTable_) == PrincipalType.USER ? msTable_.getOwner() : null;
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
File fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java@272
PS37, Line 272: MetastoreShim.setNotificationEventCatName(pseudoDropTableEvent, alterEvent.getCatalogName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java@282
PS37, Line 282: MetastoreShim.setNotificationEventCatName(pseudoCreateTableEvent, alterEvent.getCatalogName());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@236
PS37, Line 236: return MetastoreShim.getTableOwnerType(msTable_) == PrincipalType.USER ? msTable_.getOwner() : null;
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3343
PS37, Line 3343: MetastoreShim.getTableOwnerType(table.getMetaStoreTable()), /* newOwner */ null,
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3650
PS37, Line 3650: MetastoreShim.truncateTable(client.getHiveClient(), dbName, hdfsTable.getName(), null,
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4134
PS37, Line 4134: /* oldOwnerType */ null, msTable.getOwner(), MetastoreShim.getTableOwnerType(msTable),
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6498
PS37, Line 6498: MetastoreShim.setTableOwnerType(msTbl, PrincipalType.valueOf(params.owner_type.name()));
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7973
PS37, Line 7973: MetastoreShim.setInsertEventRequestDataReplace(insertEventRequestData, isInsertOverwrite);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
File fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java:
http://gerrit.cloudera.org:8080/#/c/21760/37/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java@546
PS37, Line 546: (MetastoreShim.getTableOwnerType(tbl) != null) ? MetastoreShim.getTableOwnerType(tbl).name() : "null", tableInfo);
line too long (122 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 37
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:15:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 37:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19594/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 37
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:30:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 86:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12218/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 86
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 03:19:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#80).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,878 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/80
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 80
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 122: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 122
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 06 Jan 2026 16:02:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#77).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,881 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/77
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 77
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#47).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
34 files changed, 7,373 insertions(+), 145 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/47
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 47
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 47:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19701/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 47
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 06:43:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 48:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19702/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 48
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 07:00:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#45).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
33 files changed, 7,378 insertions(+), 145 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/45
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 45
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#68).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
31 files changed, 7,867 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/68
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 68
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#72).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,887 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/72
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 72
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#73).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,887 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/73
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 73
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#60).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
30 files changed, 7,533 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/60
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 60
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#63).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
31 files changed, 7,819 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/63
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 63
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 92:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20103/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 92
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 09 Aug 2025 14:05:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#98).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 8,074 insertions(+), 122 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/98
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 98
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 90:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20074/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 90
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 10:12:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#101).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
35 files changed, 8,099 insertions(+), 125 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/101
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 101
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Pranav Lodha, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#119).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. There are some duplicate classes under
compat-apache-hive2 directory, e.g. fe/src/compat-apache-hive-2/java/
org/apache/impala/catalog/events/MetastoreEvents.java duplicates
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
The class in compat-apache-hive2 is a simplified version that works
with Apache Hive 2.x. So we don't need to extract lots of Hive-dependent
codes in MetastoreEvents.java into the metastore shim. Due to this,
the build process simply remove the original source code when building
on Apache Hive 2. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
TODO:
- IMPALA-14581: Support testing related to Apache Hive 2 in the minicluster.
Testing:
- Compile using the -package option to obtain the package. After
deployment, perform all types of query tests, including SELECT, INSERT,
CREATE TABLE, ALTER TABLE, COMPUTE STATUS, etc. In addition, comprehensive
testing has been conducted on the metadata auto-synchronization functionality.
The tests confirm that all event types are supported except for AlterDatabaseEvent,
AllocWriteIdEvent, AbortTxnEvent, PseudoAbortTxnEvent, and CommitCompactionEvent.
It is worth noting that these unsupported events are not generated in Apache Hive 2,
so their lack of processing support does not impact the functionality.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
35 files changed, 8,142 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/119
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 119
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 120:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21275/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 120
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 04 Jan 2026 08:50:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 68:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19838/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 68
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 06:07:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 42:
(3 comments)
Thanks for reviving this! Nice to see most of the tests are passed. The failed one seems to be a flaky test.
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@332
PS42, Line 332: MetastoreShim.getNotificationEventCatName(
: notificationEvent)
This is the main difference between MetastoreEventsProcessor implementations of Apache Hive 2 and other Hive versions. Can we just add this getNotificationEventCatName() method in MetastoreShim of other Hive versions to avoid duplicating MetastoreEventsProcessor for each of them?
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1652
PS42, Line 1652: "Impala adapted to Apache Hive 2.x does not support " +
: "synchronizing metadata by processing metadata events."
Is it intended to not support this? I think in CDH6 we still support it and CDH6 uses Hive-2.
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java:
http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java@3532
PS42, Line 3532: }
Moving these files has a great impact for future development. Backporting fixes to older branches will be hard. It'd be nice if we can keep MetastoreEvents and MetastoreEventsProcessor, and just extract some codes into MetastoreShim implementations.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 42
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 03 Jul 2025 03:56:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#65).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
30 files changed, 7,845 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/65
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 65
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 61:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/61/testdata/bin/patch_hive2.sh
File testdata/bin/patch_hive2.sh:
http://gerrit.cloudera.org:8080/#/c/21760/61/testdata/bin/patch_hive2.sh@68
PS61, Line 68: cp $HIVE_SRC_DIR/metastore/target/hive-metastore-${APACHE_HIVE_2_VERSION}.jar $HIVE_HOME/lib/
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 61
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 17:18:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#46).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
33 files changed, 7,382 insertions(+), 145 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/46
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 46
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 53:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19707/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 53
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 13:23:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#54).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
C testdata/bin/patch_hive2.sh
R testdata/bin/patch_hive3.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
R testdata/cluster/hive3/README
R testdata/cluster/hive3/patch0-HIVE-21586.diff
R testdata/cluster/hive3/patch1-HIVE-21569.diff
R testdata/cluster/hive3/patch2-HIVE-20038.diff
R testdata/cluster/hive3/patch3-HIVE-20067.diff
R testdata/cluster/hive3/patch4-HIVE-27336.diff
M tests/common/environ.py
37 files changed, 7,471 insertions(+), 157 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/54
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 54
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#48).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
34 files changed, 7,375 insertions(+), 145 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/48
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 48
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#37).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
C fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
35 files changed, 7,587 insertions(+), 243 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/37
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 37
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#38).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
C fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
35 files changed, 7,602 insertions(+), 245 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/38
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 38
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 41:
(92 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS41, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS41, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS41, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS41, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS41, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS41, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS41, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS41, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS41, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS41, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS41, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS41, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS41, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS41, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS41, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS41, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS41, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS41, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS41, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS41, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS41, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS41, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS41, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS41, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS41, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS41, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS41, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS41, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS41, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS41, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS41, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS41, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS41, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS41, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS41, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS41, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS41, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS41, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS41, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS41, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS41, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS41, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS41, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS41, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS41, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS41, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS41, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS41, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS41, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS41, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS41, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS41, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS41, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS41, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS41, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS41, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS41, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS41, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS41, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS41, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS41, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS41, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS41, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS41, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS41, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS41, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS41, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS41, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS41, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS41, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS41, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS41, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS41, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS41, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS41, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS41, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS41, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS41, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS41, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS41, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS41, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS41, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS41, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS41, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS41, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS41, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS41, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS41, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS41, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS41, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java:
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java@1
PS41, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/21760/41/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1
PS41, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
line too long (102 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 41
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 26 Jun 2025 09:14:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 35:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19591/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 35
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:18:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 103:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20853/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 103
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 09 Nov 2025 12:04:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 104:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20854/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 104
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 09 Nov 2025 13:08:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#105).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
33 files changed, 8,089 insertions(+), 125 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/105
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 105
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#99).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
35 files changed, 8,083 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/99
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 99
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Pranav Lodha, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#114).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. There are some duplicate classes under
compat-apache-hive2 directory, e.g. fe/src/compat-apache-hive-2/java/
org/apache/impala/catalog/events/MetastoreEvents.java duplicates
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
The class in compat-apache-hive2 is a simplified version that works
with Apache Hive 2.x. So we don't need to extract lots of Hive-dependent
codes in MetastoreEvents.java into the metastore shim. Due to this,
the build process simply remove the original source code when building
on Apache Hive 2. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
TODO: Support testing related to Apache Hive 2 in the minicluster.
Testing:
After deployment, perform basic query tests and test the automatic
metadata synchronization functionality.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 8,080 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/114
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 114
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 118: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12821/
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 118
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 21 Dec 2025 18:53:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 121:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12864/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 121
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 05 Jan 2026 07:59:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 121: Code-Review+2
Carrying +1 from Michael and Riza. Thank Zhi Tang for all your hard work to make this done!
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 121
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 06 Jan 2026 10:57:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 122: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 122
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 06 Jan 2026 10:57:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 111:
(5 comments)
I tried building the patch on Ubuntu 22.04 using -noclean -notests -format options.
The build succeeded but initializing the cluster failed:
ERROR in /root/impala/bin/create-test-configuration.sh at line 204: CLASSPATH={$CLASSPATH}:${CONFIG_DIR} ${HIVE_HOME}/bin/schematool -initSchema -dbType \
Generated: /root/impala/logs/extra_junit_xml_logs/generate_junitxml.buildall.create-test-configuration.20251118_03_23_26.xml
Checked logs/cluster/schematool.log,
Metastore connection URL: jdbc:postgresql://localhost:5432/HMS_root_impala_apache
Metastore Connection Driver : org.postgresql.Driver
Metastore connection User: hiveuser
org.apache.hadoop.hive.metastore.HiveMetaException: Failed to get schema version.
Underlying cause: org.postgresql.util.PSQLException : The authentication type 10 is not supported. Check that you have configured the pg_hba.conf file to include the client's IP address or subnet, and that it is using an authentication scheme supported by the driver.
SQL Error code: 0
Use --verbose for detailed stacktrace.
*** schemaTool failed ***
It seems we need to upgrade the PostgreSQL JDBC Driver used by Apache Hive 2.
http://gerrit.cloudera.org:8080/#/c/21760/111//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21760/111//COMMIT_MSG@18
PS111, Line 18: intrusion into the code
nit: "invasive changes"
http://gerrit.cloudera.org:8080/#/c/21760/111//COMMIT_MSG@24
PS111, Line 24:
Please also mention that there are some duplicate classes under compat-apache-hive2 dir, e.g. fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java duplicates fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
The class in compat-apache-hive2 is a simplified version that works with Apache Hive 2. So we don't need to extract lots of Hive-dependent codes in MetastoreEvents.java into the metastore shim.
Due to this, the build process simply remove the original source code when building on Apache Hive 2.
BTW, can we do this better by moving the original source code to somewhere that won't be compiled?
http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java:
http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java@100
PS111, Line 100: Apache Hive 3
nit: "Apache Hive 2"?
http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java@188
PS111, Line 188: /**
: * Wrapper method around message factory's build alter table message due to added
: * arguments in hive 3.
: */
: // @VisibleForTesting
: // public static AlterTableMessage buildAlterTableMessage(Table before, Table after,
: // boolean isTruncateOp, long writeId) {
: // return JSONMessageFactory.getInstance().buildAlterTableMessage(before, after,
: // isTruncateOp);
: // }
nit: Please remove these if we don't need them.
http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java:
http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@284
PS111, Line 284: ArrayList
nit: use the generic type List in definition.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 111
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 03:32:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 70:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19842/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 70
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 17:21:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 112:
> Hi, Quanlong! I have made the revisions according to your suggestions.
Thanks! Please also update the commit message based on comments.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 112
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 25 Nov 2025 01:42:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 112:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/21760/111/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:
http://gerrit.cloudera.org:8080/#/c/21760/111/bin/create-test-configuration.sh@204
PS111, Line 204: ${CLASSPATH}
> I think this is a typo. It should be ${CLASSPATH}. But it seems the CLASSPA
Done
http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java:
http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java@100
PS111, Line 100: Apache Hive 2
> nit: "Apache Hive 2"?
Done
http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java@188
PS111, Line 188: /**
: * Wrapper around HMS-3 message serializer
: * @param message
: * @return serialized string to use used in the NotificationEvent's message field
: */
: @VisibleForTesting
: public static String serializeEventMessage(EventMessage message) {
: return message.toString();
: }
:
> nit: Please remove these if we don't need them.
Done
http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java:
http://gerrit.cloudera.org:8080/#/c/21760/111/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@284
PS111, Line 284: List<Stri
> nit: use the generic type List in definition.
Done
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 112
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 24 Nov 2025 15:57:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 97:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20586/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 97
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 28 Sep 2025 08:25:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 98:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20587/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 98
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 28 Sep 2025 08:37:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#104).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. In order to reduce the unnecessary intrusion
into the code, skip all tests when building with Apache Hive 2.x.
If wanting to build Impala adapted to Apache Hive 2.x, please set the
following environment variables before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
33 files changed, 8,089 insertions(+), 125 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/104
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 104
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 110:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20874/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 110
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 13:34:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 111: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 111
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 17 Nov 2025 12:33:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 118:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21214/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 118
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 10:58:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 119: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 119
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 20:36:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 119: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12824/
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 119
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 14:28:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 119:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12827/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 119
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 15:43:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 39:
(2 comments)
Thanks for working on this!
http://gerrit.cloudera.org:8080/#/c/21760/38/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21760/38/be/src/catalog/catalog-server.cc@1208
PS38, Line 1208: // current_event.AddMember("cat_name", progress_info.current_event.catName);
Why commenting out this?
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@1
PS39, Line 1: /**
: * Autogenerated by Thrift Compiler (0.9.3)
: *
: * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
: * @generated
: */
We need the license header comment or add these file names to bin/rat_exclude_files.txt
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 39
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 26 Jun 2025 05:20:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 40:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19608/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 40
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 26 Jun 2025 08:58:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 39:
> Patch Set 39:
>
> (2 comments)
>
> Thanks for working on this!
got
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 39
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 26 Jun 2025 07:36:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 41:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@1
PS39, Line 1: /**
: * Autogenerated by Thrift Compiler (0.9.3)
: *
: * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
: * @generated
: */
> We need the license header comment or add these file names to bin/rat_exclu
Ack
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 41
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 26 Jun 2025 10:01:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 67:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19826/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 67
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 11 Jul 2025 14:51:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 42:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19625/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 42
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 27 Jun 2025 11:13:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 46:
(93 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/46/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21760/46/be/src/catalog/catalog-server.cc@1209
PS46, Line 1209: status = catalog()->GetNotificationEventCatName(progress_info.current_event, &cat_name);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/be/src/catalog/catalog.h
File be/src/catalog/catalog.h:
http://gerrit.cloudera.org:8080/#/c/21760/46/be/src/catalog/catalog.h@170
PS46, Line 170: const Apache::Hadoop::Hive::NotificationEvent& notification_event, string* cat_name);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS46, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS46, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS46, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS46, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS46, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS46, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS46, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS46, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS46, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS46, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS46, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS46, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS46, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS46, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS46, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS46, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS46, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS46, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS46, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS46, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS46, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS46, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS46, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS46, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS46, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS46, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS46, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS46, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS46, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS46, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS46, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS46, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS46, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS46, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS46, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS46, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS46, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS46, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS46, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS46, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS46, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS46, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS46, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS46, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS46, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS46, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS46, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS46, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS46, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS46, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS46, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS46, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS46, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS46, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS46, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS46, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS46, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS46, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS46, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS46, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS46, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS46, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS46, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS46, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS46, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS46, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS46, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS46, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS46, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS46, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS46, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS46, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS46, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS46, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS46, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS46, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS46, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS46, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS46, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS46, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS46, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS46, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS46, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS46, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS46, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS46, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS46, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS46, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS46, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS46, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:
http://gerrit.cloudera.org:8080/#/c/21760/46/fe/src/main/java/org/apache/impala/service/JniCatalog.java@646
PS46, Line 646: public String getNotificationEventCatName(byte[] params) throws TException, ImpalaException {
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 46
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 05 Jul 2025 18:11:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 50:
(29 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS50, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@92
PS50, Line 92: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS50, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@60
PS50, Line 60: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@86
PS50, Line 86: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS50, Line 39: @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@48
PS50, Line 48: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC =
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@157
PS50, Line 157: org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@162
PS50, Line 162: org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@167
PS50, Line 167: org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@168
PS50, Line 168: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@168
PS50, Line 168: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@173
PS50, Line 173: org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@281
PS50, Line 281: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID,
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@336
PS50, Line 336: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@347
PS50, Line 347: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@451
PS50, Line 451: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@622
PS50, Line 622: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@749
PS50, Line 749: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@756
PS50, Line 756: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@764
PS50, Line 764: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@772
PS50, Line 772: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@790
PS50, Line 790: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@798
PS50, Line 798: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@806
PS50, Line 806: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@819
PS50, Line 819: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@835
PS50, Line 835: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64,
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@867
PS50, Line 867: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/50/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@870
PS50, Line 870: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct)
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 50
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 12:22:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#51).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
C testdata/bin/patch_hive2.sh
R testdata/bin/patch_hive3.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
R testdata/cluster/hive3/README
R testdata/cluster/hive3/patch0-HIVE-21586.diff
R testdata/cluster/hive3/patch1-HIVE-21569.diff
R testdata/cluster/hive3/patch2-HIVE-20038.diff
R testdata/cluster/hive3/patch3-HIVE-20067.diff
R testdata/cluster/hive3/patch4-HIVE-27336.diff
M tests/common/environ.py
39 files changed, 7,497 insertions(+), 164 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/51
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 51
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#53).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
C testdata/bin/patch_hive2.sh
R testdata/bin/patch_hive3.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
R testdata/cluster/hive3/README
R testdata/cluster/hive3/patch0-HIVE-21586.diff
R testdata/cluster/hive3/patch1-HIVE-21569.diff
R testdata/cluster/hive3/patch2-HIVE-20038.diff
R testdata/cluster/hive3/patch3-HIVE-20067.diff
R testdata/cluster/hive3/patch4-HIVE-27336.diff
M tests/common/environ.py
39 files changed, 7,508 insertions(+), 164 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/53
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 53
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 60:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/60/testdata/bin/patch_hive2.sh
File testdata/bin/patch_hive2.sh:
http://gerrit.cloudera.org:8080/#/c/21760/60/testdata/bin/patch_hive2.sh@68
PS60, Line 68: cp $HIVE_SRC_DIR/metastore/target/hive-metastore-${APACHE_HIVE_2_VERSION}.jar $HIVE_HOME/lib/
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 60
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 16:54:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#62).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
31 files changed, 7,537 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/62
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 62
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 64:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19731/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 64
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 07 Jul 2025 08:58:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 65:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19748/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 65
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 08 Jul 2025 09:10:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Pranav Lodha, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#116).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. There are some duplicate classes under
compat-apache-hive2 directory, e.g. fe/src/compat-apache-hive-2/java/
org/apache/impala/catalog/events/MetastoreEvents.java duplicates
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
The class in compat-apache-hive2 is a simplified version that works
with Apache Hive 2.x. So we don't need to extract lots of Hive-dependent
codes in MetastoreEvents.java into the metastore shim. Due to this,
the build process simply remove the original source code when building
on Apache Hive 2. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
TODO:
- IMPALA-14581: Support testing related to Apache Hive 2 in the minicluster.
Testing:
- Compile using the -package option to obtain the package. After
deployment, perform all types of query tests, including SELECT, INSERT,
CREATE TABLE, ALTER TABLE, COMPUTE STATUS, etc. In addition, comprehensive
testing has been conducted on the metadata auto-synchronization functionality.
The tests confirm that all event types are supported except for AlterDatabaseEvent,
AllocWriteIdEvent, AbortTxnEvent, PseudoAbortTxnEvent, and CommitCompactionEvent.
It is worth noting that these unsupported events are not generated in Apache Hive 2,
so their lack of processing support does not impact the functionality.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/create-test-configuration.sh
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 8,080 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/116
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 116
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 57:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19712/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 57
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 14:47:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#61).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
31 files changed, 7,536 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/61
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 61
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 45:
(93 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/45/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21760/45/be/src/catalog/catalog-server.cc@1209
PS45, Line 1209: status = catalog()->GetNotificationEventCatName(progress_info.current_event, &cat_name);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/be/src/catalog/catalog.h
File be/src/catalog/catalog.h:
http://gerrit.cloudera.org:8080/#/c/21760/45/be/src/catalog/catalog.h@170
PS45, Line 170: const Apache::Hadoop::Hive::NotificationEvent& notification_event, string* cat_name);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS45, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS45, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS45, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS45, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS45, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS45, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS45, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS45, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS45, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS45, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS45, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS45, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS45, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS45, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS45, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS45, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS45, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS45, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS45, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS45, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS45, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS45, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS45, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS45, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS45, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS45, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS45, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS45, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS45, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS45, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS45, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS45, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS45, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS45, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS45, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS45, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS45, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS45, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS45, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS45, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS45, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS45, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS45, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS45, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS45, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS45, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS45, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS45, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS45, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS45, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS45, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS45, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS45, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS45, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS45, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS45, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS45, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS45, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS45, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS45, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS45, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS45, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS45, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS45, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS45, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS45, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS45, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS45, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS45, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS45, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS45, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS45, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS45, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS45, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS45, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS45, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS45, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS45, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS45, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS45, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS45, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS45, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS45, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS45, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS45, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS45, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS45, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS45, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS45, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS45, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:
http://gerrit.cloudera.org:8080/#/c/21760/45/fe/src/main/java/org/apache/impala/service/JniCatalog.java@646
PS45, Line 646: public String getNotificationEventCatName(byte[] params) throws TException, ImpalaException {
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 45
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 05 Jul 2025 17:09:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 44:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19695/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 44
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 05 Jul 2025 16:52:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 49:
(93 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/49/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21760/49/be/src/catalog/catalog-server.cc@1209
PS49, Line 1209: status = catalog()->GetNotificationEventCatName(progress_info.current_event, &cat_name);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/be/src/catalog/catalog.h
File be/src/catalog/catalog.h:
http://gerrit.cloudera.org:8080/#/c/21760/49/be/src/catalog/catalog.h@170
PS49, Line 170: const Apache::Hadoop::Hive::NotificationEvent& notification_event, string* cat_name);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS49, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS49, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS49, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS49, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS49, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS49, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS49, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS49, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS49, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS49, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS49, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS49, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS49, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS49, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS49, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS49, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS49, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS49, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS49, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS49, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS49, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS49, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS49, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS49, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS49, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS49, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS49, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS49, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS49, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS49, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS49, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS49, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS49, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS49, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS49, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS49, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS49, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS49, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS49, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS49, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS49, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS49, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS49, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS49, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS49, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS49, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS49, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS49, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS49, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS49, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS49, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS49, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS49, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS49, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS49, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS49, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS49, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS49, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS49, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS49, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS49, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS49, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS49, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS49, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS49, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS49, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS49, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS49, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS49, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS49, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS49, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS49, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS49, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS49, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS49, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS49, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS49, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS49, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS49, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS49, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS49, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS49, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS49, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS49, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS49, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS49, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS49, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS49, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS49, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS49, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:
http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/main/java/org/apache/impala/service/JniCatalog.java@646
PS49, Line 646: public String getNotificationEventCatName(byte[] params) throws TException, ImpalaException {
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 49
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 07:08:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#50).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
C testdata/bin/patch_hive2.sh
R testdata/bin/patch_hive3.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
R testdata/cluster/hive3/README
R testdata/cluster/hive3/patch0-HIVE-21586.diff
R testdata/cluster/hive3/patch1-HIVE-21569.diff
R testdata/cluster/hive3/patch2-HIVE-20038.diff
R testdata/cluster/hive3/patch3-HIVE-20067.diff
R testdata/cluster/hive3/patch4-HIVE-27336.diff
M tests/common/environ.py
39 files changed, 7,480 insertions(+), 164 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/50
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 50
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 49:
> Patch Set 49:
>
> (2 comments)
It seems that this is a good approach. In this way, we can reduce a lot of code modifications.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 49
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 09:42:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 51:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19705/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 51
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 12:58:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#64).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
30 files changed, 7,819 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/64
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 64
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 43:
(93 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/43/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21760/43/be/src/catalog/catalog-server.cc@1209
PS43, Line 1209: status = catalog()->GetNotificationEventCatName(progress_info.current_event, &cat_name);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/be/src/catalog/catalog.h
File be/src/catalog/catalog.h:
http://gerrit.cloudera.org:8080/#/c/21760/43/be/src/catalog/catalog.h@169
PS43, Line 169: const Apache::Hadoop::Hive::NotificationEvent& notification_event, string* cat_name);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS43, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS43, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS43, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS43, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS43, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS43, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS43, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS43, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS43, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS43, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS43, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS43, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS43, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS43, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS43, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS43, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS43, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS43, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS43, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS43, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS43, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS43, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS43, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS43, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS43, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS43, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS43, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS43, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS43, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS43, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS43, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS43, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS43, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS43, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS43, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS43, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS43, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS43, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS43, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS43, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS43, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS43, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS43, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS43, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS43, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS43, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS43, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS43, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS43, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS43, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS43, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS43, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS43, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS43, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS43, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS43, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS43, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS43, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS43, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS43, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS43, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS43, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS43, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS43, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS43, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS43, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS43, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS43, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS43, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS43, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS43, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS43, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS43, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS43, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS43, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS43, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS43, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS43, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS43, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS43, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS43, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS43, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS43, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS43, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS43, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS43, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS43, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS43, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS43, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS43, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:
http://gerrit.cloudera.org:8080/#/c/21760/43/fe/src/main/java/org/apache/impala/service/JniCatalog.java@646
PS43, Line 646: public String getNotificationEventCatName(byte[] params) throws TException, ImpalaException {
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 43
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 05 Jul 2025 15:58:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#52).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
C testdata/bin/patch_hive2.sh
R testdata/bin/patch_hive3.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
R testdata/cluster/hive3/README
R testdata/cluster/hive3/patch0-HIVE-21586.diff
R testdata/cluster/hive3/patch1-HIVE-21569.diff
R testdata/cluster/hive3/patch2-HIVE-20038.diff
R testdata/cluster/hive3/patch3-HIVE-20067.diff
R testdata/cluster/hive3/patch4-HIVE-27336.diff
M tests/common/environ.py
38 files changed, 7,509 insertions(+), 164 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/52
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 52
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#57).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
R fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
30 files changed, 7,533 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/57
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 57
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 62:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19719/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 62
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 17:47:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#110).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. Additionally, it should be noted that all
the code in the fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive
directory comes from Apache Hive 3.x, original
source: https://github.com/apache/hive/blob/branch-3.1
In order to reduce the unnecessary intrusion into the code, skip all
tests when building with Apache Hive 2.x. If wanting to build Impala
adapted to Apache Hive 2.x, please set the following environment variables
before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
33 files changed, 8,089 insertions(+), 125 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/110
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 110
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 121:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21278/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 121
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 05 Jan 2026 07:51:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 112:
> Patch Set 112:
>
> (4 comments)
Hi, Quanlong! I have made the revisions according to your suggestions.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 112
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 24 Nov 2025 15:58:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 118:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12821/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 118
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 21 Dec 2025 13:54:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#95).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 7,909 insertions(+), 136 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/95
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 95
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 93: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 93
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 09 Aug 2025 20:05:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#88).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,879 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/88
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 88
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 88:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20062/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 88
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 06 Aug 2025 17:20:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#42).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
C fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
34 files changed, 7,605 insertions(+), 229 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/42
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 42
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#67).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
31 files changed, 7,841 insertions(+), 137 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/67
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 67
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#70).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,886 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/70
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 70
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#75).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,903 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/75
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 75
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 76:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19854/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 76
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 13 Jul 2025 14:11:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#79).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,875 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/79
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 79
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 100:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12550/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 100
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 09 Oct 2025 12:47:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 100: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12550/
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 100
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 09 Oct 2025 17:32:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 93:
(5 comments)
This is a great work! Thanks for your efforts on this!
I'd like to run exhaustive tests but the job failed due to IMPALA-14308. Please rebase this patch to get the fix.
http://gerrit.cloudera.org:8080/#/c/21760/93//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21760/93//COMMIT_MSG@18
PS93, Line 18:
Please summarize the changes in fe/pom.xml and where the files under fe/src/compat-apache-hive-2 come from. Are they all copied from Hive?
http://gerrit.cloudera.org:8080/#/c/21760/93/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21760/93/bin/impala-config.sh@406
PS93, Line 406: exit 1
I think "return 1" is better since "exit 1" will close the current shell session if I'm running "source bin/impala-config.sh" and I don't have chance to see the error messages.
http://gerrit.cloudera.org:8080/#/c/21760/93/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/93/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@17
PS93, Line 17: */
For files under fe/src/compat-apache-hive-2, please add a comment if they are copied from other projects and mention if there are any changes. E.g.
// This code is copied from apache/thrift and modified to return
// HTTP response headers from transport.
// Original Source:
// https://github.com/apache/thrift/blob/v0.16.0/lib/java/src/org/apache/thrift/transport/
// THttpClient.java
https://github.com/apache/impala/blob/ad7888898bc76438cc90b03b2561d91854df03e1/fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java#L20-L24
http://gerrit.cloudera.org:8080/#/c/21760/93/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
File fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java:
http://gerrit.cloudera.org:8080/#/c/21760/93/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java@452
PS93, Line 452: public static String toHivePartitionName(List<String> partitionColNames,
We have some similar getPartitionName() methods in FeCatalogUtils.java. Can we move this there? We can probably reuse some codes.
http://gerrit.cloudera.org:8080/#/c/21760/93/java/shaded-deps/hive-exec/pom.xml
File java/shaded-deps/hive-exec/pom.xml:
http://gerrit.cloudera.org:8080/#/c/21760/93/java/shaded-deps/hive-exec/pom.xml@152
PS93, Line 152: <url>https://maven.aliyun.com/repository/spring-plugin</url>
Please add a comment about why we need this.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 93
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 22 Aug 2025 11:15:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 40:
(92 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS40, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS40, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS40, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS40, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS40, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS40, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS40, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS40, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS40, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS40, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS40, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS40, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS40, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS40, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS40, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS40, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS40, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS40, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS40, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS40, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS40, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS40, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS40, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS40, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS40, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS40, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS40, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS40, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS40, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS40, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS40, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS40, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS40, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS40, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS40, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS40, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS40, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS40, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS40, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS40, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS40, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS40, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS40, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS40, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS40, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS40, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS40, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS40, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS40, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS40, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS40, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS40, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS40, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS40, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS40, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS40, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS40, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS40, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS40, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS40, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS40, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS40, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS40, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS40, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS40, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS40, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS40, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS40, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS40, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS40, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS40, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS40, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS40, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS40, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS40, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS40, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS40, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS40, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS40, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS40, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS40, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS40, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS40, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS40, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS40, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS40, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS40, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS40, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS40, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS40, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java:
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java@1
PS40, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/21760/40/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1
PS40, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
line too long (102 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 40
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 26 Jun 2025 08:32:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#40).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To minimize code intrusiveness,
the test compilation phase is skipped. And due to the lack of completeness
in the Notifycation Log feature, Impala adapted to Apache Hive 2.x does
not support synchronizing metadata by processing metadata events.
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M be/src/catalog/catalog-server.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
C fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
R fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M tests/common/environ.py
34 files changed, 7,602 insertions(+), 245 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/40
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 40
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 41:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19609/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 41
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 26 Jun 2025 09:38:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 39:
(92 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS39, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS39, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS39, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS39, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS39, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS39, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS39, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS39, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS39, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS39, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS39, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS39, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS39, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS39, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS39, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS39, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS39, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS39, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS39, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS39, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS39, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS39, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS39, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS39, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS39, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS39, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS39, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS39, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS39, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS39, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS39, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS39, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS39, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS39, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS39, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS39, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS39, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS39, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS39, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS39, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS39, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS39, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS39, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS39, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS39, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS39, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS39, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS39, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS39, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS39, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS39, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS39, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS39, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS39, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS39, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS39, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS39, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS39, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS39, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS39, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS39, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS39, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS39, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS39, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS39, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS39, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS39, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS39, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS39, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS39, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS39, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS39, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS39, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS39, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS39, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS39, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS39, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS39, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS39, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS39, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS39, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS39, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS39, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS39, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS39, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS39, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS39, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS39, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS39, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS39, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java:
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java@1
PS39, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1
PS39, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
line too long (102 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 39
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 08:44:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 39:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12081/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 39
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 09:10:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 35:
(110 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS35, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS35, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS35, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS35, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS35, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS35, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS35, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS35, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS35, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS35, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS35, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS35, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS35, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS35, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS35, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS35, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS35, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS35, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS35, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS35, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS35, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS35, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS35, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS35, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS35, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS35, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS35, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS35, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS35, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS35, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS35, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS35, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS35, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS35, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS35, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS35, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS35, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS35, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS35, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS35, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS35, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS35, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS35, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS35, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS35, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS35, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS35, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS35, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS35, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS35, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS35, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS35, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS35, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS35, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS35, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS35, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS35, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS35, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS35, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS35, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS35, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS35, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS35, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS35, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS35, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS35, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS35, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS35, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS35, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS35, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS35, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS35, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS35, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS35, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS35, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS35, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS35, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS35, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS35, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS35, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS35, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS35, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS35, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS35, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS35, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS35, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS35, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS35, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS35, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS35, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
File fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java@788
PS35, Line 788: public static void setNotificationEventCatName(NotificationEvent event, String catName) {
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java@801
PS35, Line 801: public static void setInsertEventRequestDataReplace(InsertEventRequestData insertEventRequestData,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@332
PS35, Line 332: && catName.equalsIgnoreCase(MetastoreShim.getNotificationEventCatName(notificationEvent))
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@355
PS35, Line 355: && catName.equalsIgnoreCase(MetastoreShim.getNotificationEventCatName(notificationEvent))
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1650
PS35, Line 1650: throw new CatalogException("Impala adapted to Apache Hive 2.x does not support synchronizing " +
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2098
PS35, Line 2098: NotificationFilter filter = e -> MetastoreShim.isDefaultCatalog(MetastoreShim.getNotificationEventCatName(e))
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java@1
PS35, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1
PS35, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
File fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@861
PS35, Line 861: public static void setNotificationEventCatName(NotificationEvent event, String catName) {
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@869
PS35, Line 869: public static void setInsertEventRequestDataReplace(InsertEventRequestData insertEventRequestData,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/Table.java@931
PS35, Line 931: return MetastoreShim.getTableOwnerType(msTable_) == PrincipalType.USER ? msTable_.getOwner() : null;
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java
File fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java@272
PS35, Line 272: MetastoreShim.setNotificationEventCatName(pseudoDropTableEvent, alterEvent.getCatalogName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java@282
PS35, Line 282: MetastoreShim.setNotificationEventCatName(pseudoCreateTableEvent, alterEvent.getCatalogName());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@236
PS35, Line 236: return MetastoreShim.getTableOwnerType(msTable_) == PrincipalType.USER ? msTable_.getOwner() : null;
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3343
PS35, Line 3343: MetastoreShim.getTableOwnerType(table.getMetaStoreTable()), /* newOwner */ null,
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3650
PS35, Line 3650: MetastoreShim.truncateTable(client.getHiveClient(), dbName, hdfsTable.getName(), null,
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4134
PS35, Line 4134: /* oldOwnerType */ null, msTable.getOwner(), MetastoreShim.getTableOwnerType(msTable),
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6498
PS35, Line 6498: MetastoreShim.setTableOwnerType(msTbl, PrincipalType.valueOf(params.owner_type.name()));
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7973
PS35, Line 7973: MetastoreShim.setInsertEventRequestDataReplace(insertEventRequestData, isInsertOverwrite);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
File fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java:
http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java@546
PS35, Line 546: (MetastoreShim.getTableOwnerType(tbl) != null) ? MetastoreShim.getTableOwnerType(tbl).name() : "null", tableInfo);
line too long (122 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 35
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 07:01:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 44:
(93 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/21760/44/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/21760/44/be/src/catalog/catalog-server.cc@1209
PS44, Line 1209: status = catalog()->GetNotificationEventCatName(progress_info.current_event, &cat_name);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/be/src/catalog/catalog.h
File be/src/catalog/catalog.h:
http://gerrit.cloudera.org:8080/#/c/21760/44/be/src/catalog/catalog.h@169
PS44, Line 169: const Apache::Hadoop::Hive::NotificationEvent& notification_event, string* cat_name);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33
PS44, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45
PS44, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) {
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49
PS44, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) {
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255
PS44, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25
PS44, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67
PS44, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85
PS44, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>...
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90
PS44, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) {
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java:
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41
PS44, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42
PS44, Line 42: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50
PS44, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58
PS44, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59
PS44, Line 59: * for different implementations, as some will only want to see committed transactions and some
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83
PS44, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList.
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94
PS44, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95
PS44, Line 95: * may have different meanings for different implementations, as some will only want to see open
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java:
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38
PS44, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> {
line too long (300 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39
PS44, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds");
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41
PS44, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42
PS44, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2);
line too long (205 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43
PS44, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3);
line too long (194 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44
PS44, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4);
line too long (192 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45
PS44, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5);
line too long (187 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47
PS44, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>();
line too long (133 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59
PS44, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101
PS44, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!");
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136
PS44, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class);
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS44, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137
PS44, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (153 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138
PS44, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING)));
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS44, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139
PS44, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (169 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140
PS44, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS44, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141
PS44, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (157 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS44, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142
PS44, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143
PS44, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))));
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS44, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144
PS44, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL,
line too long (156 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145
PS44, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)));
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS44, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146
PS44, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED,
line too long (148 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147
PS44, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149
PS44, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215
PS44, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236
PS44, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239
PS44, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245
PS44, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275
PS44, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296
PS44, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299
PS44, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305
PS44, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value);
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318
PS44, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length));
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329
PS44, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406
PS44, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528
PS44, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName());
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533
PS44, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName);
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538
PS44, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark());
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543
PS44, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark);
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548
PS44, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds());
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553
PS44, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558
PS44, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId());
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563
PS44, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568
PS44, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits());
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573
PS44, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585
PS44, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589
PS44, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638
PS44, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString());
line too long (127 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642
PS44, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString());
line too long (134 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646
PS44, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString());
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650
PS44, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString());
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658
PS44, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out)));
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664
PS44, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666
PS44, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
line too long (132 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668
PS44, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in)));
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680
PS44, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> {
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682
PS44, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688
PS44, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696
PS44, Line 696: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704
PS44, Line 704: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722
PS44, Line 722: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730
PS44, Line 730: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738
PS44, Line 738: } else {
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751
PS44, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (130 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766
PS44, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size()));
line too long (138 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797
PS44, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> {
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800
PS44, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (129 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823
PS44, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException {
line too long (128 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830
PS44, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32());
line too long (144 > 90)
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:
http://gerrit.cloudera.org:8080/#/c/21760/44/fe/src/main/java/org/apache/impala/service/JniCatalog.java@646
PS44, Line 646: public String getNotificationEventCatName(byte[] params) throws TException, ImpalaException {
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 44
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 05 Jul 2025 16:35:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 49:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19703/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 49
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 07:33:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 66:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19749/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 66
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 08 Jul 2025 09:48:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 52:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19706/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 52
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 13:10:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 61:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19718/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 61
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 17:35:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 91:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12286/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 91
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 10:15:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#92).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
34 files changed, 7,903 insertions(+), 136 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/92
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 92
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 100:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20589/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 100
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 28 Sep 2025 09:28:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#82).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. To reduce the intrusion into the
code, we skip all tests. When building Impala adapted to Apache
Hive 2.x, please set the following environment variables before
`source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
M java/calcite-planner/pom.xml
M java/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
32 files changed, 7,879 insertions(+), 138 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/82
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 82
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 78:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19856/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 78
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 13 Jul 2025 16:41:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 39: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12081/
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 39
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 15:08:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 39:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/19598/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 39
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 25 Jun 2025 09:09:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 75:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19853/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 75
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 13 Jul 2025 09:16:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 86: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12218/
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 86
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 09:27:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21760
to look at the new patch set (#103).
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
IMPALA-12349: Support Apache Hive 2.x in Impala
Like IMPALA-10871, this patch adds MetastoreShim to support Apache
Hive 2.x. At the build time, based on the environment variable
IMPALA_HIVE_DIST_TYPE one of the three shims is added to as source
using the fe/pom.xml build plugin. And select the dependencies
related to Hive in the fe/pom.xml based on the environment variable
IMPALA_HIVE_MAJOR_VERSION. In order to reduce the unnecessary intrusion
into the code, skip all tests when building with Apache Hive 2.x.
If wanting to build Impala adapted to Apache Hive 2.x, please set the
following environment variables before `source bin/impala-config.sh`:
export USE_APACHE_COMPONENTS=true
export USE_APACHE_HIVE_2=true
Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M bin/rat_exclude_files.txt
M buildall.sh
M common/function-registry/CMakeLists.txt
M fe/pom.xml
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
A fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEvents.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
A fe/src/compat-apache-hive-2/java/org/apache/impala/compat/MetastoreShim.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/TConfiguration.java
A fe/src/compat-apache-hive-2/java/org/apache/thrift/transport/TEndpointTransport.java
M fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java
M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M java/calcite-planner/pom.xml
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
A testdata/bin/patch_hive2.sh
A testdata/cluster/hive2/patch0-HIVE-18755.diff
M tests/common/environ.py
35 files changed, 8,099 insertions(+), 125 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/21760/103
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 103
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 119:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12824/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 119
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 09:29:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 73:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19845/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 73
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 18:16:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 107:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21760/107/tests/common/environ.py
File tests/common/environ.py:
http://gerrit.cloudera.org:8080/#/c/21760/107/tests/common/environ.py@44
PS107, Line 44: "VERSION: ([^\s]*)\n"
I think we can get rid of the build failure (https://jenkins.impala.io/job/gerrit-auto-critic-test/3061/) by using raw string here:
r"VERSION: ([^\s]*)\n"
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 107
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 10 Nov 2025 11:26:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 109:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/20873/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 109
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 13:15:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 111:
(1 comment)
> Patch Set 111:
>
> (5 comments)
>
> I tried building the patch on Ubuntu 22.04 using -noclean -notests -format options.
>
> The build succeeded but initializing the cluster failed:
>
> ERROR in /root/impala/bin/create-test-configuration.sh at line 204: CLASSPATH={$CLASSPATH}:${CONFIG_DIR} ${HIVE_HOME}/bin/schematool -initSchema -dbType \
> Generated: /root/impala/logs/extra_junit_xml_logs/generate_junitxml.buildall.create-test-configuration.20251118_03_23_26.xml
>
> Checked logs/cluster/schematool.log,
>
> Metastore connection URL: jdbc:postgresql://localhost:5432/HMS_root_impala_apache
> Metastore Connection Driver : org.postgresql.Driver
> Metastore connection User: hiveuser
> org.apache.hadoop.hive.metastore.HiveMetaException: Failed to get schema version.
> Underlying cause: org.postgresql.util.PSQLException : The authentication type 10 is not supported. Check that you have configured the pg_hba.conf file to include the client's IP address or subnet, and that it is using an authentication scheme supported by the driver.
> SQL Error code: 0
> Use --verbose for detailed stacktrace.
> *** schemaTool failed ***
>
> It seems we need to upgrade the PostgreSQL JDBC Driver used by Apache Hive 2.
I can work around the issue by removing the old pg driver and put a new one in $HIVE_HOME/
rm toolchain/apache_components/apache-hive-2.3.9-bin/lib/postgresql-9.4.1208.jre7.jar
mkdir toolchain/apache_components/apache-hive-2.3.9-bin/auxlib
cp fe/target/dependency/postgresql-42.5.6.jar toolchain/apache_components/apache-hive-2.3.9-bin/auxlib
Then the cluster can be set up correctly. However, when launching impala, impalad and catalogd failed by
I20251117 19:56:52.377930 52764 jni-util.cc:321] java.lang.NoClassDefFoundError: org/apache/hadoop/hive/metastore/api/Database
at org.apache.impala.catalog.BuiltinsDb.createMetastoreDb(BuiltinsDb.java:126)
at org.apache.impala.catalog.BuiltinsDb.<init>(BuiltinsDb.java:94)
at org.apache.impala.catalog.BuiltinsDb.getInstance(BuiltinsDb.java:81)
at org.apache.impala.analysis.SqlScanner.init(SqlScanner.java:772)
at org.apache.impala.analysis.SqlScanner.<clinit>(SqlScanner.java:789)
at org.apache.impala.service.BackendConfig.create(BackendConfig.java:60)
at org.apache.impala.service.BackendConfig.create(BackendConfig.java:53)
at org.apache.impala.service.JniCatalog.<init>(JniCatalog.java:142)
Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hive.metastore.api.Database
at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
... 8 more
http://gerrit.cloudera.org:8080/#/c/21760/111/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:
http://gerrit.cloudera.org:8080/#/c/21760/111/bin/create-test-configuration.sh@204
PS111, Line 204: {$CLASSPATH}
I think this is a typo. It should be ${CLASSPATH}. But it seems the CLASSPATH variable is not used by schematool at all. The script creates its own CLASSPATH variable.
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 111
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 03:58:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12349: Support Apache Hive 2.x in Impala
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala
......................................................................
Patch Set 119: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c
Gerrit-Change-Number: 21760
Gerrit-PatchSet: 119
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 31 Dec 2025 01:50:22 +0000
Gerrit-HasComments: No