You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2020/04/17 04:30:00 UTC
[jira] [Commented] (YUNIKORN-98) Metric enablement check is broken
[ https://issues.apache.org/jira/browse/YUNIKORN-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085426#comment-17085426 ]
Wilfred Spiegelenburg commented on YUNIKORN-98:
-----------------------------------------------
The response of internal server error (500) is also not correct if metrics are turned off. We should be returning a Not Implemented (501) as a more appropriate value.
As comparison:
* 501 Not Implemented: The server either does not recognise the request method, or it lacks the ability to fulfil the request. Usually this implies future availability (e.g., a new feature of a web-service API)
* 500 Internal Server Error: A generic error message, given when an unexpected condition was encountered and no more specific message is suitable
We have a more specific message as we cannot fulfil the request currently so a 501 is better
> Metric enablement check is broken
> ---------------------------------
>
> Key: YUNIKORN-98
> URL: https://issues.apache.org/jira/browse/YUNIKORN-98
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - common
> Affects Versions: 0.8
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Blocker
>
> With the reflow of the metrics logic in the web interface a check was not changed from {{!=}} to {{==}}.
> This causes the metrics to always be disabled and not show up in the web UI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org