You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Rick Hillegas <Ri...@Sun.COM> on 2005/09/19 21:47:42 UTC

VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

I would like to propose that we include JUnit as part of the required 
toolkit for Derby developers. Going forward, this will allow developers 
to write assertion-based tests. For the moment, this will not change the 
existing test harness.

Re: VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by "Lance J. Andersen" <La...@Sun.COM>.
+1

Jeremy Boynes wrote:

> Rick Hillegas wrote:
>
>> I would like to propose that we include JUnit as part of the required 
>> toolkit for Derby developers. Going forward, this will allow 
>> developers to write assertion-based tests. For the moment, this will 
>> not change the existing test harness.
>>
>
> +1 with the caveat that it works in all the environments we need (and 
> I don't see yet why it won't). JUnit is a well understood harness used 
> by many projects (and support is actually built into Maven).
>
> -- 
> Jeremy


Re: Platforms/jdks on which Derby is tested ( was Re: VOTE:Require JUnit jar to build Derby)

Posted by Kathey Marsden <km...@sbcglobal.net>.
Daniel John Debrunner wrote:

>  
>
>>Rajesh Kartha wrote:
>>
>>    
>>
>>>The list of platform/jdk is now on the Derby wiki at:
>>>
>>>http://wiki.apache.org/db-derby/PlatformTestsDerby
>>>      
>>>
>
>  
>
>>Derby is also tested on IPV6 dual stack windows 2003 and RHEL4.0 with jdk15
>>    
>>
>
>Since the list is now a wiki page, anyone can edit it to add any
>platform combinations they have tested. Sending combinations to
>derby-dev will not get them listed in the wiki page.
>
>  
>
It would be great  to see what version of  Derby has been tested with
those platforms, and special considerations  (e.g. DERBY-1 for Mac,
DERBY-283 for IPV6 dual stack windows),  and maybe even who did the
testing if folks are willing to post that info.

Kathey



Re: Platforms/jdks on which Derby is tested ( was Re: VOTE:Require JUnit jar to build Derby)

Posted by Manjula G Kutty <ma...@gmail.com>.
Daniel John Debrunner wrote:

>Manjula G Kutty wrote:
>
>  
>
>>Rajesh Kartha wrote:
>>
>>    
>>
>>>The list of platform/jdk is now on the Derby wiki at:
>>>
>>>http://wiki.apache.org/db-derby/PlatformTestsDerby
>>>      
>>>
>
>  
>
>>Derby is also tested on IPV6 dual stack windows 2003 and RHEL4.0 with jdk15
>>    
>>
>
>Since the list is now a wiki page, anyone can edit it to add any
>platform combinations they have tested. Sending combinations to
>derby-dev will not get them listed in the wiki page.
>
>Dan.
>
>
>
>  
>
This information is added to the following wiki page
http://wiki.apache.org/db-derby/PlatformTestsDerby

Thanks
Manjula

Re: Platforms/jdks on which Derby is tested ( was Re: VOTE:Require JUnit jar to build Derby)

Posted by Daniel John Debrunner <dj...@debrunners.com>.
Manjula G Kutty wrote:

> Rajesh Kartha wrote:
> 
>> The list of platform/jdk is now on the Derby wiki at:
>>
>> http://wiki.apache.org/db-derby/PlatformTestsDerby

>>
> Derby is also tested on IPV6 dual stack windows 2003 and RHEL4.0 with jdk15

Since the list is now a wiki page, anyone can edit it to add any
platform combinations they have tested. Sending combinations to
derby-dev will not get them listed in the wiki page.

Dan.



Re: Platforms/jdks on which Derby is tested ( was Re: VOTE:Require JUnit jar to build Derby)

Posted by Manjula G Kutty <ma...@gmail.com>.
Rajesh Kartha wrote:

> The list of platform/jdk is now on the Derby wiki at:
>
> http://wiki.apache.org/db-derby/PlatformTestsDerby
>
> Regards,
> Rajesh
>
>
> Rajesh Kartha wrote:
>
>> Daniel John Debrunner wrote:
>>
>>>
>>> I think the caveat is really that any such checkin should not cause a
>>> regression, namely derbyall does run on a number of platforms with its
>>> current set of tests. It would be a regression if a new testing scheme
>>> stopped my current ability to run the *existing* tests on z-series or
>>> any other platform where the tests run today.
>>>
>>> Of course it would be good to document which platforms Derby is running
>>> tests sucessfully on, seems like a good wiki page.
>>>
>>> Dan.
>>>
>>>  
>>>
>> Derby tests are run on a variety of platform/jdk combinations. 
>> Documenting on the db wiki such a list, is a wonderful idea.
>> I have compiled the following list of platforms and jdks where Derby 
>> tests have been successfully run (or being planned)
>> based on the posts to the *derby-dev* mailing list and the current 
>> plans within our group.
>>
>> Please feel free to add to this  if I have missed any platform/jdk 
>> combination.
>>
>> -Rajesh
>>
>> --------------------------------------------------------------------------- 
>>
>> Sun (jdk15) and IBM (Java sdk142) - both:
>> ================================
>>
>>    - Windows 2000
>>    - Windows XP
>>    - Windows 2003 Server
>>    - Windows 2003 Server - 64 bit (in process)
>>    - SLES 9.0
>>    - Suse Pro 9.1
>>    - Suse Pro 9.2
>>    - RHEL 3.0
>>    - RHEL 4.0
>>    - RHEL 4.0 - 64 bit (in process)
>>
>>
>> Sun JDK only
>> ================
>>    jdk15
>>    ------
>>    - SunOS-5.9 (sparc)
>>    - SunOS 5.10 (i386)
>>    - SunOS 5.10 (sparc)
>>    - Windows 2000 CYGWIN (i686)
>>    - Linux-2.4.19-4GB_i686
>>    - Linux-2.4.20-31.9_i686-i686
>>    - Linux-2.4.21-27.ELsmp_i686-athlon
>>    - Linux-2.4.21-27.ELsmp_i686-i686
>>
>> IBM Java SDK only
>> ============
>>    sdk131
>>    ------
>>    AIX 5.2
>>
>>    sdk 142
>>    ------
>>    - AIX 5.2
>>    - Fedora Release 3
>>    - zSeries - zOS v1R6 (in process)
>>    - zSeries - ZLinux (Linux 2.4.19) (planned)
>>    - iSeries - I5/OS v5R3 (planned)
>>    - iSeries - OS/400 v5R2 (planned)
>>
>>    wsdd5.6
>>    --------
>>    - Windows 2000
>>
>>    wctme5.7
>>    --------
>>    - Windows 2000
>>
>> Apple JDK only
>> ===============
>>    jdk142
>>    ------
>>    - Mac OS X 10.4.1
>>    - Mac OS X Server 10.4.1
>>
>> --------------------------------------------------------------------------- 
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
>
>
Derby is also tested on IPV6 dual stack windows 2003 and RHEL4.0 with jdk15

Thanks
Manjula

Re: Platforms/jdks on which Derby is tested ( was Re: VOTE:Require JUnit jar to build Derby)

Posted by Rajesh Kartha <ka...@Source-Zone.Org>.
The list of platform/jdk is now on the Derby wiki at:

http://wiki.apache.org/db-derby/PlatformTestsDerby

Regards,
Rajesh


Rajesh Kartha wrote:

> Daniel John Debrunner wrote:
>
>>
>> I think the caveat is really that any such checkin should not cause a
>> regression, namely derbyall does run on a number of platforms with its
>> current set of tests. It would be a regression if a new testing scheme
>> stopped my current ability to run the *existing* tests on z-series or
>> any other platform where the tests run today.
>>
>> Of course it would be good to document which platforms Derby is running
>> tests sucessfully on, seems like a good wiki page.
>>
>> Dan.
>>
>>  
>>
> Derby tests are run on a variety of platform/jdk combinations. 
> Documenting on the db wiki such a list, is a wonderful idea.
> I have compiled the following list of platforms and jdks where Derby 
> tests have been successfully run (or being planned)
> based on the posts to the *derby-dev* mailing list and the current 
> plans within our group.
>
> Please feel free to add to this  if I have missed any platform/jdk 
> combination.
>
> -Rajesh
>
> --------------------------------------------------------------------------- 
>
> Sun (jdk15) and IBM (Java sdk142) - both:
> ================================
>
>    - Windows 2000
>    - Windows XP
>    - Windows 2003 Server
>    - Windows 2003 Server - 64 bit (in process)
>    - SLES 9.0
>    - Suse Pro 9.1
>    - Suse Pro 9.2
>    - RHEL 3.0
>    - RHEL 4.0
>    - RHEL 4.0 - 64 bit (in process)
>
>
> Sun JDK only
> ================
>    jdk15
>    ------
>    - SunOS-5.9 (sparc)
>    - SunOS 5.10 (i386)
>    - SunOS 5.10 (sparc)
>    - Windows 2000 CYGWIN (i686)
>    - Linux-2.4.19-4GB_i686
>    - Linux-2.4.20-31.9_i686-i686
>    - Linux-2.4.21-27.ELsmp_i686-athlon
>    - Linux-2.4.21-27.ELsmp_i686-i686
>
> IBM Java SDK only
> ============
>    sdk131
>    ------
>    AIX 5.2
>
>    sdk 142
>    ------
>    - AIX 5.2
>    - Fedora Release 3
>    - zSeries - zOS v1R6 (in process)
>    - zSeries - ZLinux (Linux 2.4.19) (planned)
>    - iSeries - I5/OS v5R3 (planned)
>    - iSeries - OS/400 v5R2 (planned)
>
>    wsdd5.6
>    --------
>    - Windows 2000
>
>    wctme5.7
>    --------
>    - Windows 2000
>
> Apple JDK only
> ===============
>    jdk142
>    ------
>    - Mac OS X 10.4.1
>    - Mac OS X Server 10.4.1
>
> --------------------------------------------------------------------------- 
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>



Platforms/jdks on which Derby is tested ( was Re: VOTE:Require JUnit jar to build Derby)

Posted by Rajesh Kartha <ka...@Source-Zone.Org>.
Daniel John Debrunner wrote:

>
>I think the caveat is really that any such checkin should not cause a
>regression, namely derbyall does run on a number of platforms with its
>current set of tests. It would be a regression if a new testing scheme
>stopped my current ability to run the *existing* tests on z-series or
>any other platform where the tests run today.
>
>Of course it would be good to document which platforms Derby is running
>tests sucessfully on, seems like a good wiki page.
>
>Dan.
>
>  
>
Derby tests are run on a variety of platform/jdk combinations. 
Documenting on the db wiki such a list, is a wonderful idea.
I have compiled the following list of platforms and jdks where Derby 
tests have been successfully run (or being planned)
based on the posts to the *derby-dev* mailing list and the current plans 
within our group.

Please feel free to add to this  if I have missed any platform/jdk 
combination.

-Rajesh

---------------------------------------------------------------------------
Sun (jdk15) and IBM (Java sdk142) - both:
================================

    - Windows 2000
    - Windows XP
    - Windows 2003 Server
    - Windows 2003 Server - 64 bit (in process)
    - SLES 9.0
    - Suse Pro 9.1
    - Suse Pro 9.2
    - RHEL 3.0
    - RHEL 4.0
    - RHEL 4.0 - 64 bit (in process)


Sun JDK only
================
    jdk15
    ------
    - SunOS-5.9 (sparc)
    - SunOS 5.10 (i386)
    - SunOS 5.10 (sparc)
    - Windows 2000 CYGWIN (i686)
    - Linux-2.4.19-4GB_i686
    - Linux-2.4.20-31.9_i686-i686
    - Linux-2.4.21-27.ELsmp_i686-athlon
    - Linux-2.4.21-27.ELsmp_i686-i686

IBM Java SDK only
============
    sdk131
    ------
    AIX 5.2

    sdk 142
    ------
    - AIX 5.2
    - Fedora Release 3
    - zSeries - zOS v1R6 (in process)
    - zSeries - ZLinux (Linux 2.4.19) (planned)
    - iSeries - I5/OS v5R3 (planned)
    - iSeries - OS/400 v5R2 (planned)

    wsdd5.6
    --------
    - Windows 2000

    wctme5.7
    --------
    - Windows 2000

Apple JDK only
===============
    jdk142
    ------
    - Mac OS X 10.4.1
    - Mac OS X Server 10.4.1

---------------------------------------------------------------------------


















Re: VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by Daniel John Debrunner <dj...@debrunners.com>.
Jeremy Boynes wrote:

> Rick Hillegas wrote:
> 
>> I would like to propose that we include JUnit as part of the required
>> toolkit for Derby developers. Going forward, this will allow
>> developers to write assertion-based tests. For the moment, this will
>> not change the existing test harness.
>>
> 
> +1 with the caveat that it works in all the environments we need (and I
> don't see yet why it won't). JUnit is a well understood harness used by
> many projects (and support is actually built into Maven).

+1 [to the original proposal]

I'm not so sure that Jeremy's caveat is valid, though I agree it is
strongly desirable. The big question is really who is 'we' in the 'all
environments we need'? I need to run Derby on IBM's z-series, but my
guess is that Rick doesn't. I don't think any Derby patch/commit should
require running tests on all platforms Derby has ever run on, especially
as most people will not have access to them.

I see it as Rick (and others) are providing new tests for Derby, that's
a good thing, even if, as they provided them, they only worked on (say)
Linux and Solaris. It seems better to have the ability to run these
tests to improve/maintain the quality of Derby than not to have them.
If I care about running the new tests on z-series, then that's my itch
to scratch.

I think the caveat is really that any such checkin should not cause a
regression, namely derbyall does run on a number of platforms with its
current set of tests. It would be a regression if a new testing scheme
stopped my current ability to run the *existing* tests on z-series or
any other platform where the tests run today.

Of course it would be good to document which platforms Derby is running
tests sucessfully on, seems like a good wiki page.

Dan.


Re: VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by Jeremy Boynes <jb...@apache.org>.
Rick Hillegas wrote:
> I would like to propose that we include JUnit as part of the required 
> toolkit for Derby developers. Going forward, this will allow developers 
> to write assertion-based tests. For the moment, this will not change the 
> existing test harness.
> 

+1 with the caveat that it works in all the environments we need (and I 
don't see yet why it won't). JUnit is a well understood harness used by 
many projects (and support is actually built into Maven).

--
Jeremy

[RESULT] [VOTE] Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by Rick Hillegas <Ri...@Sun.COM>.
I apologize. My previous posting enclosed RESULT in curly braces rather 
than boxy braces. Hopefully this vote result is now correctly and 
durably recorded.

Thanks,
-Rick

Rick Hillegas wrote:

> This vote also passed. STATUS.txt has been patched to say this. The 
> patch is attached to my previous message titled "[RESULT] [VOTE] 
> Support the ANSI-SQL standard BOOLEAN datatype."
>
> Cheers,
> -Rick



{RESULT} [VOTE] Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by Rick Hillegas <Ri...@Sun.COM>.
This vote also passed. STATUS.txt has been patched to say this. The 
patch is attached to my previous message titled "[RESULT] [VOTE] Support 
the ANSI-SQL standard BOOLEAN datatype."

Cheers,
-Rick

Re: VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by "Bernt M. Johnsen" <Be...@Sun.COM>.
>>>>> On Sep 19, 2005, at 12:47 PM, Rick Hillegas wrote:
>I would like to propose that we include JUnit as part of the  
>required toolkit for Derby developers. Going forward, this will  
>allow developers to write assertion-based tests. For the moment,  
>this will not change the existing test harness.

+1

-- 
Bernt Marius Johnsen, Database Technology Group, 
Sun Microsystems, Trondheim, Norway

Re: VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by Andrew McIntyre <mc...@gmail.com>.
On Sep 19, 2005, at 12:47 PM, Rick Hillegas wrote:

> I would like to propose that we include JUnit as part of the  
> required toolkit for Derby developers. Going forward, this will  
> allow developers to write assertion-based tests. For the moment,  
> this will not change the existing test harness.

-0

On the grounds that there's no reason to do so, yet. If someone would  
like to start writing Junit tests, there's nothing to stop them from  
doing so. If they contributed them to the codebase, I doubt they  
would be refused. Since we'd need to vote on such a contribution  
anyway, as it involves a change to current policy regarding checkins,  
couldn't we just deal with this when the new test code is contributed?

andrew

Re: VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by Oy...@Sun.COM.
Rick Hillegas wrote:
> I would like to wrap up polling on this proposal by close of business 
> Friday (San Francisco time). So far, no one has voted.
> 
> Thanks,
> -Rick
> 
> Rick Hillegas wrote:
> 
>> I would like to propose that we include JUnit as part of the required 
>> toolkit for Derby developers. Going forward, this will allow 
>> developers to write assertion-based tests. For the moment, this will 
>> not change the existing test harness.

+1

-- 
Oyvind Bakksjo
Sun Microsystems, Database Technology Group
Trondheim, Norway
http://weblogs.java.net/blog/bakksjo/

Re: VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by Rick Hillegas <Ri...@Sun.COM>.
Thanks, Jean, for pointing this out. :)

+1

Jean T. Anderson wrote:

> Rick Hillegas wrote:
>
>> I would like to wrap up polling on this proposal by close of business 
>> Friday (San Francisco time). So far, no one has voted.
>
>
> Clarifying for the list ... although anyone can vote (and should be 
> encouraged to do so), only derby committers have binding votes 
> according to the db project guidelines at 
> http://db.apache.org/decisions.html . However, as I understand these 
> guidelines, Rick may cast a binding vote even though he isn't a 
> committer because he is the contributor proposing the change.
>
> Rick, I didn't spot that you voted.  :-)
>
>  -jean
>
>


Re: VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by Dy...@Sun.COM.
"Jean T. Anderson" <jt...@bristowhill.com> writes:

> Rick Hillegas wrote:
>> I would like to wrap up polling on this proposal by close of
>> business Friday (San Francisco time). So far, no one has voted.
>
> Clarifying for the list ... although anyone can vote (and should be
> encouraged to do so), 

In that case; 
+1

-- 
dt


Re: VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Rick Hillegas wrote:
> I would like to wrap up polling on this proposal by close of business 
> Friday (San Francisco time). So far, no one has voted.

Clarifying for the list ... although anyone can vote (and should be 
encouraged to do so), only derby committers have binding votes according 
to the db project guidelines at http://db.apache.org/decisions.html . 
However, as I understand these guidelines, Rick may cast a binding vote 
even though he isn't a committer because he is the contributor proposing 
the change.

Rick, I didn't spot that you voted.  :-)

  -jean



Re: VOTE: Require JUnit jar to build Derby, was: JUnit license, was: subversion etiquette

Posted by Rick Hillegas <Ri...@Sun.COM>.
I would like to wrap up polling on this proposal by close of business 
Friday (San Francisco time). So far, no one has voted.

Thanks,
-Rick

Rick Hillegas wrote:

> I would like to propose that we include JUnit as part of the required 
> toolkit for Derby developers. Going forward, this will allow 
> developers to write assertion-based tests. For the moment, this will 
> not change the existing test harness.
>
> ------------------------------------------------------------------------
>
> Subject:
> Re: JUnit license, was: subversion etiquette]
> From:
> Rick Hillegas <Ri...@Sun.COM>
> Date:
> Wed, 14 Sep 2005 13:36:37 -0700
> To:
> Derby Development <de...@db.apache.org>
>
> To:
> Derby Development <de...@db.apache.org>
>
>
> Hi Dan,
>
> We briefly discussed this compatiblity test suite late last month on a 
> thread titled "client/server compatibility testing". Here's the 
> essence of that proposal:
>
> o As part of the checkin barrier, derbyall should just test the 
> compatibility suite against a Derby client and server running at the 
> current level on the same jdk version.
> o The full set of combinations can be run on a weekly basis by some 
> authority.
> o The full set of combinations should be run as part of the release 
> barrier.
>
> I was hoping that the first point could be accomplished by some 
> jiggery pokery which ran the compatibility suite under the normal 
> (non-junit) test harness, producing a canon. This wouldn't wrench the 
> existing machinery around too much. However, it would require 
> developers to download the junit jar so that the test class would 
> build and execute...and this may be controversial.
>
> The full compatibility suite (run weekly and before releases) would be 
> a collection of junit test runs--for which no canons would be 
> necessary. It would run under its own small ant- and junit-based 
> harness with its own instructions. I don't regard this harness as a 
> permanent fixture. I am cautiously hopeful that someone will tackle 
> the problem of migrating our existing tests to JUnit; and when they 
> do, my temporary harness can be thrown away and the compatiblity suite 
> can be integrated with the general mechanism. Back in May, an email 
> thread titled "JUnit" discussed the desirability of migrating our 
> tests to the JUnit framework over time. You described your experiments 
> with JUnit and seemed hopeful that this framework would reduce the 
> time it takes to run derbyall.
>
> Other than requiring developers to download the junit jar, I think I 
> am proposing something fairly modest here. However, the camel's snout 
> would be in the tent. With JUnit now visible to Derby developers, 
> momentum might build for someone to attempt the bigger migration. At 
> that point, we probably would have to iron out a lot of controversial 
> issues.
>
> Please help me understand what issues (besides the junit jar 
> requirement) you see in this first, smaller proposal to expose an ant- 
> and junit-based compatibility test suite.
>
> Thanks,
> -Rick
>
> Daniel John Debrunner wrote:
>
>> Rick Hillegas wrote:
>>
>>  
>>
>>> Thanks Jean, David, and Francois for your suggestion that I amend
>>> BUILDING.txt. Now I'm back to an etiquette question: I'm hoping to 
>>> check
>>> in a JUnit assertion-based test. Since the test needs JUnit to 
>>> build, my
>>> patch will break everyone's build: they will have to download the junit
>>> jar themselves. This could annoy a lot of folks. What is the etiquette
>>> for breaking the build this way?
>>>   
>>
>>
>> I think a vote would be needed to accept the patch.
>>
>> Currently Derby's testing policy is its own harness, you seem to be
>> suggesting some change, but it's not clear what.
>>
>> What's the expectation here, that these Junit tests need to be run
>> before any commit, in addition to derbyall? Or that they are separate
>> tests run by those that care to, like the current upgrade tests?
>>
>> If they are required to be run, then are you providing a single command
>> that executes both derbyall and the junit tests?
>>
>> Dan.
>>
>>
>>  
>>
>