You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David Glasser <gl...@davidglasser.net> on 2007/11/12 22:58:45 UTC

Re: svn commit: r27740 - trunk/subversion/libsvn_fs_fs

On Nov 9, 2007 8:55 AM,  <cm...@tigris.org> wrote:
> Author: cmpilato
> Date: Fri Nov  9 08:55:42 2007
> New Revision: 27740
>
> Log:
> * subversion/libsvn_fs_fs/fs_fs.c
>   (with_txn_current_lock): Add 'static' keyword to prevent build warning.

Whoops, good catch.

What warning would that be, though?  (I don't remember seeing one, and
while it would be cool if we could get a warning on non-static
non-svn_* functions, I don't think we have such a project-specific
check...)

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r27740 - trunk/subversion/libsvn_fs_fs

Posted by "C. Michael Pilato" <cm...@collab.net>.
David Glasser wrote:
> On Nov 9, 2007 8:55 AM,  <cm...@tigris.org> wrote:
>> Author: cmpilato
>> Date: Fri Nov  9 08:55:42 2007
>> New Revision: 27740
>>
>> Log:
>> * subversion/libsvn_fs_fs/fs_fs.c
>>   (with_txn_current_lock): Add 'static' keyword to prevent build warning.
> 
> Whoops, good catch.
> 
> What warning would that be, though?  (I don't remember seeing one, and
> while it would be cool if we could get a warning on non-static
> non-svn_* functions, I don't think we have such a project-specific
> check...)

I can't recall exactly, but I think it's something about the function not
having a prototype.  I've got "gcc (GCC) 4.1.3 20070929" with no custom
flags ... dunno what to tell you.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand