You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/02/03 07:17:54 UTC
[GitHub] [spark] itholic opened a new pull request, #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
itholic opened a new pull request, #39872:
URL: https://github.com/apache/spark/pull/39872
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR proposes to assign name to _LEGACY_ERROR_TEMP_2135, "FAILED_PARSE_EMPTY_STRING".
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We should assign proper name to _LEGACY_ERROR_TEMP_*
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
`./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39872:
URL: https://github.com/apache/spark/pull/39872#discussion_r1096431085
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -511,6 +511,12 @@
],
"sqlState" : "38000"
},
+ "FAILED_PARSE_EMPTY_STRING" : {
+ "message" : [
+ "Failed to parse an empty string for data type <dataType>."
+ ],
+ "sqlState" : "42P18"
Review Comment:
Thanks for the correction :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
URL: https://github.com/apache/spark/pull/39872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #39872:
URL: https://github.com/apache/spark/pull/39872#discussion_r1096762646
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -511,6 +511,12 @@
],
"sqlState" : "38000"
},
+ "FAILED_PARSE_EMPTY_STRING" : {
Review Comment:
This error class is pretty JSON specific. So, add JSON in the name. For example:
```suggestion
"EMPTY_JSON_FIELD_VALUE" : {
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -511,6 +511,12 @@
],
"sqlState" : "38000"
},
+ "FAILED_PARSE_EMPTY_STRING" : {
+ "message" : [
+ "Failed to parse an empty string for data type <dataType>."
Review Comment:
Please, tell about the SQL config `spark.sql.legacy.json.allowEmptyString.enabled` to users in the error message.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##########
@@ -2608,11 +2609,12 @@ abstract class JsonSuite
private def failedOnEmptyString(dataType: DataType): Unit = {
val df = spark.read.schema(s"a ${dataType.catalogString}")
.option("mode", "FAILFAST").json(Seq("""{"a":""}""").toDS)
- val errMessage = intercept[SparkException] {
- df.collect()
- }.getMessage
- assert(errMessage.contains(
- s"Failed to parse an empty string for data type ${dataType.catalogString}"))
+ val e = intercept[SparkException] {df.collect()}
+ checkError(
+ exception = e.getCause.getCause.getCause.asInstanceOf[SparkRuntimeException],
+ errorClass = "FAILED_PARSE_EMPTY_STRING",
+ parameters = Map("dataType" -> s"${toSQLType(dataType)}")
Review Comment:
nit:
```suggestion
parameters = Map("dataType" -> toSQLType(dataType))
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -1433,9 +1433,9 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase {
def failToParseEmptyStringForDataTypeError(dataType: DataType): SparkRuntimeException = {
new SparkRuntimeException(
- errorClass = "_LEGACY_ERROR_TEMP_2135",
+ errorClass = "FAILED_PARSE_EMPTY_STRING",
messageParameters = Map(
- "dataType" -> dataType.catalogString))
+ "dataType" -> toSQLType(dataType)))
Review Comment:
```scala
messageParameters = Map("dataType" -> toSQLType(dataType)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #39872:
URL: https://github.com/apache/spark/pull/39872#discussion_r1096792128
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -511,6 +511,12 @@
],
"sqlState" : "38000"
},
+ "FAILED_PARSE_EMPTY_STRING" : {
+ "message" : [
+ "Failed to parse an empty string for data type <dataType>."
Review Comment:
I'm conflicted about this. If something is LEGACY, then shouldn't it only apply to existing use cases.
Should we really advertise such configs?
On second thought, I'm not conflicted at all, FWIW I vote to NOT refer to legacy configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #39872:
URL: https://github.com/apache/spark/pull/39872#discussion_r1096801808
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -511,6 +511,12 @@
],
"sqlState" : "38000"
},
+ "FAILED_PARSE_EMPTY_STRING" : {
+ "message" : [
+ "Failed to parse an empty string for data type <dataType>."
Review Comment:
ahh, I missed that it is a legacy config. I agree to don't advertise it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39872:
URL: https://github.com/apache/spark/pull/39872#issuecomment-1418304816
Updated the comments, thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39872:
URL: https://github.com/apache/spark/pull/39872#issuecomment-1415352090
cc @srielau @MaxGekk @cloud-fan Please review this error class when you find some time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #39872:
URL: https://github.com/apache/spark/pull/39872#discussion_r1095922911
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -511,6 +511,12 @@
],
"sqlState" : "38000"
},
+ "FAILED_PARSE_EMPTY_STRING" : {
+ "message" : [
+ "Failed to parse an empty string for data type <dataType>."
+ ],
+ "sqlState" : "42P18"
Review Comment:
```suggestion
"sqlState" : "42604"
```
We do know the data type. It's the literal we can't handle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39872: [SPARK-42302][SQL] Assign name to _LEGACY_ERROR_TEMP_2135
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #39872:
URL: https://github.com/apache/spark/pull/39872#issuecomment-1418883290
+1, LGTM. Merging to master/3.4.
Thank you, @itholic and @srielau for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org