You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Ryan McKinley (JIRA)" <ji...@apache.org> on 2007/12/21 00:19:43 UTC

[jira] Created: (SOLR-442) FileFloatSource should read file from dataDir, not indexDir

FileFloatSource should read file from dataDir, not indexDir
-----------------------------------------------------------

                 Key: SOLR-442
                 URL: https://issues.apache.org/jira/browse/SOLR-442
             Project: Solr
          Issue Type: Improvement
          Components: search
    Affects Versions: 1.3
            Reporter: Ryan McKinley
            Priority: Minor
             Fix For: 1.3


The FileFloatSource currently loads its file from the indexDir:

parser.getReq().getCore().getIndexDir()

This is a problem for an empty index since you get a FileNotFoundException.  

Rather then using indexDir, this should use getDataDir()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-442) FileFloatSource should read file from dataDir, not indexDir

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-442:
-------------------------------

    Attachment: SOLR-442-UseDataDir.patch

change indexDir to dataDir

> FileFloatSource should read file from dataDir, not indexDir
> -----------------------------------------------------------
>
>                 Key: SOLR-442
>                 URL: https://issues.apache.org/jira/browse/SOLR-442
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-442-UseDataDir.patch
>
>
> The FileFloatSource currently loads its file from the indexDir:
> parser.getReq().getCore().getIndexDir()
> This is a problem for an empty index since you get a FileNotFoundException.  
> Rather then using indexDir, this should use getDataDir()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-442) FileFloatSource should read file from dataDir, not indexDir

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553840 ] 

Yonik Seeley commented on SOLR-442:
-----------------------------------

+1

If one wants the file in the index directory they can specify index/filename
Does that actually work with the current code (I know I wrote it, but I really don't recall)?
Perhaps the test schema should be changed to verify.



> FileFloatSource should read file from dataDir, not indexDir
> -----------------------------------------------------------
>
>                 Key: SOLR-442
>                 URL: https://issues.apache.org/jira/browse/SOLR-442
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-442-UseDataDir.patch
>
>
> The FileFloatSource currently loads its file from the indexDir:
> parser.getReq().getCore().getIndexDir()
> This is a problem for an empty index since you get a FileNotFoundException.  
> Rather then using indexDir, this should use getDataDir()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-442) FileFloatSource should read file from dataDir, not indexDir

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley resolved SOLR-442.
--------------------------------

    Resolution: Fixed
      Assignee: Ryan McKinley

commited.  The test creates a file on the fly... (there isn't an example using FileFloatSource)

> FileFloatSource should read file from dataDir, not indexDir
> -----------------------------------------------------------
>
>                 Key: SOLR-442
>                 URL: https://issues.apache.org/jira/browse/SOLR-442
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-442-UseDataDir.patch
>
>
> The FileFloatSource currently loads its file from the indexDir:
> parser.getReq().getCore().getIndexDir()
> This is a problem for an empty index since you get a FileNotFoundException.  
> Rather then using indexDir, this should use getDataDir()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-442) FileFloatSource should read file from dataDir, not indexDir

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553844 ] 

Yonik Seeley commented on SOLR-442:
-----------------------------------

Ahhh, I had forgotten that the filename is derived from the fieldname.
So if the field is named x, the file will be named external_x

We should make the prefix configurable, so hopefully one would be able to set it to index/external_
if they want those files in the index directory.  The issue is that today, replication only takes a snapshot
of the index directory, so some people will have to use that until it's fixed.



> FileFloatSource should read file from dataDir, not indexDir
> -----------------------------------------------------------
>
>                 Key: SOLR-442
>                 URL: https://issues.apache.org/jira/browse/SOLR-442
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-442-UseDataDir.patch
>
>
> The FileFloatSource currently loads its file from the indexDir:
> parser.getReq().getCore().getIndexDir()
> This is a problem for an empty index since you get a FileNotFoundException.  
> Rather then using indexDir, this should use getDataDir()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.