You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2023/04/01 00:04:18 UTC
[kudu-CR] KUDU-1945 Update auto incrementing counter during bootstrap
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19445 )
Change subject: KUDU-1945 Update auto incrementing counter during bootstrap
......................................................................
Patch Set 14:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19445/14/src/kudu/integration-tests/auto_incrementing-itest.cc
File src/kudu/integration-tests/auto_incrementing-itest.cc:
http://gerrit.cloudera.org:8080/#/c/19445/14/src/kudu/integration-tests/auto_incrementing-itest.cc@306
PS14, Line 306: // There could still be a WAL entry with a DELETE OP.
: // This might cause the auto incrementing counter to be not set to 0 unless
: // FlushDeltaMRS is called. We restart servers to force elections which in turn
: // writes more WAL entries which causes these flushes.
> Wait, does it mean that in the wild we could end up in diverging counters f
Yes, but since there would be only one leader at a given point of time, the next insert ops would receive either 0 or 200 (in this case) depending on which replica is the leader. There is not guarantee but there would be holes in the counter keyspace.
http://gerrit.cloudera.org:8080/#/c/19445/14/src/kudu/integration-tests/auto_incrementing-itest.cc@311
PS14, Line 311:
> nit: remove an extra space
Done
--
To view, visit http://gerrit.cloudera.org:8080/19445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b305efd7d5a065a2976327567163956c0c2184
Gerrit-Change-Number: 19445
Gerrit-PatchSet: 14
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 01 Apr 2023 00:04:18 +0000
Gerrit-HasComments: Yes