You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "mxsm (via GitHub)" <gi...@apache.org> on 2023/01/30 13:38:46 UTC
[GitHub] [rocketmq] mxsm opened a new pull request, #5957: [ISSUE #5952]Fixed repeatedly adding system topics to SYSTEM_TOPIC_SET
mxsm opened a new pull request, #5957:
URL: https://github.com/apache/rocketmq/pull/5957
**Make sure set the target branch to `develop`**
## What is the purpose of the change
close #5952
## Brief changelog
- Fixed repeatedly adding system topics to SYSTEM_TOPIC_SET
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mxsm commented on pull request #5957: [ISSUE #5952]Fixed repeatedly adding system topics to SYSTEM_TOPIC_SET
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #5957:
URL: https://github.com/apache/rocketmq/pull/5957#issuecomment-1409657484
> This optimization does not make much sense. In the same constructor, some use `addSystemTopic` and some don't call it, which leads to troublesome understanding instead.
Hi @echooymxq IMO,It's not that it's not added to the collection, it's already added. You don't have to repeat the work just to reinforce understanding. Understanding the code will reveal that the system topics have already been added to the collection in the static code block of the TopicValidator. I think the code should be kept as simple and concise as possible to minimize repetitive code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on a diff in pull request #5957: [ISSUE #5952]Fixed repeatedly adding system topics to SYSTEM_TOPIC_SET
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on code in PR #5957:
URL: https://github.com/apache/rocketmq/pull/5957#discussion_r1091610035
##########
broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java:
##########
@@ -68,7 +68,6 @@ public TopicConfigManager(BrokerController brokerController) {
{
String topic = TopicValidator.RMQ_SYS_SELF_TEST_TOPIC;
TopicConfig topicConfig = new TopicConfig(topic);
- TopicValidator.addSystemTopic(topic);
Review Comment:
Removing this line could lead to misunderstanding. The person who adds the system topic next time maybe forget to add it to the system topic list in TopicValidator. I suggest adding a default logic to scan all system topics and add them to TopicValidator after initiating TopicConfigManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #5952]Fixed repeatedly adding system topics to SYSTEM_TOPIC_SET [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5957:
URL: https://github.com/apache/rocketmq/pull/5957#issuecomment-1936758039
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #5952]Fixed repeatedly adding system topics to SYSTEM_TOPIC_SET [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5957: [ISSUE #5952]Fixed repeatedly adding system topics to SYSTEM_TOPIC_SET
URL: https://github.com/apache/rocketmq/pull/5957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #5952]Fixed repeatedly adding system topics to SYSTEM_TOPIC_SET [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5957:
URL: https://github.com/apache/rocketmq/pull/5957#issuecomment-1930989671
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org