Re: Getting FDB work onto master

[Joan Touzet <wo...@apache.org>]

Restarting this thread.

Can I get an update on where things are at?

On 31/03/2020 13:13, Paul Davis wrote:
> There are a few other bits to `make check` that aren't included in
> `make check-fdb`. Updating `make check` should just be a matter of
> taking our test subset and applying them to `make check`.
> 
> On Tue, Mar 31, 2020 at 11:04 AM Garren Smith <ga...@apache.org> wrote:
>>
>> On the fdb branch we have a make check-fdb which is a subset of all the
>> tests that should pass. I think we should use that instead of make check
>>
>> On Tue, Mar 31, 2020 at 5:34 PM Joan Touzet <wo...@apache.org> wrote:
>>
>>> Took a bit longer than expected, but it's been tested & validated, and
>>> then re-pushed. I'll push up the other platforms as well (except for
>>> CentOS 8, which still has a broken Python dependency).
>>>
>>> PR for the changes necessary was also merged to couchdb-ci.
>>>
>>> FDB should feel free to merge to master once `make check` is working.
>>>
>>> We can hammer out the wide matrix issues on a slower timeframe.
>>>
>>> -Joan
>>>
>>> On 2020-03-30 19:42, Joan Touzet wrote:
>>>> OOPS, looks like I pushed the wrong image.
>>>>
>>>> I'll build the kerl-based version of the image and re-push. This will
>>>> take a couple of hours, since I have to build 3x Erlangs from source.
>>>>
>>>> Good to know step 1 works! Next step for y'all: fix `make check`.
>>>>
>>>> -Joan
>>>>
>>>> On 2020-03-30 6:05 p.m., Robert Samuel Newson wrote:
>>>>> noting that
>>>>>
>>> https://ci-couchdb.apache.org/blue/organizations/jenkins/jenkins-cm1%2FPullRequests/detail/PR-2732/7/pipeline/
>>>>> now fails because kerl isn't there. related?
>>>>>
>>>>> B.
>>>>>
>>>>>> On 30 Mar 2020, at 22:11, Robert Samuel Newson <rn...@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>> Nice, make check-fdb passes for me on that branch (the 2nd time, the
>>>>>> 1st time was a spurious failure, timing related).
>>>>>>
>>>>>> B.
>>>>>>
>>>>>>> On 30 Mar 2020, at 22:04, Robert Samuel Newson <rn...@apache.org>
>>>>>>> wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Great timing, I merged something to prototype/fdb-layer without the
>>>>>>> check passing, I'm trying this now.
>>>>>>>
>>>>>>> First note, the kerl line doesn't work but it seems there's a system
>>>>>>> wide erlang 20 install instead.
>>>>>>>
>>>>>>> B.
>>>>>>>
>>>>>>>> On 30 Mar 2020, at 19:50, Joan Touzet <wo...@apache.org> wrote:
>>>>>>>>
>>>>>>>> Hi everyone, hope you're all staying at home[1].
>>>>>>>>
>>>>>>>> I've just pushed out a new version of our
>>>>>>>> couchdbdev/debian-buster-erlang-all Docker image. This now includes
>>>>>>>> the fdb binaries, as well as client libraries and headers. This is
>>>>>>>> a necessary (but not sufficient) step to getting the fdb prototype
>>>>>>>> merged to master.
>>>>>>>>
>>>>>>>> Can someone please test if this works correctly for them to build
>>>>>>>> and test CouchDB (with fdb)?
>>>>>>>>
>>>>>>>> Here's instructions:
>>>>>>>>
>>>>>>>> docker pull couchdbdev/debian-buster-erlang-all
>>>>>>>> docker run -it couchdbdev/debian-buster-erlang-all
>>>>>>>> # then, inside the image:
>>>>>>>> cd
>>>>>>>> git clone https://github.com/apache/couchdb
>>>>>>>> cd couchdb && git checkout <whatever branch you want>
>>>>>>>> . /usr/local/kerl/20.3.8.25/activate
>>>>>>>> # you still need to fix make check, but Paul says this should work:
>>>>>>>> make check-fdb
>>>>>>>>
>>>>>>>> The next step would be to fix `make check`. Then, you can merge the
>>>>>>>> fdb branch to master.
>>>>>>>>
>>>>>>>> CI on master will be broken after fdb merge until we get answers to
>>>>>>>> these questions: [2].
>>>>>>>>
>>>>>>>> **REMEMBER**: Any 3.x fixes should land on the 3.x branch at this
>>>>>>>> point. If they're backend specific, there's no need for them to
>>>>>>>> land on master anymore.
>>>>>>>>
>>>>>>>> **QUESTION**: Now that we have a new feature (JWT), it's likely the
>>>>>>>> next CouchDB release would be 3.1.0 - so, probably no need to land
>>>>>>>> more fixes on 3.0.x at this point. Does everyone agree?
>>>>>>>>
>>>>>>>> -Joan "I miss restaurants" Touzet
>>>>>>>>
>>>>>>>> [1]: https://www.youtube.com/watch?v=rORMGH0jE2I
>>>>>>>> [2]:
>>> https://forums.foundationdb.org/t/package-download-questions/2037
>>>>>>>
>>>>>>
>>>>>
>>>