You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "askoa (via GitHub)" <gi...@apache.org> on 2023/02/22 13:58:13 UTC

[GitHub] [arrow-rs] askoa opened a new issue, #3747: Implement logical comparison for run encoded array

askoa opened a new issue, #3747:
URL: https://github.com/apache/arrow-rs/issues/3747

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   Part of #3520 
   
   The equals method for run encoded array implemented in the PR #3662 is incomplete as it compares only the underlying physical arrays.
   
   **Describe the solution you'd like**
   Implement a logical comparison for run encoded arrays. Update the below `run_equal` method to do a full logical comparison.
   
   https://github.com/apache/arrow-rs/blob/61ea9f226dbc90ed989722b5b534cfeaf33e01be/arrow-data/src/equal/run.rs#L22-L32
   
   **Describe alternatives you've considered**
   We cannot do it.
   
   **Additional context**
   Implementing a full logical comparison in `arrow-data` create would be somewhat challenging as the crate does not depend on `arrow-array`. The `arrow-array` crate has functions that are useful to parse `run_ends` in run encoded array. Either `arrow-array` has to be added as dependency for `arrow-data` or some of the code in `arrow-array` has to be duplicated in `arrow-data`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on issue #3747: Implement logical comparison for run encoded array

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #3747:
URL: https://github.com/apache/arrow-rs/issues/3747#issuecomment-1441456757

   I suspect #1799 may provide a solution to this, as it will push the "array" logic lower into arrow-data


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org