You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/22 19:07:33 UTC

[GitHub] [superset] betodealmeida opened a new pull request #15843: feat: apply post processing to chart data

betodealmeida opened a new pull request #15843:
URL: https://github.com/apache/superset/pull/15843


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This PR introduces a new `ChartDataResultType`, `ChartDataResultType.POST_PROCESSED`. It allows us to request the data for a given chart post-processed in the same way the visualization does in Javascript.
   
   Eg, for this pivot table:
   
   ![Screenshot 2021-07-22 at 12-00-06  DEV  Pivot Table](https://user-images.githubusercontent.com/1534870/126694587-791beb7a-fcd6-40cd-aa0a-f8acfd720feb.png)
   
   If we request the data for the chart we get the pre-processed (**unpivoted**) data.
   
   Doing a `GET` on "http://localhost:9000/api/v1/chart/72/data/?format=json" returns:
   
   ```json
   {
     "result": [
       {
         "cache_key": "d432a37512f63a88562744f4da62021e",
         "cached_dttm": null,
         "cache_timeout": 86400,
         "annotation_data": {},
         "error": null,
         "is_cached": false,
         "query": "SELECT gender AS gender,\n       state AS state,\n       sum(num) AS \"Births\"\nFROM birth_names\nWHERE ds >= TO_TIMESTAMP('1921-07-22 00:00:00.000000', 'YYYY-MM-DD HH24:MI:SS.US')\n  AND ds < TO_TIMESTAMP('2021-07-22 11:56:04.000000', 'YYYY-MM-DD HH24:MI:SS.US')\nGROUP BY gender,\n         state\nLIMIT 100",
         "status": "success",
         "stacktrace": null,
         "rowcount": 22,
         "colnames": [
           "gender",
           "state",
           "Births"
         ],
         "coltypes": [
           1,
           1,
           0
         ],
         "data": [
           {
             "gender": "boy",
             "state": "PA",
             "Births": 2390275
           },
           {
             "gender": "girl",
             "state": "PA",
             "Births": 1615383
           },
           {
             "gender": "boy",
             "state": "OH",
             "Births": 2376385
           },
           {
             "gender": "girl",
             "state": "MI",
             "Births": 1326229
           },
           {
             "gender": "girl",
             "state": "FL",
             "Births": 1312593
           },
           {
             "gender": "boy",
             "state": "CA",
             "Births": 5430796
           },
           {
             "gender": "boy",
             "state": "other",
             "Births": 22044909
           },
           {
             "gender": "girl",
             "state": "OH",
             "Births": 1622814
           },
           {
             "gender": "girl",
             "state": "TX",
             "Births": 2313186
           },
           {
             "gender": "boy",
             "state": "NY",
             "Births": 3543961
           },
           {
             "gender": "boy",
             "state": "IL",
             "Births": 2357411
           },
           {
             "gender": "girl",
             "state": "CA",
             "Births": 3567754
           },
           {
             "gender": "girl",
             "state": "NY",
             "Births": 2280733
           },
           {
             "gender": "girl",
             "state": "IL",
             "Births": 1614427
           },
           {
             "gender": "girl",
             "state": "other",
             "Births": 15058341
           },
           {
             "gender": "boy",
             "state": "TX",
             "Births": 3311985
           },
           {
             "gender": "boy",
             "state": "FL",
             "Births": 1968060
           },
           {
             "gender": "boy",
             "state": "MA",
             "Births": 1285126
           },
           {
             "gender": "boy",
             "state": "MI",
             "Births": 1938321
           },
           {
             "gender": "boy",
             "state": "NJ",
             "Births": 1486126
           },
           {
             "gender": "girl",
             "state": "NJ",
             "Births": 992702
           },
           {
             "gender": "girl",
             "state": "MA",
             "Births": 842146
           }
         ],
         "applied_filters": [],
         "rejected_filters": []
       }
     ]
   }
   ```
   
   Note that the results above have 22 rows and 3 columns: "gender", "state", and "Birth" (the metric).
   
   With this PR we can do a `GET` request to "http://localhost:9000/api/v1/chart/72/data/?format=json&type=post_processed" to get:
   
   ```json
   {
     "result": [
       {
         "cache_key": "d432a37512f63a88562744f4da62021e",
         "cached_dttm": null,
         "cache_timeout": 86400,
         "annotation_data": {},
         "error": null,
         "is_cached": false,
         "query": "SELECT gender AS gender,\n       state AS state,\n       sum(num) AS \"Births\"\nFROM birth_names\nWHERE ds >= TO_TIMESTAMP('1921-07-22 00:00:00.000000', 'YYYY-MM-DD HH24:MI:SS.US')\n  AND ds < TO_TIMESTAMP('2021-07-22 12:03:21.000000', 'YYYY-MM-DD HH24:MI:SS.US')\nGROUP BY gender,\n         state\nLIMIT 100",
         "status": "success",
         "stacktrace": null,
         "rowcount": 3,
         "colnames": [
           "Births CA",
           "Births FL",
           "Births IL",
           "Births MA",
           "Births MI",
           "Births NJ",
           "Births NY",
           "Births OH",
           "Births PA",
           "Births TX",
           "Births other",
           "Births All"
         ],
         "coltypes": [
           0,
           0,
           0,
           0,
           0,
           0,
           0,
           0,
           0,
           0,
           0,
           0
         ],
         "data": [
           {
             "Births CA": 5430796,
             "Births FL": 1968060,
             "Births IL": 2357411,
             "Births MA": 1285126,
             "Births MI": 1938321,
             "Births NJ": 1486126,
             "Births NY": 3543961,
             "Births OH": 2376385,
             "Births PA": 2390275,
             "Births TX": 3311985,
             "Births other": 22044909,
             "Births All": 22044909,
             "gender": "boy"
           },
           {
             "Births CA": 3567754,
             "Births FL": 1312593,
             "Births IL": 1614427,
             "Births MA": 842146,
             "Births MI": 1326229,
             "Births NJ": 992702,
             "Births NY": 2280733,
             "Births OH": 1622814,
             "Births PA": 1615383,
             "Births TX": 2313186,
             "Births other": 15058341,
             "Births All": 15058341,
             "gender": "girl"
           },
           {
             "Births CA": 5430796,
             "Births FL": 1968060,
             "Births IL": 2357411,
             "Births MA": 1285126,
             "Births MI": 1938321,
             "Births NJ": 1486126,
             "Births NY": 3543961,
             "Births OH": 2376385,
             "Births PA": 2390275,
             "Births TX": 3311985,
             "Births other": 22044909,
             "Births All": 22044909,
             "gender": "All"
           }
         ],
         "applied_filters": [],
         "rejected_filters": []
       }
     ]
   }
   ```
   
   Note that we now get the correct results, with 3 rows and many columns from the pivot.
   
   This functionality was added to support a very small subset of visualization types:
   
   1. Pivot tables (v1)
   2. Pivot tables (v2)
   3. T-test tables
   
   Because of the small number of visualization types, I opted to do this by reimplementing the chart logic in Python. The alternative would be to run the visualization under Selenium and scrape the data, which is inefficient and still requires keeping the scraping logic up-to-date with the plugins.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   Create and save a pivot chart (not v2). Check the data at "http://localhost:9000/api/v1/chart/{chartid}/data/?format=json&type=post_processed" and "http://localhost:9000/api/v1/chart/{chartid}/data/?format=json&type=full".
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] betodealmeida commented on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-886909428


   Merging this even if it's not the ideal solution, since it's blocking some important work. Let's talk about this on the next meetup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-885241170


   # [Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#15843](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c0e5756) into [master](https://codecov.io/gh/apache/superset/commit/f6fe29db87424356c3f12d48406a76f813ce4366?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6fe29d) will **decrease** coverage by `0.25%`.
   > The diff coverage is `55.18%`.
   
   > :exclamation: Current head c0e5756 differs from pull request most recent head f13c307. Consider uploading reports for the commit f13c307 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/15843/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #15843      +/-   ##
   ==========================================
   - Coverage   77.13%   76.88%   -0.26%     
   ==========================================
     Files         984      985       +1     
     Lines       51706    51840     +134     
     Branches     6995     7037      +42     
   ==========================================
   - Hits        39882    39855      -27     
   - Misses      11600    11760     +160     
   - Partials      224      225       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `?` | |
   | postgres | `81.43% <28.81%> (-0.13%)` | :arrow_down: |
   | presto | `81.19% <28.81%> (-0.11%)` | :arrow_down: |
   | python | `81.68% <28.81%> (-0.41%)` | :arrow_down: |
   | sqlite | `81.09% <28.81%> (-0.11%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `66.42% <0.00%> (-0.97%)` | :arrow_down: |
   | [...nfigModal/FiltersConfigForm/getControlItemsMap.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL2dldENvbnRyb2xJdGVtc01hcC50c3g=) | `87.50% <ø> (+1.53%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/injectCustomCss.ts](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2luamVjdEN1c3RvbUNzcy50cw==) | `87.50% <0.00%> (ø)` | |
   | [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `61.70% <ø> (ø)` | |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `81.00% <ø> (+2.15%)` | :arrow_up: |
   | [superset/common/query\_actions.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2FjdGlvbnMucHk=) | `92.85% <ø> (ø)` | |
   | [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `93.18% <ø> (ø)` | |
   | [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.86% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.78% <0.00%> (-0.28%)` | :arrow_down: |
   | [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `78.12% <11.11%> (-6.15%)` | :arrow_down: |
   | ... and [47 more](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f6fe29d...f13c307](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] PowerPlop commented on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
PowerPlop commented on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-919915308


   @betodealmeida  using this option on a pivot table v2 that has 'number' fields and using the CSV format, gives me the following error:
   
   `{"errors": [{"message": "No objects to concatenate", "error_type": "GENERIC_BACKEND_ERROR", "level": "error", "extra": {"issue_codes": [{"code": 1011, "message": "Issue 1011 - Superset encountered an unexpected error."}]}}]}`
   
   When selecting json format, it works fine.
   
   
   Removing the number fields seems to fix the issue. Is this a known problem/limitation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-885241170


   # [Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#15843](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a9eb99) into [master](https://codecov.io/gh/apache/superset/commit/f6fe29db87424356c3f12d48406a76f813ce4366?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6fe29d) will **decrease** coverage by `0.28%`.
   > The diff coverage is `56.90%`.
   
   > :exclamation: Current head 4a9eb99 differs from pull request most recent head f13c307. Consider uploading reports for the commit f13c307 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/15843/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #15843      +/-   ##
   ==========================================
   - Coverage   77.13%   76.84%   -0.29%     
   ==========================================
     Files         984      985       +1     
     Lines       51706    51845     +139     
     Branches     6995     7028      +33     
   ==========================================
   - Hits        39882    39840      -42     
   - Misses      11600    11780     +180     
   - Partials      224      225       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `81.42% <29.09%> (-0.11%)` | :arrow_down: |
   | postgres | `81.44% <29.09%> (-0.11%)` | :arrow_down: |
   | presto | `?` | |
   | python | `81.53% <29.09%> (-0.56%)` | :arrow_down: |
   | sqlite | `81.08% <29.09%> (-0.11%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `66.42% <0.00%> (-0.97%)` | :arrow_down: |
   | [...nfigModal/FiltersConfigForm/getControlItemsMap.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL2dldENvbnRyb2xJdGVtc01hcC50c3g=) | `87.50% <ø> (+1.53%)` | :arrow_up: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `81.00% <ø> (+2.15%)` | :arrow_up: |
   | [superset/common/query\_actions.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2FjdGlvbnMucHk=) | `92.85% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.24% <ø> (ø)` | |
   | [superset/charts/post\_processing.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3Bvc3RfcHJvY2Vzc2luZy5weQ==) | `14.63% <14.63%> (ø)` | |
   | [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `41.48% <16.66%> (-2.97%)` | :arrow_down: |
   | [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `25.00% <50.00%> (+4.16%)` | :arrow_up: |
   | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `74.34% <61.53%> (+0.58%)` | :arrow_up: |
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `72.83% <63.63%> (-5.11%)` | :arrow_down: |
   | ... and [29 more](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f6fe29d...f13c307](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-885241170


   # [Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#15843](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a9eb99) into [master](https://codecov.io/gh/apache/superset/commit/f6fe29db87424356c3f12d48406a76f813ce4366?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6fe29d) will **decrease** coverage by `0.28%`.
   > The diff coverage is `56.90%`.
   
   > :exclamation: Current head 4a9eb99 differs from pull request most recent head 8853675. Consider uploading reports for the commit 8853675 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/15843/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #15843      +/-   ##
   ==========================================
   - Coverage   77.13%   76.84%   -0.29%     
   ==========================================
     Files         984      985       +1     
     Lines       51706    51845     +139     
     Branches     6995     7028      +33     
   ==========================================
   - Hits        39882    39840      -42     
   - Misses      11600    11780     +180     
   - Partials      224      225       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `81.42% <29.09%> (-0.11%)` | :arrow_down: |
   | postgres | `81.44% <29.09%> (-0.11%)` | :arrow_down: |
   | presto | `?` | |
   | python | `81.53% <29.09%> (-0.56%)` | :arrow_down: |
   | sqlite | `81.08% <29.09%> (-0.11%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `66.42% <0.00%> (-0.97%)` | :arrow_down: |
   | [...nfigModal/FiltersConfigForm/getControlItemsMap.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL2dldENvbnRyb2xJdGVtc01hcC50c3g=) | `87.50% <ø> (+1.53%)` | :arrow_up: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `81.00% <ø> (+2.15%)` | :arrow_up: |
   | [superset/common/query\_actions.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2FjdGlvbnMucHk=) | `92.85% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.24% <ø> (ø)` | |
   | [superset/charts/post\_processing.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3Bvc3RfcHJvY2Vzc2luZy5weQ==) | `14.63% <14.63%> (ø)` | |
   | [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `41.48% <16.66%> (-2.97%)` | :arrow_down: |
   | [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `25.00% <50.00%> (+4.16%)` | :arrow_up: |
   | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `74.34% <61.53%> (+0.58%)` | :arrow_up: |
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `72.83% <63.63%> (-5.11%)` | :arrow_down: |
   | ... and [29 more](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f6fe29d...8853675](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] PowerPlop commented on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
PowerPlop commented on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-924633125


   @betodealmeida I see it was fixed in https://github.com/apache/superset/pull/16259. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-885241170


   # [Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#15843](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a9eb99) into [master](https://codecov.io/gh/apache/superset/commit/f6fe29db87424356c3f12d48406a76f813ce4366?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6fe29d) will **decrease** coverage by `0.31%`.
   > The diff coverage is `56.90%`.
   
   > :exclamation: Current head 4a9eb99 differs from pull request most recent head 8853675. Consider uploading reports for the commit 8853675 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/15843/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #15843      +/-   ##
   ==========================================
   - Coverage   77.13%   76.82%   -0.32%     
   ==========================================
     Files         984      985       +1     
     Lines       51706    51845     +139     
     Branches     6995     7028      +33     
   ==========================================
   - Hits        39882    39828      -54     
   - Misses      11600    11792     +192     
   - Partials      224      225       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `?` | |
   | postgres | `81.44% <29.09%> (-0.11%)` | :arrow_down: |
   | presto | `?` | |
   | python | `81.49% <29.09%> (-0.60%)` | :arrow_down: |
   | sqlite | `81.08% <29.09%> (-0.11%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `66.42% <0.00%> (-0.97%)` | :arrow_down: |
   | [...nfigModal/FiltersConfigForm/getControlItemsMap.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL2dldENvbnRyb2xJdGVtc01hcC50c3g=) | `87.50% <ø> (+1.53%)` | :arrow_up: |
   | [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `81.00% <ø> (+2.15%)` | :arrow_up: |
   | [superset/common/query\_actions.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2FjdGlvbnMucHk=) | `92.85% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.24% <ø> (ø)` | |
   | [superset/charts/post\_processing.py](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3Bvc3RfcHJvY2Vzc2luZy5weQ==) | `14.63% <14.63%> (ø)` | |
   | [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `41.48% <16.66%> (-2.97%)` | :arrow_down: |
   | [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `25.00% <50.00%> (+4.16%)` | :arrow_up: |
   | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `74.34% <61.53%> (+0.58%)` | :arrow_up: |
   | [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `72.83% <63.63%> (-5.11%)` | :arrow_down: |
   | ... and [31 more](https://codecov.io/gh/apache/superset/pull/15843/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f6fe29d...8853675](https://codecov.io/gh/apache/superset/pull/15843?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] betodealmeida commented on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-885792620


   > Hi @betodealmeida, Thanks for this improvement. But, please hold on to this PR. Can we do this by constructing a different query object on the front end?
   
   @zhaoyongjie I don't think we can. We would have to express the aggregation functions for the pivoting using the query context. For other text-based visualization like the t-test table it would also by really hard to express the statistical significance logic in a backend-agnostic query.
   
   What are your concerns here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] PowerPlop edited a comment on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
PowerPlop edited a comment on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-919915308


   @betodealmeida  using this option on a pivot table v2 that has 'number' fields (in the group by) and using the CSV format, gives me the following error:
   
   `{"errors": [{"message": "No objects to concatenate", "error_type": "GENERIC_BACKEND_ERROR", "level": "error", "extra": {"issue_codes": [{"code": 1011, "message": "Issue 1011 - Superset encountered an unexpected error."}]}}]}`
   
   When selecting json format, it works fine.
   
   
   Removing the number fields seems to fix the issue. Is this a known problem/limitation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie edited a comment on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-885339210


   Hi @betodealmeida, Thanks for this improvement. But, please hold on to this PR.  Can we do this by constructing a different query object on the front end? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] betodealmeida merged pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #15843:
URL: https://github.com/apache/superset/pull/15843


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie commented on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-886873385


   > > Hi @betodealmeida, Thanks for this improvement. But, please hold on to this PR. Can we do this by constructing a different query object on the front end?
   > 
   > @zhaoyongjie I don't think we can. We would have to express the aggregation functions for the pivoting using the query context. For other text-based visualization like the t-test table it would also by really hard to express the statistical significance logic in a backend-agnostic query.
   > 
   > What are your concerns here?
   
   Sorry for reply is a little late. The newest v1 API has `post_processing` field, we can do a similar pivot operation on the `df`. but it looks like the old query_object is not supported. I would need more time to research it. If this PR is urgent, I think we can merge it first.
   
   ![image](https://user-images.githubusercontent.com/2016594/127029577-9db8d6f5-5f74-4f13-a132-e1e2e624fa0c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie edited a comment on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-885339210


   Hi @betodealmeida, Please hold on to this PR.  Can we do this by constructing a different query object on the front end? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zhaoyongjie commented on pull request #15843: feat: apply post processing to chart data

Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #15843:
URL: https://github.com/apache/superset/pull/15843#issuecomment-885339210


   Hey @betodealmeida, Please hold on to this PR.  Can we do this by constructing a different query object on the front end? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org