[GitHub] [samza] prateekm commented on a change in pull request #1079: SAMZA-2250: Support large job models in standalone.

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1079: SAMZA-2250: Support large job models in standalone.
URL: https://github.com/apache/samza/pull/1079#discussion_r295022999
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/job/model/JobModelUtil.java
 ##########
 @@ -19,20 +19,33 @@
 package org.apache.samza.job.model;
 
 import com.google.common.base.Preconditions;
+import java.nio.charset.Charset;
+import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.HashSet;
+import java.util.List;
 import java.util.Map;
 import java.util.Set;
 import java.util.stream.Collectors;
 import org.apache.samza.container.TaskName;
 import org.apache.samza.system.SystemStream;
+import org.apache.samza.SamzaException;
+import org.apache.samza.metadatastore.MetadataStore;
+import org.apache.samza.serializers.model.SamzaObjectMapper;
 import org.apache.samza.system.SystemStreamPartition;
+import org.codehaus.jackson.map.ObjectMapper;
 
 /**
  * Utility class for the {@link JobModel}
  */
 public class JobModelUtil {
 
+  private static final ObjectMapper MAPPER = SamzaObjectMapper.getObjectMapper();
+
+  private static final int JOB_MODEL_SEGMENT_SIZE_IN_BYTES = 1020 * 1020;
 
 Review comment:
   It'll be better to add this comment in the code instead of magic numbers. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services